[PATCH v1 1/1] ASoC: cs35l56: Drop malformed default N from Kconfig

[PATCH v1 1/1] ASoC: cs35l56: Drop malformed default N from Kconfig

[Andy Shevchenko]

First of all, it has to be 'default n' (small letter n), otherwise
it looks for CONFIG_N which is absent and in case of appearance
will enable something unrelated. Second and most important is that
'n' *is* the default 'default' already. Hence just drop malformed
line.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 sound/soc/codecs/Kconfig | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
index 069ec05e4a61..db321b9f6771 100644
--- a/sound/soc/codecs/Kconfig
+++ b/sound/soc/codecs/Kconfig
@@ -900,7 +900,6 @@ menu "CS35L56 driver options"
 
 config SND_SOC_CS35L56_CAL_DEBUGFS
 	bool "CS35L56 create debugfs for factory calibration"
-	default N
 	depends on DEBUG_FS
 	select SND_SOC_CS35L56_CAL_DEBUGFS_COMMON
 	help
@@ -911,7 +910,6 @@ config SND_SOC_CS35L56_CAL_DEBUGFS
 
 config SND_SOC_CS35L56_CAL_SET_CTRL
 	bool "CS35L56 ALSA control to restore factory calibration"
-	default N
 	select SND_SOC_CS35L56_CAL_DEBUGFS_COMMON
 	help
 	  Allow restoring factory calibration data through an ALSA
@@ -925,7 +923,6 @@ config SND_SOC_CS35L56_CAL_SET_CTRL
 
 config SND_SOC_CS35L56_CAL_PERFORM_CTRL
 	bool "CS35L56 ALSA control to perform factory calibration"
-	default N
 	select SND_SOC_CS35L56_CAL_DEBUGFS_COMMON
 	help
 	  Allow performing factory calibration data through an ALSA
-- 
2.50.1

Re: [PATCH v1 1/1] ASoC: cs35l56: Drop malformed default N from Kconfig

[Richard Fitzgerald]

On 13/05/2026 5:26 pm, Andy Shevchenko wrote:
> First of all, it has to be 'default n' (small letter n), otherwise
> it looks for CONFIG_N which is absent and in case of appearance
> will enable something unrelated. Second and most important is that
> 'n' *is* the default 'default' already. Hence just drop malformed
> line.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>   sound/soc/codecs/Kconfig | 3 ---
>   1 file changed, 3 deletions(-)
> 
> diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
> index 069ec05e4a61..db321b9f6771 100644
> --- a/sound/soc/codecs/Kconfig
> +++ b/sound/soc/codecs/Kconfig
> @@ -900,7 +900,6 @@ menu "CS35L56 driver options"
>   
>   config SND_SOC_CS35L56_CAL_DEBUGFS
>   	bool "CS35L56 create debugfs for factory calibration"
> -	default N
>   	depends on DEBUG_FS
>   	select SND_SOC_CS35L56_CAL_DEBUGFS_COMMON
>   	help
> @@ -911,7 +910,6 @@ config SND_SOC_CS35L56_CAL_DEBUGFS
>   
>   config SND_SOC_CS35L56_CAL_SET_CTRL
>   	bool "CS35L56 ALSA control to restore factory calibration"
> -	default N
>   	select SND_SOC_CS35L56_CAL_DEBUGFS_COMMON
>   	help
>   	  Allow restoring factory calibration data through an ALSA
> @@ -925,7 +923,6 @@ config SND_SOC_CS35L56_CAL_SET_CTRL
>   
>   config SND_SOC_CS35L56_CAL_PERFORM_CTRL
>   	bool "CS35L56 ALSA control to perform factory calibration"
> -	default N
>   	select SND_SOC_CS35L56_CAL_DEBUGFS_COMMON
>   	help
>   	  Allow performing factory calibration data through an ALSA

Reviewed-by: Richard Fitzgerald <rf@opensource.cirrus.com>

Re: [PATCH v1 1/1] ASoC: cs35l56: Drop malformed default N from Kconfig

[Mark Brown]

On Wed, 13 May 2026 18:26:12 +0200, Andy Shevchenko wrote:
> ASoC: cs35l56: Drop malformed default N from Kconfig

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-7.1

Thanks!

[1/1] ASoC: cs35l56: Drop malformed default N from Kconfig
      https://git.kernel.org/broonie/sound/c/b96fe527935b

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark