* Re: [PATCH v4] docs: reporting-issues: replace "these advices" with "all of this advice"
2026-05-14 8:27 [PATCH v4] docs: reporting-issues: replace "these advices" with "all of this advice" Chen-Shi-Hong
@ 2026-05-14 8:56 ` WangYuli
2026-05-14 12:18 ` Jonathan Corbet
2026-05-15 13:56 ` Jonathan Corbet
1 sibling, 1 reply; 5+ messages in thread
From: WangYuli @ 2026-05-14 8:56 UTC (permalink / raw)
To: Chen-Shi-Hong, linux; +Cc: corbet, skhan, linux-doc, linux-kernel
Hi Chen-Shi-Hong,
On 2026/5/14 16:27, Chen-Shi-Hong wrote:
> "Advice" is an uncountable noun, so "these advices" is grammatically
> incorrect.
>
> Replace it with "all of this advice" instead, which keeps the sentence
> grammatical while also making it clear that it refers to the full set of
> recommendations in the paragraph.
>
> Signed-off-by: Chen-Shi-Hong <eric039eric@gmail.com>
> ---
> v4:
> - move version changelog below the "---"
> - send as a separate thread
>
> v3:
> - resend against the original base as requested
> - replace "these advices" directly with "all of this advice"
>
> v2:
> - use "all of this advice" based on review feedback
> Documentation/admin-guide/reporting-issues.rst | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/admin-guide/reporting-issues.rst b/Documentation/admin-guide/reporting-issues.rst
> index 16a66a1f1975..87dd874fffcf 100644
> --- a/Documentation/admin-guide/reporting-issues.rst
> +++ b/Documentation/admin-guide/reporting-issues.rst
> @@ -129,7 +129,7 @@ After these preparations you'll now enter the main part:
> situations; during the merge window that actually might be even the best
> approach, but in that development phase it can be an even better idea to
> suspend your efforts for a few days anyway. Whatever version you choose,
> - ideally use a 'vanilla' build. Ignoring these advices will dramatically
> + ideally use a 'vanilla' build. Ignoring all of this advice will dramatically
> increase the risk your report will be rejected or ignored.
>
> * Ensure the kernel you just installed does not 'taint' itself when
> @@ -795,7 +795,7 @@ Install a fresh kernel for testing
> situations; during the merge window that actually might be even the best
> approach, but in that development phase it can be an even better idea to
> suspend your efforts for a few days anyway. Whatever version you choose,
> - ideally use a 'vanilla' built. Ignoring these advices will dramatically
> + ideally use a 'vanilla' built. Ignoring all of this advice will dramatically
> increase the risk your report will be rejected or ignored.*
>
> As mentioned in the detailed explanation for the first step already: Like most
Reviewed-by: WangYuli <wangyl5933@chinaunicom.cn>
I searched the kernel tree for the misspelling "advices" (the word
"advice" is uncountable) and found the following occurrences:
"
>rg-i "advices"
tools/perf/trace/beauty/mmap.c
68: static DEFINE_STRARRAY(madvise_advices, "MADV_");
70: if (behavior < strarray__madvise_advices.nr_entries &&
strarray__madvise_advices.entries[behavior] != NULL)
71: return scnprintf(bf, size, "MADV_%s",
strarray__madvise_advices.entries[behavior]);
tools/perf/trace/beauty/madvise_behavior.sh
6:printf "static const char *madvise_advices[] = {\n"
tools/perf/trace/beauty/fadvise.sh
6:printf "static const char *fadvise_advices[] = {\n"
tools/include/uapi/README
26: static const char *fadvise_advices[] = {
tools/testing/selftests/mm/process_madv.c
125: * on a remote process, other advicesare difficult to verify
reliably.
tools/testing/selftests/mm/pfnmap.c
175:int advices[] = {
187:/* All these advicesmust be rejected. */
188:for (i = 0; i < ARRAY_SIZE(advices); i++) {
189:EXPECT_LT(madvise(self->addr1, self->pagesize, advices[i]), 0);
drivers/ata/pata_sis.c
13: * Daniela Engert: for initial ATA100 advicesand numerous others.
drivers/md/dm-vdo/message-stats.c
234:write_u64("dedupeAdviceStale : ", stats->dedupe_advice_stale, ",
", buf, maxlen);
Documentation/admin-guide/reporting-issues.rst
132: ideally use a 'vanilla' build. Ignoring these adviceswill
dramatically
798: ideally use a 'vanilla' built. Ignoring these adviceswill
dramatically
Documentation/usb/CREDITS
118: evaluation boards, specs and valuable advicesduring
Documentation/scsi/ChangeLog.sym53c8xx
415: my questions and for his interesting advicesand comments about
"
If you intend to fix this misspelling, please consider sending a
single patchset that corrects all of these instances across the tree
and adds "advices" to scripts/spelling.txt.
That waycheckpatch.pl <https://checkpatch.pl/> can catch it in the future.
Thanks,
---
WangYuli
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v4] docs: reporting-issues: replace "these advices" with "all of this advice"
2026-05-14 8:27 [PATCH v4] docs: reporting-issues: replace "these advices" with "all of this advice" Chen-Shi-Hong
2026-05-14 8:56 ` WangYuli
@ 2026-05-15 13:56 ` Jonathan Corbet
1 sibling, 0 replies; 5+ messages in thread
From: Jonathan Corbet @ 2026-05-15 13:56 UTC (permalink / raw)
To: Chen-Shi-Hong, linux; +Cc: skhan, linux-doc, linux-kernel, Chen-Shi-Hong
Chen-Shi-Hong <eric039eric@gmail.com> writes:
> "Advice" is an uncountable noun, so "these advices" is grammatically
> incorrect.
>
> Replace it with "all of this advice" instead, which keeps the sentence
> grammatical while also making it clear that it refers to the full set of
> recommendations in the paragraph.
>
> Signed-off-by: Chen-Shi-Hong <eric039eric@gmail.com>
> ---
> v4:
> - move version changelog below the "---"
> - send as a separate thread
>
> v3:
> - resend against the original base as requested
> - replace "these advices" directly with "all of this advice"
>
> v2:
> - use "all of this advice" based on review feedback
> Documentation/admin-guide/reporting-issues.rst | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Applied, thanks.
jon
^ permalink raw reply [flat|nested] 5+ messages in thread