mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Berkant Koc <me@berkoc.com>
To: Greg KH <gregkh@linuxfoundation.org>,
	Miklos Szeredi <miklos@szeredi.hu>,
	Bernd Schubert <bschubert@ddn.com>
Cc: security@kernel.org, Joanne Koong <joannelkoong@gmail.com>,
	linux-fuse@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 0/2] fuse: io-uring: fix two UAFs in dev_uring.c teardown
Date: Sun, 17 May 2026 14:59:27 +0200	[thread overview]
Message-ID: <20260517-fuse-uaf-cover@berkoc.com> (raw)
In-Reply-To: <2026051703-equinox-multitude-91e2@gregkh>

Applied on top of 6916d5703ddf. Thanks Greg for asking to take this
on-list; the original off-list report to security@kernel.org included
a defensive third patch that added cancel_delayed_work_sync() in
fuse_conn_put(), but it triggered a WARN_ON in queue_work() because
the work item is not always initialized at that point. That patch is
dropped from this series.

Patch 1/2 is the static-analysis fix: fuse_uring_commit_fetch() leaks
a dangling ent->fuse_req on the set_commit error branch. The patch
routes that branch through the existing fuse_uring_req_end() helper
so ent->fuse_req is cleared under queue->lock.

Patch 2/2 is the KASAN-reproducible fix: fuse_dev_release() on the
last fuse_dev drops the connection ref before the io-uring
async_teardown_work has stopped, so delayed_release() can kfree() ring
entries the work is still walking. Adding fuse_wait_aborted() between
fuse_abort_conn() and fuse_conn_put() drains queue_refs first.

KASAN-tested at HEAD 6916d5703ddf + this series, 50 iterations x 16
worker threads against an io-uring fuse daemon: 0 KASAN trips, 0
warnings. KASAN log on request.

Joanne Koong's [PATCH v2 0/3] (Message-ID
<20260516021138.2759874-1-joannelkoong@gmail.com>) is in flight on a
separate fuse-next base; this series targets mainline 6916d5703ddf and
does not overlap with hers in code or fix scope.

CCing linux-fuse and linux-kernel now per the on-list workflow.

Berkant Koc (2):
  fuse: io-uring: clear ent->fuse_req in commit_fetch error path
  fuse: wait for aborted connection before releasing last fuse_dev

 fs/fuse/dev.c       | 1 +
 fs/fuse/dev_uring.c | 4 +---
 2 files changed, 2 insertions(+), 3 deletions(-)

--
2.47.3

       reply	other threads:[~2026-05-17 12:59 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20260517095846.fuse-iouring-uaf.dc5f5dbb71dc@berkoc.com>
     [not found] ` <2026051703-equinox-multitude-91e2@gregkh>
2026-05-17 12:59   ` Berkant Koc [this message]
2026-05-17 12:59     ` [PATCH 1/2] fuse: io-uring: clear ent->fuse_req in commit_fetch error path Berkant Koc
2026-05-17 14:11       ` Bernd Schubert
2026-05-17 14:24         ` Berkant Koc
2026-05-17 12:59     ` [PATCH 2/2] fuse: wait for aborted connection before releasing last fuse_dev Berkant Koc
2026-05-17 15:00       ` Bernd Schubert
2026-05-18  1:13         ` Berkant Koc
2026-05-18  9:55           ` Bernd Schubert
2026-05-18 11:47             ` Bernd Schubert
2026-05-18 14:32               ` Berkant Koc
2026-05-18 14:46                 ` Bernd Schubert
2026-05-18 15:35                   ` Joanne Koong
2026-05-18 17:49                     ` Berkant Koc
2026-05-18 15:47                   ` Berkant Koc
2026-05-18  9:06         ` Pavel Begunkov
2026-05-18  9:50           ` Bernd Schubert
2026-05-18 10:32             ` Pavel Begunkov
2026-05-17 13:14     ` [PATCH 0/2] fuse: io-uring: fix two UAFs in dev_uring.c teardown Berkant Koc
2026-05-17 13:43       ` Bernd Schubert
2026-05-17 14:02         ` Berkant Koc

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260517-fuse-uaf-cover@berkoc.com \
    --to=me@berkoc.com \
    --cc=bschubert@ddn.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=joannelkoong@gmail.com \
    --cc=linux-fuse@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    --cc=security@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome