* [PATCH] ARM64: remove unnecessary architecture-specific <asm/device.h>
@ 2026-05-17 2:53 Ethan Nelson-Moore
2026-05-19 12:12 ` Will Deacon
2026-06-02 20:34 ` Will Deacon
0 siblings, 2 replies; 5+ messages in thread
From: Ethan Nelson-Moore @ 2026-05-17 2:53 UTC (permalink / raw)
To: linux-arm-kernel, linux-kernel
Cc: Ethan Nelson-Moore, Catalin Marinas, Will Deacon
arch/arm64/include/asm/device.h is identical to
include/asm-generic/device.h, and therefore the ARM64-specific version
is unnecessary. Remove it.
Signed-off-by: Ethan Nelson-Moore <enelsonmoore@gmail.com>
---
arch/arm64/include/asm/device.h | 14 --------------
1 file changed, 14 deletions(-)
delete mode 100644 arch/arm64/include/asm/device.h
diff --git a/arch/arm64/include/asm/device.h b/arch/arm64/include/asm/device.h
deleted file mode 100644
index 996498751318..000000000000
--- a/arch/arm64/include/asm/device.h
+++ /dev/null
@@ -1,14 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0-only */
-/*
- * Copyright (C) 2012 ARM Ltd.
- */
-#ifndef __ASM_DEVICE_H
-#define __ASM_DEVICE_H
-
-struct dev_archdata {
-};
-
-struct pdev_archdata {
-};
-
-#endif
--
2.43.0
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] ARM64: remove unnecessary architecture-specific <asm/device.h>
2026-05-17 2:53 [PATCH] ARM64: remove unnecessary architecture-specific <asm/device.h> Ethan Nelson-Moore
@ 2026-05-19 12:12 ` Will Deacon
2026-05-20 4:03 ` Ethan Nelson-Moore
2026-06-02 20:34 ` Will Deacon
1 sibling, 1 reply; 5+ messages in thread
From: Will Deacon @ 2026-05-19 12:12 UTC (permalink / raw)
To: Ethan Nelson-Moore; +Cc: linux-arm-kernel, linux-kernel, Catalin Marinas
On Sat, May 16, 2026 at 07:53:42PM -0700, Ethan Nelson-Moore wrote:
> arch/arm64/include/asm/device.h is identical to
> include/asm-generic/device.h, and therefore the ARM64-specific version
> is unnecessary. Remove it.
>
> Signed-off-by: Ethan Nelson-Moore <enelsonmoore@gmail.com>
> ---
> arch/arm64/include/asm/device.h | 14 --------------
> 1 file changed, 14 deletions(-)
> delete mode 100644 arch/arm64/include/asm/device.h
>
> diff --git a/arch/arm64/include/asm/device.h b/arch/arm64/include/asm/device.h
> deleted file mode 100644
> index 996498751318..000000000000
> --- a/arch/arm64/include/asm/device.h
> +++ /dev/null
> @@ -1,14 +0,0 @@
> -/* SPDX-License-Identifier: GPL-2.0-only */
> -/*
> - * Copyright (C) 2012 ARM Ltd.
> - */
> -#ifndef __ASM_DEVICE_H
> -#define __ASM_DEVICE_H
> -
> -struct dev_archdata {
> -};
> -
> -struct pdev_archdata {
> -};
> -
> -#endif
Do we need to add a generic-y entry to arch/arm64/include/asm/Kbuild
so that we pick up the asm-generic variant?
Will
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] ARM64: remove unnecessary architecture-specific <asm/device.h>
2026-05-19 12:12 ` Will Deacon
@ 2026-05-20 4:03 ` Ethan Nelson-Moore
2026-06-02 11:10 ` Will Deacon
0 siblings, 1 reply; 5+ messages in thread
From: Ethan Nelson-Moore @ 2026-05-20 4:03 UTC (permalink / raw)
To: Will Deacon; +Cc: linux-arm-kernel, linux-kernel, Catalin Marinas
Hi, Will,
On Tue, May 19, 2026 at 5:12 AM Will Deacon <will@kernel.org> wrote:
> Do we need to add a generic-y entry to arch/arm64/include/asm/Kbuild
> so that we pick up the asm-generic variant?
No, we don't, because device.h is in the list of mandatory headers in
include/asm-generic/Kbuild, which means a header including the generic
version will automatically be generated if an architecture-specific
version does not exist.
Ethan
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM64: remove unnecessary architecture-specific <asm/device.h>
2026-05-20 4:03 ` Ethan Nelson-Moore
@ 2026-06-02 11:10 ` Will Deacon
0 siblings, 0 replies; 5+ messages in thread
From: Will Deacon @ 2026-06-02 11:10 UTC (permalink / raw)
To: Ethan Nelson-Moore; +Cc: linux-arm-kernel, linux-kernel, Catalin Marinas
On Tue, May 19, 2026 at 09:03:06PM -0700, Ethan Nelson-Moore wrote:
> On Tue, May 19, 2026 at 5:12 AM Will Deacon <will@kernel.org> wrote:
> > Do we need to add a generic-y entry to arch/arm64/include/asm/Kbuild
> > so that we pick up the asm-generic variant?
>
> No, we don't, because device.h is in the list of mandatory headers in
> include/asm-generic/Kbuild, which means a header including the generic
> version will automatically be generated if an architecture-specific
> version does not exist.
Great, thanks for the explanation. I'll pick this up.
Will
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM64: remove unnecessary architecture-specific <asm/device.h>
2026-05-17 2:53 [PATCH] ARM64: remove unnecessary architecture-specific <asm/device.h> Ethan Nelson-Moore
2026-05-19 12:12 ` Will Deacon
@ 2026-06-02 20:34 ` Will Deacon
1 sibling, 0 replies; 5+ messages in thread
From: Will Deacon @ 2026-06-02 20:34 UTC (permalink / raw)
To: linux-arm-kernel, linux-kernel, Ethan Nelson-Moore
Cc: catalin.marinas, kernel-team, Will Deacon
On Sat, 16 May 2026 19:53:42 -0700, Ethan Nelson-Moore wrote:
> arch/arm64/include/asm/device.h is identical to
> include/asm-generic/device.h, and therefore the ARM64-specific version
> is unnecessary. Remove it.
>
>
Applied to arm64 (for-next/misc), thanks!
[1/1] ARM64: remove unnecessary architecture-specific <asm/device.h>
https://git.kernel.org/arm64/c/32e4c96d6a71
Cheers,
--
Will
https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-06-02 20:34 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-05-17 2:53 [PATCH] ARM64: remove unnecessary architecture-specific <asm/device.h> Ethan Nelson-Moore
2026-05-19 12:12 ` Will Deacon
2026-05-20 4:03 ` Ethan Nelson-Moore
2026-06-02 11:10 ` Will Deacon
2026-06-02 20:34 ` Will Deacon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome