* Re: [PATCH v2 03/11] m68k: mcf5441x: setup DAC clock name as per driver name
@ 2026-05-17 9:11 Angelo Dureghello
2026-05-17 11:43 ` Jonathan Cameron
2026-05-17 11:45 ` Geert Uytterhoeven
0 siblings, 2 replies; 8+ messages in thread
From: Angelo Dureghello @ 2026-05-17 9:11 UTC (permalink / raw)
To: Greg Ungerer
Cc: Geert Uytterhoeven, Steven King, Arnd Bergmann, Maxime Coquelin,
Alexandre Torgue, Jonathan Cameron, David Lechner, Nuno Sá,
Andy Shevchenko, Greg Ungerer, linux-m68k, linux-kernel,
linux-stm32, linux-arm-kernel, linux-iio
Hi Greg,
jfyi, for some reason i was not in to/cc, but i could grab the message
in lore.
On Thu, May 14, 2026 at 10:54:32PM +1000, Greg Ungerer wrote:
> Hi Angelo,
>
> On 14/5/26 17:05, Angelo Dureghello wrote:
> > Hi Greg,
> >
> > On 14.05.2026 11:27, Greg Ungerer wrote:
> > > Hi Angelo,
> > >
> > > On 13/5/26 19:14, Angelo Dureghello wrote:
> > > > From: Angelo Dureghello <adureghello@baylibre.com>
> > > >
> > > > Later in this patchset, the mcf54415 DAC driver is added.
> > > > Considering some other different ColdFire cpu DACs exists, the DAC driver
> > > > is named as "mcf54415_dac", related to the mcf5441x family SoCs with
> > > > DACs (mcf54415/6/7/8).
> > > >
> > > > So updating DAC clock names to bind with proper driver name.
> > >
> > > I am not sure I like naming the clocks here with a prefix for the
> > > specific SoC part number this is in. It might be unlikely now, but
> > > what if another ColdFire family SoC member uses this same hardware block?
> > > That is very common amongst other hardware blocks within the ColdFire
> > > family. Can we come up with a name more specific to just this type
> > > of DAC hardware block?
> > >
> >
> > from a brief study, this 12bit DAC, and DAC module in general, is only on
> > this mcf45441x family. There are some ColdFire with ADC only, as those
> > mcf5249/53/82.
> > The mcf51mm/ag/je are the opnly to have a 5bit dacs, but these are mcus.
> > So, if i don't miss any existing model, the name may be correct,
> > unless we want rename it to a more generic mcf_dac.
>
> Yes, I would suggest just leaving it as is, "mcfdac".
> That is not currently used by any other ColdFire variants supported by
> the kernel.
>
Ok, will fix this in a v3, just asking confirmation on the name to
Jonathan and all, since it involves iio too.
Chaches are:
mcfdac
mcf-dac or mcf_dac (we have drivers as vf610_dac and cio-dac)
Regards,
angelo
> Regards
> Greg
>
>
>
> > > Regards
> > > Greg
> > >
> > >
> >
> > Regards,
> > angelo
> > >
> > >
> > > > Signed-off-by: Angelo Dureghello <adureghello@baylibre.com>
> > > > ---
> > > > arch/m68k/coldfire/m5441x.c | 8 ++++----
> > > > 1 file changed, 4 insertions(+), 4 deletions(-)
> > > >
> > > > diff --git a/arch/m68k/coldfire/m5441x.c b/arch/m68k/coldfire/m5441x.c
> > > > index 5b5e09ecf487..b724d7fc1a08 100644
> > > > --- a/arch/m68k/coldfire/m5441x.c
> > > > +++ b/arch/m68k/coldfire/m5441x.c
> > > > @@ -43,8 +43,8 @@ DEFINE_CLK(0, "mcfpit.2", 34, MCF_BUSCLK);
> > > > DEFINE_CLK(0, "mcfpit.3", 35, MCF_BUSCLK);
> > > > DEFINE_CLK(0, "mcfeport.0", 36, MCF_CLK);
> > > > DEFINE_CLK(0, "mcfadc.0", 37, MCF_CLK);
> > > > -DEFINE_CLK(0, "mcfdac.0", 38, MCF_CLK);
> > > > -DEFINE_CLK(0, "mcfdac.1", 39, MCF_CLK);
> > > > +DEFINE_CLK(0, "mcf54415_dac.0", 38, MCF_CLK);
> > > > +DEFINE_CLK(0, "mcf54415_dac.1", 39, MCF_CLK);
> > > > DEFINE_CLK(0, "mcfrtc.0", 42, MCF_CLK);
> > > > DEFINE_CLK(0, "mcfsim.0", 43, MCF_CLK);
> > > > DEFINE_CLK(0, "mcfusb-otg.0", 44, MCF_CLK);
> > > > @@ -106,8 +106,8 @@ static struct clk_lookup m5411x_clk_lookup[] = {
> > > > CLKDEV_INIT("mcfpit.3", NULL, &__clk_0_35),
> > > > CLKDEV_INIT("mcfeport.0", NULL, &__clk_0_36),
> > > > CLKDEV_INIT("mcfadc.0", NULL, &__clk_0_37),
> > > > - CLKDEV_INIT("mcfdac.0", NULL, &__clk_0_38),
> > > > - CLKDEV_INIT("mcfdac.1", NULL, &__clk_0_39),
> > > > + CLKDEV_INIT("mcf54415_dac.0", NULL, &__clk_0_38),
> > > > + CLKDEV_INIT("mcf54415_dac.1", NULL, &__clk_0_39),
> > > > CLKDEV_INIT("mcfrtc.0", NULL, &__clk_0_42),
> > > > CLKDEV_INIT("mcfsim.0", NULL, &__clk_0_43),
> > > > CLKDEV_INIT("mcfusb-otg.0", NULL, &__clk_0_44),
> > > >
> > >
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 03/11] m68k: mcf5441x: setup DAC clock name as per driver name
2026-05-17 9:11 [PATCH v2 03/11] m68k: mcf5441x: setup DAC clock name as per driver name Angelo Dureghello
@ 2026-05-17 11:43 ` Jonathan Cameron
2026-05-17 11:45 ` Geert Uytterhoeven
1 sibling, 0 replies; 8+ messages in thread
From: Jonathan Cameron @ 2026-05-17 11:43 UTC (permalink / raw)
To: Angelo Dureghello
Cc: Greg Ungerer, Geert Uytterhoeven, Steven King, Arnd Bergmann,
Maxime Coquelin, Alexandre Torgue, David Lechner, Nuno Sá,
Andy Shevchenko, Greg Ungerer, linux-m68k, linux-kernel,
linux-stm32, linux-arm-kernel, linux-iio
On Sun, 17 May 2026 02:11:33 -0700
Angelo Dureghello <adureghello@baylibre.com> wrote:
> Hi Greg,
>
> jfyi, for some reason i was not in to/cc, but i could grab the message
> in lore.
>
> On Thu, May 14, 2026 at 10:54:32PM +1000, Greg Ungerer wrote:
> > Hi Angelo,
> >
> > On 14/5/26 17:05, Angelo Dureghello wrote:
> > > Hi Greg,
> > >
> > > On 14.05.2026 11:27, Greg Ungerer wrote:
> > > > Hi Angelo,
> > > >
> > > > On 13/5/26 19:14, Angelo Dureghello wrote:
> > > > > From: Angelo Dureghello <adureghello@baylibre.com>
> > > > >
> > > > > Later in this patchset, the mcf54415 DAC driver is added.
> > > > > Considering some other different ColdFire cpu DACs exists, the DAC driver
> > > > > is named as "mcf54415_dac", related to the mcf5441x family SoCs with
> > > > > DACs (mcf54415/6/7/8).
> > > > >
> > > > > So updating DAC clock names to bind with proper driver name.
> > > >
> > > > I am not sure I like naming the clocks here with a prefix for the
> > > > specific SoC part number this is in. It might be unlikely now, but
> > > > what if another ColdFire family SoC member uses this same hardware block?
> > > > That is very common amongst other hardware blocks within the ColdFire
> > > > family. Can we come up with a name more specific to just this type
> > > > of DAC hardware block?
> > > >
> > >
> > > from a brief study, this 12bit DAC, and DAC module in general, is only on
> > > this mcf45441x family. There are some ColdFire with ADC only, as those
> > > mcf5249/53/82.
> > > The mcf51mm/ag/je are the opnly to have a 5bit dacs, but these are mcus.
> > > So, if i don't miss any existing model, the name may be correct,
> > > unless we want rename it to a more generic mcf_dac.
> >
> > Yes, I would suggest just leaving it as is, "mcfdac".
> > That is not currently used by any other ColdFire variants supported by
> > the kernel.
> >
>
> Ok, will fix this in a v3, just asking confirmation on the name to
> Jonathan and all, since it involves iio too.
>
> Chaches are:
> mcfdac
> mcf-dac or mcf_dac (we have drivers as vf610_dac and cio-dac)
I'm a bit lost. If we are talking about clocks that's fine as confusion is very
unlikely. If we are talking driver naming - pick a part on which it exists and
name it after that.
Historically we made a few mistakes letting in very generic driver names
and it causes confusion when a non compatible part comes along.
If we know these have 'versions' of IP like the QC ones do, then we could name
them after generations but that is often not actually documented anywhere
so would need confirmation from Coldfire folk.
Jonathan
>
> Regards,
> angelo
>
> > Regards
> > Greg
> >
> >
>
>
>
> >
> > > > Regards
> > > > Greg
> > > >
> > > >
> > >
> > > Regards,
> > > angelo
> > > >
> > > >
> > > > > Signed-off-by: Angelo Dureghello <adureghello@baylibre.com>
> > > > > ---
> > > > > arch/m68k/coldfire/m5441x.c | 8 ++++----
> > > > > 1 file changed, 4 insertions(+), 4 deletions(-)
> > > > >
> > > > > diff --git a/arch/m68k/coldfire/m5441x.c b/arch/m68k/coldfire/m5441x.c
> > > > > index 5b5e09ecf487..b724d7fc1a08 100644
> > > > > --- a/arch/m68k/coldfire/m5441x.c
> > > > > +++ b/arch/m68k/coldfire/m5441x.c
> > > > > @@ -43,8 +43,8 @@ DEFINE_CLK(0, "mcfpit.2", 34, MCF_BUSCLK);
> > > > > DEFINE_CLK(0, "mcfpit.3", 35, MCF_BUSCLK);
> > > > > DEFINE_CLK(0, "mcfeport.0", 36, MCF_CLK);
> > > > > DEFINE_CLK(0, "mcfadc.0", 37, MCF_CLK);
> > > > > -DEFINE_CLK(0, "mcfdac.0", 38, MCF_CLK);
> > > > > -DEFINE_CLK(0, "mcfdac.1", 39, MCF_CLK);
> > > > > +DEFINE_CLK(0, "mcf54415_dac.0", 38, MCF_CLK);
> > > > > +DEFINE_CLK(0, "mcf54415_dac.1", 39, MCF_CLK);
> > > > > DEFINE_CLK(0, "mcfrtc.0", 42, MCF_CLK);
> > > > > DEFINE_CLK(0, "mcfsim.0", 43, MCF_CLK);
> > > > > DEFINE_CLK(0, "mcfusb-otg.0", 44, MCF_CLK);
> > > > > @@ -106,8 +106,8 @@ static struct clk_lookup m5411x_clk_lookup[] = {
> > > > > CLKDEV_INIT("mcfpit.3", NULL, &__clk_0_35),
> > > > > CLKDEV_INIT("mcfeport.0", NULL, &__clk_0_36),
> > > > > CLKDEV_INIT("mcfadc.0", NULL, &__clk_0_37),
> > > > > - CLKDEV_INIT("mcfdac.0", NULL, &__clk_0_38),
> > > > > - CLKDEV_INIT("mcfdac.1", NULL, &__clk_0_39),
> > > > > + CLKDEV_INIT("mcf54415_dac.0", NULL, &__clk_0_38),
> > > > > + CLKDEV_INIT("mcf54415_dac.1", NULL, &__clk_0_39),
> > > > > CLKDEV_INIT("mcfrtc.0", NULL, &__clk_0_42),
> > > > > CLKDEV_INIT("mcfsim.0", NULL, &__clk_0_43),
> > > > > CLKDEV_INIT("mcfusb-otg.0", NULL, &__clk_0_44),
> > > > >
> > > >
> >
> >
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 03/11] m68k: mcf5441x: setup DAC clock name as per driver name
2026-05-17 9:11 [PATCH v2 03/11] m68k: mcf5441x: setup DAC clock name as per driver name Angelo Dureghello
2026-05-17 11:43 ` Jonathan Cameron
@ 2026-05-17 11:45 ` Geert Uytterhoeven
2026-05-17 17:22 ` Angelo Dureghello
1 sibling, 1 reply; 8+ messages in thread
From: Geert Uytterhoeven @ 2026-05-17 11:45 UTC (permalink / raw)
To: Angelo Dureghello
Cc: Steven King, Greg Ungerer, Arnd Bergmann, Maxime Coquelin,
Alexandre Torgue, Jonathan Cameron, David Lechner, Nuno Sá,
Andy Shevchenko, Greg Ungerer, linux-m68k, linux-kernel,
linux-stm32, linux-arm-kernel, linux-iio
Hi Angelo,
There's something wrong with "Mail-Followup-To:", which lists everyone,
except for you...
On Sun, 17 May 2026 at 11:11, Angelo Dureghello
<adureghello@baylibre.com> wrote:
> jfyi, for some reason i was not in to/cc, but i could grab the message
> in lore.
Might be related...
> On Thu, May 14, 2026 at 10:54:32PM +1000, Greg Ungerer wrote:
> > On 14/5/26 17:05, Angelo Dureghello wrote:
> > > On 14.05.2026 11:27, Greg Ungerer wrote:
> > > > On 13/5/26 19:14, Angelo Dureghello wrote:
> > > > > From: Angelo Dureghello <adureghello@baylibre.com>
> > > > >
> > > > > Later in this patchset, the mcf54415 DAC driver is added.
> > > > > Considering some other different ColdFire cpu DACs exists, the DAC driver
> > > > > is named as "mcf54415_dac", related to the mcf5441x family SoCs with
> > > > > DACs (mcf54415/6/7/8).
> > > > >
> > > > > So updating DAC clock names to bind with proper driver name.
> > > >
> > > > I am not sure I like naming the clocks here with a prefix for the
> > > > specific SoC part number this is in. It might be unlikely now, but
> > > > what if another ColdFire family SoC member uses this same hardware block?
> > > > That is very common amongst other hardware blocks within the ColdFire
> > > > family. Can we come up with a name more specific to just this type
> > > > of DAC hardware block?
> > > >
> > >
> > > from a brief study, this 12bit DAC, and DAC module in general, is only on
> > > this mcf45441x family. There are some ColdFire with ADC only, as those
> > > mcf5249/53/82.
> > > The mcf51mm/ag/je are the opnly to have a 5bit dacs, but these are mcus.
> > > So, if i don't miss any existing model, the name may be correct,
> > > unless we want rename it to a more generic mcf_dac.
> >
> > Yes, I would suggest just leaving it as is, "mcfdac".
> > That is not currently used by any other ColdFire variants supported by
> > the kernel.
> >
>
> Ok, will fix this in a v3, just asking confirmation on the name to
> Jonathan and all, since it involves iio too.
>
> Chaches are:
> mcfdac
> mcf-dac or mcf_dac (we have drivers as vf610_dac and cio-dac)
The clock names in arch/m68k/coldfire/m5441x.c are the names as
specified by the producer side, not by the consumer side.
> > > > > --- a/arch/m68k/coldfire/m5441x.c
> > > > > +++ b/arch/m68k/coldfire/m5441x.c
> > > > > @@ -43,8 +43,8 @@ DEFINE_CLK(0, "mcfpit.2", 34, MCF_BUSCLK);
> > > > > DEFINE_CLK(0, "mcfpit.3", 35, MCF_BUSCLK);
> > > > > DEFINE_CLK(0, "mcfeport.0", 36, MCF_CLK);
> > > > > DEFINE_CLK(0, "mcfadc.0", 37, MCF_CLK);
> > > > > -DEFINE_CLK(0, "mcfdac.0", 38, MCF_CLK);
> > > > > -DEFINE_CLK(0, "mcfdac.1", 39, MCF_CLK);
> > > > > +DEFINE_CLK(0, "mcf54415_dac.0", 38, MCF_CLK);
> > > > > +DEFINE_CLK(0, "mcf54415_dac.1", 39, MCF_CLK);
> > > > > DEFINE_CLK(0, "mcfrtc.0", 42, MCF_CLK);
> > > > > DEFINE_CLK(0, "mcfsim.0", 43, MCF_CLK);
> > > > > DEFINE_CLK(0, "mcfusb-otg.0", 44, MCF_CLK);
> > > > > @@ -106,8 +106,8 @@ static struct clk_lookup m5411x_clk_lookup[] = {
> > > > > CLKDEV_INIT("mcfpit.3", NULL, &__clk_0_35),
> > > > > CLKDEV_INIT("mcfeport.0", NULL, &__clk_0_36),
> > > > > CLKDEV_INIT("mcfadc.0", NULL, &__clk_0_37),
> > > > > - CLKDEV_INIT("mcfdac.0", NULL, &__clk_0_38),
> > > > > - CLKDEV_INIT("mcfdac.1", NULL, &__clk_0_39),
> > > > > + CLKDEV_INIT("mcf54415_dac.0", NULL, &__clk_0_38),
> > > > > + CLKDEV_INIT("mcf54415_dac.1", NULL, &__clk_0_39),
> > > > > CLKDEV_INIT("mcfrtc.0", NULL, &__clk_0_42),
> > > > > CLKDEV_INIT("mcfsim.0", NULL, &__clk_0_43),
> > > > > CLKDEV_INIT("mcfusb-otg.0", NULL, &__clk_0_44),
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 03/11] m68k: mcf5441x: setup DAC clock name as per driver name
2026-05-17 11:45 ` Geert Uytterhoeven
@ 2026-05-17 17:22 ` Angelo Dureghello
0 siblings, 0 replies; 8+ messages in thread
From: Angelo Dureghello @ 2026-05-17 17:22 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Angelo Dureghello, Steven King, Greg Ungerer, Arnd Bergmann,
Maxime Coquelin, Alexandre Torgue, Jonathan Cameron,
David Lechner, Nuno Sá,
Andy Shevchenko, Greg Ungerer, linux-m68k, linux-kernel,
linux-stm32, linux-arm-kernel, linux-iio
Hi,
On Sun, May 17, 2026 at 01:45:44PM +0200, Geert Uytterhoeven wrote:
> Hi Angelo,
>
> There's something wrong with "Mail-Followup-To:", which lists everyone,
> except for you...
>
> On Sun, 17 May 2026 at 11:11, Angelo Dureghello
> <adureghello@baylibre.com> wrote:
> > jfyi, for some reason i was not in to/cc, but i could grab the message
> > in lore.
>
> Might be related...
>
yes, imported the raw msg from lore but was not allowed to send from
lieer, so i removed In-Reply-To:, anyway, thread seems back ok now.
> > On Thu, May 14, 2026 at 10:54:32PM +1000, Greg Ungerer wrote:
> > > On 14/5/26 17:05, Angelo Dureghello wrote:
> > > > On 14.05.2026 11:27, Greg Ungerer wrote:
> > > > > On 13/5/26 19:14, Angelo Dureghello wrote:
> > > > > > From: Angelo Dureghello <adureghello@baylibre.com>
> > > > > >
> > > > > > Later in this patchset, the mcf54415 DAC driver is added.
> > > > > > Considering some other different ColdFire cpu DACs exists, the DAC driver
> > > > > > is named as "mcf54415_dac", related to the mcf5441x family SoCs with
> > > > > > DACs (mcf54415/6/7/8).
> > > > > >
> > > > > > So updating DAC clock names to bind with proper driver name.
> > > > >
> > > > > I am not sure I like naming the clocks here with a prefix for the
> > > > > specific SoC part number this is in. It might be unlikely now, but
> > > > > what if another ColdFire family SoC member uses this same hardware block?
> > > > > That is very common amongst other hardware blocks within the ColdFire
> > > > > family. Can we come up with a name more specific to just this type
> > > > > of DAC hardware block?
> > > > >
> > > >
> > > > from a brief study, this 12bit DAC, and DAC module in general, is only on
> > > > this mcf45441x family. There are some ColdFire with ADC only, as those
> > > > mcf5249/53/82.
> > > > The mcf51mm/ag/je are the opnly to have a 5bit dacs, but these are mcus.
> > > > So, if i don't miss any existing model, the name may be correct,
> > > > unless we want rename it to a more generic mcf_dac.
> > >
> > > Yes, I would suggest just leaving it as is, "mcfdac".
> > > That is not currently used by any other ColdFire variants supported by
> > > the kernel.
> > >
> >
> > Ok, will fix this in a v3, just asking confirmation on the name to
> > Jonathan and all, since it involves iio too.
> >
> > Chaches are:
> > mcfdac
> > mcf-dac or mcf_dac (we have drivers as vf610_dac and cio-dac)
>
> The clock names in arch/m68k/coldfire/m5441x.c are the names as
> specified by the producer side, not by the consumer side.
yes sorry, i confused DEFINE_CLK with CLKDEV_INIT where the driver name
must be set.
So sure, thanks, fixing clock names back as mcfdac in v3.
>
> > > > > > --- a/arch/m68k/coldfire/m5441x.c
> > > > > > +++ b/arch/m68k/coldfire/m5441x.c
> > > > > > @@ -43,8 +43,8 @@ DEFINE_CLK(0, "mcfpit.2", 34, MCF_BUSCLK);
> > > > > > DEFINE_CLK(0, "mcfpit.3", 35, MCF_BUSCLK);
> > > > > > DEFINE_CLK(0, "mcfeport.0", 36, MCF_CLK);
> > > > > > DEFINE_CLK(0, "mcfadc.0", 37, MCF_CLK);
> > > > > > -DEFINE_CLK(0, "mcfdac.0", 38, MCF_CLK);
> > > > > > -DEFINE_CLK(0, "mcfdac.1", 39, MCF_CLK);
> > > > > > +DEFINE_CLK(0, "mcf54415_dac.0", 38, MCF_CLK);
> > > > > > +DEFINE_CLK(0, "mcf54415_dac.1", 39, MCF_CLK);
> > > > > > DEFINE_CLK(0, "mcfrtc.0", 42, MCF_CLK);
> > > > > > DEFINE_CLK(0, "mcfsim.0", 43, MCF_CLK);
> > > > > > DEFINE_CLK(0, "mcfusb-otg.0", 44, MCF_CLK);
> > > > > > @@ -106,8 +106,8 @@ static struct clk_lookup m5411x_clk_lookup[] = {
> > > > > > CLKDEV_INIT("mcfpit.3", NULL, &__clk_0_35),
> > > > > > CLKDEV_INIT("mcfeport.0", NULL, &__clk_0_36),
> > > > > > CLKDEV_INIT("mcfadc.0", NULL, &__clk_0_37),
> > > > > > - CLKDEV_INIT("mcfdac.0", NULL, &__clk_0_38),
> > > > > > - CLKDEV_INIT("mcfdac.1", NULL, &__clk_0_39),
> > > > > > + CLKDEV_INIT("mcf54415_dac.0", NULL, &__clk_0_38),
> > > > > > + CLKDEV_INIT("mcf54415_dac.1", NULL, &__clk_0_39),
> > > > > > CLKDEV_INIT("mcfrtc.0", NULL, &__clk_0_42),
> > > > > > CLKDEV_INIT("mcfsim.0", NULL, &__clk_0_43),
> > > > > > CLKDEV_INIT("mcfusb-otg.0", NULL, &__clk_0_44),
>
> Gr{oetje,eeting}s,
>
> Geert
>
Regards,
angelo
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 03/11] m68k: mcf5441x: setup DAC clock name as per driver name
2026-05-14 7:05 ` Angelo Dureghello
@ 2026-05-14 12:54 ` Greg Ungerer
0 siblings, 0 replies; 8+ messages in thread
From: Greg Ungerer @ 2026-05-14 12:54 UTC (permalink / raw)
To: Geert Uytterhoeven, Steven King, Arnd Bergmann, Maxime Coquelin,
Alexandre Torgue, Jonathan Cameron, David Lechner, Nuno Sá,
Andy Shevchenko, Greg Ungerer, linux-m68k, linux-kernel,
linux-stm32, linux-arm-kernel, linux-iio
Hi Angelo,
On 14/5/26 17:05, Angelo Dureghello wrote:
> Hi Greg,
>
> On 14.05.2026 11:27, Greg Ungerer wrote:
>> Hi Angelo,
>>
>> On 13/5/26 19:14, Angelo Dureghello wrote:
>>> From: Angelo Dureghello <adureghello@baylibre.com>
>>>
>>> Later in this patchset, the mcf54415 DAC driver is added.
>>> Considering some other different ColdFire cpu DACs exists, the DAC driver
>>> is named as "mcf54415_dac", related to the mcf5441x family SoCs with
>>> DACs (mcf54415/6/7/8).
>>>
>>> So updating DAC clock names to bind with proper driver name.
>>
>> I am not sure I like naming the clocks here with a prefix for the
>> specific SoC part number this is in. It might be unlikely now, but
>> what if another ColdFire family SoC member uses this same hardware block?
>> That is very common amongst other hardware blocks within the ColdFire
>> family. Can we come up with a name more specific to just this type
>> of DAC hardware block?
>>
>
> from a brief study, this 12bit DAC, and DAC module in general, is only on
> this mcf45441x family. There are some ColdFire with ADC only, as those
> mcf5249/53/82.
> The mcf51mm/ag/je are the opnly to have a 5bit dacs, but these are mcus.
> So, if i don't miss any existing model, the name may be correct,
> unless we want rename it to a more generic mcf_dac.
Yes, I would suggest just leaving it as is, "mcfdac".
That is not currently used by any other ColdFire variants supported by
the kernel.
Regards
Greg
>> Regards
>> Greg
>>
>>
>
> Regards,
> angelo
>>
>>
>>> Signed-off-by: Angelo Dureghello <adureghello@baylibre.com>
>>> ---
>>> arch/m68k/coldfire/m5441x.c | 8 ++++----
>>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/arch/m68k/coldfire/m5441x.c b/arch/m68k/coldfire/m5441x.c
>>> index 5b5e09ecf487..b724d7fc1a08 100644
>>> --- a/arch/m68k/coldfire/m5441x.c
>>> +++ b/arch/m68k/coldfire/m5441x.c
>>> @@ -43,8 +43,8 @@ DEFINE_CLK(0, "mcfpit.2", 34, MCF_BUSCLK);
>>> DEFINE_CLK(0, "mcfpit.3", 35, MCF_BUSCLK);
>>> DEFINE_CLK(0, "mcfeport.0", 36, MCF_CLK);
>>> DEFINE_CLK(0, "mcfadc.0", 37, MCF_CLK);
>>> -DEFINE_CLK(0, "mcfdac.0", 38, MCF_CLK);
>>> -DEFINE_CLK(0, "mcfdac.1", 39, MCF_CLK);
>>> +DEFINE_CLK(0, "mcf54415_dac.0", 38, MCF_CLK);
>>> +DEFINE_CLK(0, "mcf54415_dac.1", 39, MCF_CLK);
>>> DEFINE_CLK(0, "mcfrtc.0", 42, MCF_CLK);
>>> DEFINE_CLK(0, "mcfsim.0", 43, MCF_CLK);
>>> DEFINE_CLK(0, "mcfusb-otg.0", 44, MCF_CLK);
>>> @@ -106,8 +106,8 @@ static struct clk_lookup m5411x_clk_lookup[] = {
>>> CLKDEV_INIT("mcfpit.3", NULL, &__clk_0_35),
>>> CLKDEV_INIT("mcfeport.0", NULL, &__clk_0_36),
>>> CLKDEV_INIT("mcfadc.0", NULL, &__clk_0_37),
>>> - CLKDEV_INIT("mcfdac.0", NULL, &__clk_0_38),
>>> - CLKDEV_INIT("mcfdac.1", NULL, &__clk_0_39),
>>> + CLKDEV_INIT("mcf54415_dac.0", NULL, &__clk_0_38),
>>> + CLKDEV_INIT("mcf54415_dac.1", NULL, &__clk_0_39),
>>> CLKDEV_INIT("mcfrtc.0", NULL, &__clk_0_42),
>>> CLKDEV_INIT("mcfsim.0", NULL, &__clk_0_43),
>>> CLKDEV_INIT("mcfusb-otg.0", NULL, &__clk_0_44),
>>>
>>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 03/11] m68k: mcf5441x: setup DAC clock name as per driver name
2026-05-14 1:27 ` Greg Ungerer
@ 2026-05-14 7:05 ` Angelo Dureghello
2026-05-14 12:54 ` Greg Ungerer
0 siblings, 1 reply; 8+ messages in thread
From: Angelo Dureghello @ 2026-05-14 7:05 UTC (permalink / raw)
To: Greg Ungerer
Cc: Geert Uytterhoeven, Steven King, Arnd Bergmann, Maxime Coquelin,
Alexandre Torgue, Jonathan Cameron, David Lechner, Nuno Sá,
Andy Shevchenko, Greg Ungerer, linux-m68k, linux-kernel,
linux-stm32, linux-arm-kernel, linux-iio
Hi Greg,
On 14.05.2026 11:27, Greg Ungerer wrote:
> Hi Angelo,
>
> On 13/5/26 19:14, Angelo Dureghello wrote:
> > From: Angelo Dureghello <adureghello@baylibre.com>
> >
> > Later in this patchset, the mcf54415 DAC driver is added.
> > Considering some other different ColdFire cpu DACs exists, the DAC driver
> > is named as "mcf54415_dac", related to the mcf5441x family SoCs with
> > DACs (mcf54415/6/7/8).
> >
> > So updating DAC clock names to bind with proper driver name.
>
> I am not sure I like naming the clocks here with a prefix for the
> specific SoC part number this is in. It might be unlikely now, but
> what if another ColdFire family SoC member uses this same hardware block?
> That is very common amongst other hardware blocks within the ColdFire
> family. Can we come up with a name more specific to just this type
> of DAC hardware block?
>
from a brief study, this 12bit DAC, and DAC module in general, is only on
this mcf45441x family. There are some ColdFire with ADC only, as those
mcf5249/53/82.
The mcf51mm/ag/je are the opnly to have a 5bit dacs, but these are mcus.
So, if i don't miss any existing model, the name may be correct,
unless we want rename it to a more generic mcf_dac.
> Regards
> Greg
>
>
Regards,
angelo
>
>
> > Signed-off-by: Angelo Dureghello <adureghello@baylibre.com>
> > ---
> > arch/m68k/coldfire/m5441x.c | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/arch/m68k/coldfire/m5441x.c b/arch/m68k/coldfire/m5441x.c
> > index 5b5e09ecf487..b724d7fc1a08 100644
> > --- a/arch/m68k/coldfire/m5441x.c
> > +++ b/arch/m68k/coldfire/m5441x.c
> > @@ -43,8 +43,8 @@ DEFINE_CLK(0, "mcfpit.2", 34, MCF_BUSCLK);
> > DEFINE_CLK(0, "mcfpit.3", 35, MCF_BUSCLK);
> > DEFINE_CLK(0, "mcfeport.0", 36, MCF_CLK);
> > DEFINE_CLK(0, "mcfadc.0", 37, MCF_CLK);
> > -DEFINE_CLK(0, "mcfdac.0", 38, MCF_CLK);
> > -DEFINE_CLK(0, "mcfdac.1", 39, MCF_CLK);
> > +DEFINE_CLK(0, "mcf54415_dac.0", 38, MCF_CLK);
> > +DEFINE_CLK(0, "mcf54415_dac.1", 39, MCF_CLK);
> > DEFINE_CLK(0, "mcfrtc.0", 42, MCF_CLK);
> > DEFINE_CLK(0, "mcfsim.0", 43, MCF_CLK);
> > DEFINE_CLK(0, "mcfusb-otg.0", 44, MCF_CLK);
> > @@ -106,8 +106,8 @@ static struct clk_lookup m5411x_clk_lookup[] = {
> > CLKDEV_INIT("mcfpit.3", NULL, &__clk_0_35),
> > CLKDEV_INIT("mcfeport.0", NULL, &__clk_0_36),
> > CLKDEV_INIT("mcfadc.0", NULL, &__clk_0_37),
> > - CLKDEV_INIT("mcfdac.0", NULL, &__clk_0_38),
> > - CLKDEV_INIT("mcfdac.1", NULL, &__clk_0_39),
> > + CLKDEV_INIT("mcf54415_dac.0", NULL, &__clk_0_38),
> > + CLKDEV_INIT("mcf54415_dac.1", NULL, &__clk_0_39),
> > CLKDEV_INIT("mcfrtc.0", NULL, &__clk_0_42),
> > CLKDEV_INIT("mcfsim.0", NULL, &__clk_0_43),
> > CLKDEV_INIT("mcfusb-otg.0", NULL, &__clk_0_44),
> >
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 03/11] m68k: mcf5441x: setup DAC clock name as per driver name
2026-05-13 9:14 ` [PATCH v2 03/11] m68k: mcf5441x: setup DAC clock name as per driver name Angelo Dureghello
@ 2026-05-14 1:27 ` Greg Ungerer
2026-05-14 7:05 ` Angelo Dureghello
0 siblings, 1 reply; 8+ messages in thread
From: Greg Ungerer @ 2026-05-14 1:27 UTC (permalink / raw)
To: Angelo Dureghello, Geert Uytterhoeven, Steven King,
Arnd Bergmann, Maxime Coquelin, Alexandre Torgue,
Jonathan Cameron, David Lechner, Nuno Sá,
Andy Shevchenko
Cc: Greg Ungerer, linux-m68k, linux-kernel, linux-stm32,
linux-arm-kernel, linux-iio
Hi Angelo,
On 13/5/26 19:14, Angelo Dureghello wrote:
> From: Angelo Dureghello <adureghello@baylibre.com>
>
> Later in this patchset, the mcf54415 DAC driver is added.
> Considering some other different ColdFire cpu DACs exists, the DAC driver
> is named as "mcf54415_dac", related to the mcf5441x family SoCs with
> DACs (mcf54415/6/7/8).
>
> So updating DAC clock names to bind with proper driver name.
I am not sure I like naming the clocks here with a prefix for the
specific SoC part number this is in. It might be unlikely now, but
what if another ColdFire family SoC member uses this same hardware block?
That is very common amongst other hardware blocks within the ColdFire
family. Can we come up with a name more specific to just this type
of DAC hardware block?
Regards
Greg
> Signed-off-by: Angelo Dureghello <adureghello@baylibre.com>
> ---
> arch/m68k/coldfire/m5441x.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/m68k/coldfire/m5441x.c b/arch/m68k/coldfire/m5441x.c
> index 5b5e09ecf487..b724d7fc1a08 100644
> --- a/arch/m68k/coldfire/m5441x.c
> +++ b/arch/m68k/coldfire/m5441x.c
> @@ -43,8 +43,8 @@ DEFINE_CLK(0, "mcfpit.2", 34, MCF_BUSCLK);
> DEFINE_CLK(0, "mcfpit.3", 35, MCF_BUSCLK);
> DEFINE_CLK(0, "mcfeport.0", 36, MCF_CLK);
> DEFINE_CLK(0, "mcfadc.0", 37, MCF_CLK);
> -DEFINE_CLK(0, "mcfdac.0", 38, MCF_CLK);
> -DEFINE_CLK(0, "mcfdac.1", 39, MCF_CLK);
> +DEFINE_CLK(0, "mcf54415_dac.0", 38, MCF_CLK);
> +DEFINE_CLK(0, "mcf54415_dac.1", 39, MCF_CLK);
> DEFINE_CLK(0, "mcfrtc.0", 42, MCF_CLK);
> DEFINE_CLK(0, "mcfsim.0", 43, MCF_CLK);
> DEFINE_CLK(0, "mcfusb-otg.0", 44, MCF_CLK);
> @@ -106,8 +106,8 @@ static struct clk_lookup m5411x_clk_lookup[] = {
> CLKDEV_INIT("mcfpit.3", NULL, &__clk_0_35),
> CLKDEV_INIT("mcfeport.0", NULL, &__clk_0_36),
> CLKDEV_INIT("mcfadc.0", NULL, &__clk_0_37),
> - CLKDEV_INIT("mcfdac.0", NULL, &__clk_0_38),
> - CLKDEV_INIT("mcfdac.1", NULL, &__clk_0_39),
> + CLKDEV_INIT("mcf54415_dac.0", NULL, &__clk_0_38),
> + CLKDEV_INIT("mcf54415_dac.1", NULL, &__clk_0_39),
> CLKDEV_INIT("mcfrtc.0", NULL, &__clk_0_42),
> CLKDEV_INIT("mcfsim.0", NULL, &__clk_0_43),
> CLKDEV_INIT("mcfusb-otg.0", NULL, &__clk_0_44),
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v2 03/11] m68k: mcf5441x: setup DAC clock name as per driver name
2026-05-13 9:14 [PATCH v2 00/11] add mcf54415 DAC driver Angelo Dureghello
@ 2026-05-13 9:14 ` Angelo Dureghello
2026-05-14 1:27 ` Greg Ungerer
0 siblings, 1 reply; 8+ messages in thread
From: Angelo Dureghello @ 2026-05-13 9:14 UTC (permalink / raw)
To: Greg Ungerer, Geert Uytterhoeven, Steven King, Arnd Bergmann,
Maxime Coquelin, Alexandre Torgue, Jonathan Cameron,
David Lechner, Nuno Sá,
Andy Shevchenko
Cc: Greg Ungerer, linux-m68k, linux-kernel, linux-stm32,
linux-arm-kernel, linux-iio, Angelo Dureghello
From: Angelo Dureghello <adureghello@baylibre.com>
Later in this patchset, the mcf54415 DAC driver is added.
Considering some other different ColdFire cpu DACs exists, the DAC driver
is named as "mcf54415_dac", related to the mcf5441x family SoCs with
DACs (mcf54415/6/7/8).
So updating DAC clock names to bind with proper driver name.
Signed-off-by: Angelo Dureghello <adureghello@baylibre.com>
---
arch/m68k/coldfire/m5441x.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/m68k/coldfire/m5441x.c b/arch/m68k/coldfire/m5441x.c
index 5b5e09ecf487..b724d7fc1a08 100644
--- a/arch/m68k/coldfire/m5441x.c
+++ b/arch/m68k/coldfire/m5441x.c
@@ -43,8 +43,8 @@ DEFINE_CLK(0, "mcfpit.2", 34, MCF_BUSCLK);
DEFINE_CLK(0, "mcfpit.3", 35, MCF_BUSCLK);
DEFINE_CLK(0, "mcfeport.0", 36, MCF_CLK);
DEFINE_CLK(0, "mcfadc.0", 37, MCF_CLK);
-DEFINE_CLK(0, "mcfdac.0", 38, MCF_CLK);
-DEFINE_CLK(0, "mcfdac.1", 39, MCF_CLK);
+DEFINE_CLK(0, "mcf54415_dac.0", 38, MCF_CLK);
+DEFINE_CLK(0, "mcf54415_dac.1", 39, MCF_CLK);
DEFINE_CLK(0, "mcfrtc.0", 42, MCF_CLK);
DEFINE_CLK(0, "mcfsim.0", 43, MCF_CLK);
DEFINE_CLK(0, "mcfusb-otg.0", 44, MCF_CLK);
@@ -106,8 +106,8 @@ static struct clk_lookup m5411x_clk_lookup[] = {
CLKDEV_INIT("mcfpit.3", NULL, &__clk_0_35),
CLKDEV_INIT("mcfeport.0", NULL, &__clk_0_36),
CLKDEV_INIT("mcfadc.0", NULL, &__clk_0_37),
- CLKDEV_INIT("mcfdac.0", NULL, &__clk_0_38),
- CLKDEV_INIT("mcfdac.1", NULL, &__clk_0_39),
+ CLKDEV_INIT("mcf54415_dac.0", NULL, &__clk_0_38),
+ CLKDEV_INIT("mcf54415_dac.1", NULL, &__clk_0_39),
CLKDEV_INIT("mcfrtc.0", NULL, &__clk_0_42),
CLKDEV_INIT("mcfsim.0", NULL, &__clk_0_43),
CLKDEV_INIT("mcfusb-otg.0", NULL, &__clk_0_44),
--
2.54.0
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2026-05-17 17:22 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-05-17 9:11 [PATCH v2 03/11] m68k: mcf5441x: setup DAC clock name as per driver name Angelo Dureghello
2026-05-17 11:43 ` Jonathan Cameron
2026-05-17 11:45 ` Geert Uytterhoeven
2026-05-17 17:22 ` Angelo Dureghello
-- strict thread matches above, loose matches on Subject: below --
2026-05-13 9:14 [PATCH v2 00/11] add mcf54415 DAC driver Angelo Dureghello
2026-05-13 9:14 ` [PATCH v2 03/11] m68k: mcf5441x: setup DAC clock name as per driver name Angelo Dureghello
2026-05-14 1:27 ` Greg Ungerer
2026-05-14 7:05 ` Angelo Dureghello
2026-05-14 12:54 ` Greg Ungerer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®