* [PATCH] nvmem: nintendo-otp: Use of_device_get_match_data()
@ 2026-05-18 4:19 Rosen Penev
2026-05-19 14:42 ` Srinivas Kandagatla
0 siblings, 1 reply; 2+ messages in thread
From: Rosen Penev @ 2026-05-18 4:19 UTC (permalink / raw)
To: linux-kernel; +Cc: Srinivas Kandagatla
Use of_device_get_match_data() to retrieve the devtype data instead of open-coding the OF match lookup and dereferencing match->data.
This also replaces the deprecated of_device.h include with of.h.
Assisted-by: Codex:GPT-5.5
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
drivers/nvmem/nintendo-otp.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/nvmem/nintendo-otp.c b/drivers/nvmem/nintendo-otp.c
index 355e7f1fc6d5..e45a8a3a9774 100644
--- a/drivers/nvmem/nintendo-otp.c
+++ b/drivers/nvmem/nintendo-otp.c
@@ -17,7 +17,7 @@
#include <linux/module.h>
#include <linux/mod_devicetable.h>
#include <linux/nvmem-provider.h>
-#include <linux/of_device.h>
+#include <linux/of.h>
#include <linux/platform_device.h>
#define HW_OTPCMD 0
@@ -74,8 +74,7 @@ MODULE_DEVICE_TABLE(of, nintendo_otp_of_table);
static int nintendo_otp_probe(struct platform_device *pdev)
{
struct device *dev = &pdev->dev;
- const struct of_device_id *of_id =
- of_match_device(nintendo_otp_of_table, dev);
+ const struct nintendo_otp_devtype_data *data;
struct nvmem_device *nvmem;
struct nintendo_otp_priv *priv;
@@ -95,8 +94,8 @@ static int nintendo_otp_probe(struct platform_device *pdev)
if (IS_ERR(priv->regs))
return PTR_ERR(priv->regs);
- if (of_id->data) {
- const struct nintendo_otp_devtype_data *data = of_id->data;
+ data = of_device_get_match_data(dev);
+ if (data) {
config.name = data->name;
config.size = data->num_banks * BANK_SIZE;
}
--
2.54.0
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] nvmem: nintendo-otp: Use of_device_get_match_data()
2026-05-18 4:19 [PATCH] nvmem: nintendo-otp: Use of_device_get_match_data() Rosen Penev
@ 2026-05-19 14:42 ` Srinivas Kandagatla
0 siblings, 0 replies; 2+ messages in thread
From: Srinivas Kandagatla @ 2026-05-19 14:42 UTC (permalink / raw)
To: linux-kernel, Rosen Penev
On Sun, 17 May 2026 21:19:27 -0700, Rosen Penev wrote:
> Use of_device_get_match_data() to retrieve the devtype data instead of open-coding the OF match lookup and dereferencing match->data.
>
> This also replaces the deprecated of_device.h include with of.h.
>
>
Applied, thanks!
[1/1] nvmem: nintendo-otp: Use of_device_get_match_data()
commit: f6f37ba5ed4561e94d301fadc16437922aca2766
Best regards,
--
Srinivas Kandagatla <srini@kernel.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-05-19 14:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-05-18 4:19 [PATCH] nvmem: nintendo-otp: Use of_device_get_match_data() Rosen Penev
2026-05-19 14:42 ` Srinivas Kandagatla
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®