From: Andrew Morton <akpm@linux-foundation.org>
To: liuqiangneo@163.com
Cc: apopple@nvidia.com, jgg@ziepe.ca, leon@kernel.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Qiang Liu <liuqiang@kylinos.cn>
Subject: Re: [PATCH v2] lib/test_hmm: Check alloc_page_vma() return value
Date: Mon, 18 May 2026 14:33:14 -0700 [thread overview]
Message-ID: <20260518143314.dfd290f5a2b553a8e11cb2a5@linux-foundation.org> (raw)
In-Reply-To: <20260518031903.63455-1-liuqiangneo@163.com>
On Mon, 18 May 2026 11:19:03 +0800 liuqiangneo@163.com wrote:
> Return VM_FAULT_OOM if page allocation fails, which
> avoids a NULL pointer dereference when calling lock_page().
Patch looks good to me, but AI review is saying that two of
the calling functions are junk, and should be taught to handle
callee errors:
https://sashiko.dev/#/patchset/20260518031903.63455-1-liuqiangneo@163.com
next prev parent reply other threads:[~2026-05-18 21:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-18 3:19 liuqiangneo
2026-05-18 21:33 ` Andrew Morton [this message]
2026-05-18 23:39 ` Alistair Popple
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260518143314.dfd290f5a2b553a8e11cb2a5@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=apopple@nvidia.com \
--cc=jgg@ziepe.ca \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liuqiang@kylinos.cn \
--cc=liuqiangneo@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®