* [PATCH] crypto: inside-secure/eip93 - Add check for devm_request_threaded_irq
@ 2026-05-18 21:24 Aleksander Jan Bajkowski
2026-05-29 6:00 ` Herbert Xu
0 siblings, 1 reply; 2+ messages in thread
From: Aleksander Jan Bajkowski @ 2026-05-18 21:24 UTC (permalink / raw)
To: ansuelsmth, atenart, herbert, davem, linux-crypto, linux-kernel
Cc: Aleksander Jan Bajkowski
As the potential failure of the devm_request_threaded_irq(),
it should be better to check the return value and return
error if fails.
Fixes: 9739f5f93b78 ("crypto: eip93 - Add Inside Secure SafeXcel EIP-93 crypto engine support")
Signed-off-by: Aleksander Jan Bajkowski <olek2@wp.pl>
---
drivers/crypto/inside-secure/eip93/eip93-main.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/crypto/inside-secure/eip93/eip93-main.c b/drivers/crypto/inside-secure/eip93/eip93-main.c
index 7dccfdeb7b11..276839e1a515 100644
--- a/drivers/crypto/inside-secure/eip93/eip93-main.c
+++ b/drivers/crypto/inside-secure/eip93/eip93-main.c
@@ -433,6 +433,8 @@ static int eip93_crypto_probe(struct platform_device *pdev)
ret = devm_request_threaded_irq(eip93->dev, eip93->irq, eip93_irq_handler,
NULL, IRQF_ONESHOT,
dev_name(eip93->dev), eip93);
+ if (ret)
+ return ret;
eip93->ring = devm_kcalloc(eip93->dev, 1, sizeof(*eip93->ring), GFP_KERNEL);
if (!eip93->ring)
--
2.53.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] crypto: inside-secure/eip93 - Add check for devm_request_threaded_irq
2026-05-18 21:24 [PATCH] crypto: inside-secure/eip93 - Add check for devm_request_threaded_irq Aleksander Jan Bajkowski
@ 2026-05-29 6:00 ` Herbert Xu
0 siblings, 0 replies; 2+ messages in thread
From: Herbert Xu @ 2026-05-29 6:00 UTC (permalink / raw)
To: Aleksander Jan Bajkowski
Cc: ansuelsmth, atenart, davem, linux-crypto, linux-kernel
On Mon, May 18, 2026 at 11:24:59PM +0200, Aleksander Jan Bajkowski wrote:
> As the potential failure of the devm_request_threaded_irq(),
> it should be better to check the return value and return
> error if fails.
>
> Fixes: 9739f5f93b78 ("crypto: eip93 - Add Inside Secure SafeXcel EIP-93 crypto engine support")
> Signed-off-by: Aleksander Jan Bajkowski <olek2@wp.pl>
> ---
> drivers/crypto/inside-secure/eip93/eip93-main.c | 2 ++
> 1 file changed, 2 insertions(+)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-05-29 6:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-05-18 21:24 [PATCH] crypto: inside-secure/eip93 - Add check for devm_request_threaded_irq Aleksander Jan Bajkowski
2026-05-29 6:00 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®