[PATCH] platform/x86: bitland-mifs-wmi: add CONFIG_LEDS_CLASS dependency

[PATCH] platform/x86: bitland-mifs-wmi: add CONFIG_LEDS_CLASS dependency

[Arnd Bergmann]

From: Arnd Bergmann <arnd@arndb.de>

The newly added driver requires the LED classdev support
and causes a link failure when that is disabled:

x86_64-linux-ld: vmlinux.o: in function `bitland_mifs_wmi_probe':
bitland-mifs-wmi.c:(.text+0xede02a): undefined reference to `devm_led_classdev_register_ext'

Fixes: dc1ec4fa86b2 ("platform/x86: bitland-mifs-wmi: Add new Bitland MIFS WMI driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
----
There is currently a mix of 'depends on LEDS_CLASS'
and 'select LEDS_CLASS' in the platform drivers. This
is something that should be fixed at some point, as it
risks circular dependencies.

The majority use 'select', but I went for 'depends on'
here since the symbol is user visible.
---
 drivers/platform/x86/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index 0e9f4403a4f4..d7beda4239ab 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -118,6 +118,7 @@ config BITLAND_MIFS_WMI
 	depends on ACPI_WMI
 	depends on HWMON
 	depends on INPUT
+	depends on LEDS_CLASS
 	depends on POWER_SUPPLY
 	select ACPI_PLATFORM_PROFILE
 	select INPUT_SPARSEKMAP
-- 
2.39.5

Re: [PATCH] platform/x86: bitland-mifs-wmi: add CONFIG_LEDS_CLASS dependency

[Ilpo Järvinen]

On Tue, 19 May 2026, Arnd Bergmann wrote:

> From: Arnd Bergmann <arnd@arndb.de>
> 
> The newly added driver requires the LED classdev support
> and causes a link failure when that is disabled:
> 
> x86_64-linux-ld: vmlinux.o: in function `bitland_mifs_wmi_probe':
> bitland-mifs-wmi.c:(.text+0xede02a): undefined reference to `devm_led_classdev_register_ext'

Hpmf, I always try to check these for new drivers as they're so common 
mistakes but I don't know why I didn't notice this one.

Applied this fix to review-ilpo-fixes. Thanks!

> Fixes: dc1ec4fa86b2 ("platform/x86: bitland-mifs-wmi: Add new Bitland MIFS WMI driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ----
> There is currently a mix of 'depends on LEDS_CLASS'
> and 'select LEDS_CLASS' in the platform drivers. This
> is something that should be fixed at some point, as it
> risks circular dependencies.
>
> The majority use 'select', but I went for 'depends on'
> here since the symbol is user visible.

I've noticed this earlier but I didn't know which one is preferred.

Checking it again, it seems that anything under drivers/leds is using 
'depends on' so I suppose that would be the preferred alternative.

> ---
>  drivers/platform/x86/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> index 0e9f4403a4f4..d7beda4239ab 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -118,6 +118,7 @@ config BITLAND_MIFS_WMI
>  	depends on ACPI_WMI
>  	depends on HWMON
>  	depends on INPUT
> +	depends on LEDS_CLASS
>  	depends on POWER_SUPPLY
>  	select ACPI_PLATFORM_PROFILE
>  	select INPUT_SPARSEKMAP
> 

-- 
 i.