mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH 0/2] Subject: [PATCH v5 0/2] arm64: Add LECARC ACPI IDs for DesignWare GPIO, SPI
@ 2026-05-21  2:34 Thomas Lin
  2026-05-21  2:34 ` [PATCH 1/2] gpio: dwapb: Add ACPI ID LECA0001 for LECARC SoCs Thomas Lin
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Thomas Lin @ 2026-05-21  2:34 UTC (permalink / raw)
  To: Hoan Tran, Linus Walleij, Bartosz Golaszewski, Rafael J. Wysocki,
	Len Brown, Mark Brown
  Cc: linux-gpio, linux-kernel, linux-acpi, linux-spi, Thomas Lin,
	braden_zhang, Andy Shevchenko

This patch series adds ACPI identification for LECARC SoCs that
integrate Synopsys DesignWare peripherals.

LECARC platforms use the following ACPI HIDs:

GPIO: LECA0001 (V1 register offsets)

SPI: LECA0002 (requires custom init function)

Patch 1: GPIO – add LECA0001 to dwapb_gpio ACPI match table.
Patch 2: SPI – add LECA0002 and dw_spi_lecarc_init() to spi-dw-mmio,

Changes since v1:

- Revised subject lines to match subsystem style guidelines
- No functional changes
- All the comments from reviews has been fixed

Changes since v2:
- Wrap long commit description lines to 72 columns
- Fix code indentation in spi-dw-mmio.c: use tabs + spaces for alignment
- No functional changes

Changes since v3:
- Start a new thread for each revision

Changes since v4:
- patch to strip away conflicts

Thomas Lin (2):
  gpio: dwapb: Add ACPI ID LECA0001 for LECARC SoCs
  spi: dw-mmio: Add ACPI ID LECA0002 for LECARC SoCs

Signed-off-by: Thomas Lin <thomas_lin@lecomputing.com>
---
Thomas Lin (2):
      gpio: dwapb: Add ACPI ID LECA0001 for LECARC SoCs
      spi: dw-mmio: Add ACPI ID LECA0002 for LECARC SoCs

 drivers/acpi/acpi_apd.c   | 7 +++++++
 drivers/gpio/gpio-dwapb.c | 1 +
 drivers/spi/spi-dw-mmio.c | 7 ++++---
 3 files changed, 12 insertions(+), 3 deletions(-)
---
base-commit: 8bc67e4db64aa72732c474b44ea8622062c903f0
change-id: 20260521-lecarc-acpi-ids-a6967e1ec5b5

Best regards,
--  
Thomas Lin <thomas_lin@lecomputing.com>


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 1/2] gpio: dwapb: Add ACPI ID LECA0001 for LECARC SoCs
  2026-05-21  2:34 [PATCH 0/2] Subject: [PATCH v5 0/2] arm64: Add LECARC ACPI IDs for DesignWare GPIO, SPI Thomas Lin
@ 2026-05-21  2:34 ` Thomas Lin
  2026-05-21  2:34 ` [PATCH 2/2] spi: dw-mmio: Add ACPI ID LECA0002 " Thomas Lin
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: Thomas Lin @ 2026-05-21  2:34 UTC (permalink / raw)
  To: Hoan Tran, Linus Walleij, Bartosz Golaszewski, Rafael J. Wysocki,
	Len Brown, Mark Brown
  Cc: linux-gpio, linux-kernel, linux-acpi, linux-spi, Thomas Lin,
	braden_zhang, Andy Shevchenko

Add ACPI ID "LECA0001" for LECARC SoCs that use the DesignWare
GPIO controller with V1 register offsets.

Signed-off-by: Thomas Lin <thomas_lin@lecomputing.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Bartosz Golaszewski <brgl@kernel.org>
---
 drivers/gpio/gpio-dwapb.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpio/gpio-dwapb.c b/drivers/gpio/gpio-dwapb.c
index 15cebc8b5d66..c1f3d83a67c1 100644
--- a/drivers/gpio/gpio-dwapb.c
+++ b/drivers/gpio/gpio-dwapb.c
@@ -694,6 +694,7 @@ static const struct acpi_device_id dwapb_acpi_match[] = {
 	{"APMC0D07", GPIO_REG_OFFSET_V1},
 	{"APMC0D81", GPIO_REG_OFFSET_V2},
 	{"FUJI200A", GPIO_REG_OFFSET_V1},
+	{"LECA0001", GPIO_REG_OFFSET_V1},
 	{ }
 };
 MODULE_DEVICE_TABLE(acpi, dwapb_acpi_match);

-- 
2.43.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 2/2] spi: dw-mmio: Add ACPI ID LECA0002 for LECARC SoCs
  2026-05-21  2:34 [PATCH 0/2] Subject: [PATCH v5 0/2] arm64: Add LECARC ACPI IDs for DesignWare GPIO, SPI Thomas Lin
  2026-05-21  2:34 ` [PATCH 1/2] gpio: dwapb: Add ACPI ID LECA0001 for LECARC SoCs Thomas Lin
@ 2026-05-21  2:34 ` Thomas Lin
  2026-05-21  8:49 ` (subset) [PATCH 0/2] Subject: [PATCH v5 0/2] arm64: Add LECARC ACPI IDs for DesignWare GPIO, SPI Bartosz Golaszewski
  2026-05-21 10:08 ` Mark Brown
  3 siblings, 0 replies; 5+ messages in thread
From: Thomas Lin @ 2026-05-21  2:34 UTC (permalink / raw)
  To: Hoan Tran, Linus Walleij, Bartosz Golaszewski, Rafael J. Wysocki,
	Len Brown, Mark Brown
  Cc: linux-gpio, linux-kernel, linux-acpi, linux-spi, Thomas Lin,
	braden_zhang, Andy Shevchenko

This ID requires a custom initialization function
dw_spi_hssi_no_dma_init() that sets dws->dws.ip to DW_HSSI_ID.

Signed-off-by: Thomas Lin <thomas_lin@lecomputing.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/acpi/acpi_apd.c   | 7 +++++++
 drivers/spi/spi-dw-mmio.c | 7 ++++---
 2 files changed, 11 insertions(+), 3 deletions(-)

diff --git a/drivers/acpi/acpi_apd.c b/drivers/acpi/acpi_apd.c
index bed0791c17fc..4d5a51d30adc 100644
--- a/drivers/acpi/acpi_apd.c
+++ b/drivers/acpi/acpi_apd.c
@@ -181,6 +181,12 @@ static const struct apd_device_desc hip08_spi_desc = {
 	.setup = acpi_apd_setup,
 	.fixed_clk_rate = 250000000,
 };
+
+static const struct apd_device_desc leca_spi_desc = {
+	.setup = acpi_apd_setup,
+	.fixed_clk_rate = 400000000,
+};
+
 #endif /* CONFIG_ARM64 */
 
 #endif
@@ -251,6 +257,7 @@ static const struct acpi_device_id acpi_apd_device_ids[] = {
 	{ "HISI02A2", APD_ADDR(hip08_i2c_desc) },
 	{ "HISI02A3", APD_ADDR(hip08_lite_i2c_desc) },
 	{ "HISI0173", APD_ADDR(hip08_spi_desc) },
+	{ "LECA0002", APD_ADDR(leca_spi_desc) },
 	{ "NXP0001", APD_ADDR(nxp_i2c_desc) },
 #endif
 	{ }
diff --git a/drivers/spi/spi-dw-mmio.c b/drivers/spi/spi-dw-mmio.c
index 1bfdf24c3227..4fc864d38cff 100644
--- a/drivers/spi/spi-dw-mmio.c
+++ b/drivers/spi/spi-dw-mmio.c
@@ -226,8 +226,8 @@ static int dw_spi_hssi_init(struct platform_device *pdev,
 	return 0;
 }
 
-static int dw_spi_intel_init(struct platform_device *pdev,
-			     struct dw_spi_mmio *dwsmmio)
+static int dw_spi_hssi_no_dma_init(struct platform_device *pdev,
+				   struct dw_spi_mmio *dwsmmio)
 {
 	dwsmmio->dws.ip = DW_HSSI_ID;
 
@@ -438,7 +438,7 @@ static const struct of_device_id dw_spi_mmio_of_match[] = {
 	{ .compatible = "amazon,alpine-dw-apb-ssi", .data = dw_spi_alpine_init},
 	{ .compatible = "renesas,rzn1-spi", .data = dw_spi_pssi_init},
 	{ .compatible = "snps,dwc-ssi-1.01a", .data = dw_spi_hssi_init},
-	{ .compatible = "intel,keembay-ssi", .data = dw_spi_intel_init},
+	{ .compatible = "intel,keembay-ssi", .data = dw_spi_hssi_no_dma_init},
 	{
 		.compatible = "intel,mountevans-imc-ssi",
 		.data = dw_spi_mountevans_imc_init,
@@ -453,6 +453,7 @@ MODULE_DEVICE_TABLE(of, dw_spi_mmio_of_match);
 #ifdef CONFIG_ACPI
 static const struct acpi_device_id dw_spi_mmio_acpi_match[] = {
 	{"HISI0173", (kernel_ulong_t)dw_spi_pssi_init},
+	{"LECA0002", (kernel_ulong_t)dw_spi_hssi_no_dma_init},
 	{},
 };
 MODULE_DEVICE_TABLE(acpi, dw_spi_mmio_acpi_match);

-- 
2.43.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: (subset) [PATCH 0/2] Subject: [PATCH v5 0/2] arm64: Add LECARC ACPI IDs for DesignWare GPIO, SPI
  2026-05-21  2:34 [PATCH 0/2] Subject: [PATCH v5 0/2] arm64: Add LECARC ACPI IDs for DesignWare GPIO, SPI Thomas Lin
  2026-05-21  2:34 ` [PATCH 1/2] gpio: dwapb: Add ACPI ID LECA0001 for LECARC SoCs Thomas Lin
  2026-05-21  2:34 ` [PATCH 2/2] spi: dw-mmio: Add ACPI ID LECA0002 " Thomas Lin
@ 2026-05-21  8:49 ` Bartosz Golaszewski
  2026-05-21 10:08 ` Mark Brown
  3 siblings, 0 replies; 5+ messages in thread
From: Bartosz Golaszewski @ 2026-05-21  8:49 UTC (permalink / raw)
  To: Hoan Tran, Linus Walleij, Bartosz Golaszewski, Rafael J. Wysocki,
	Len Brown, Mark Brown, Thomas Lin
  Cc: Bartosz Golaszewski, linux-gpio, linux-kernel, linux-acpi,
	linux-spi, braden_zhang, Andy Shevchenko


On Thu, 21 May 2026 10:34:48 +0800, Thomas Lin wrote:
> This patch series adds ACPI identification for LECARC SoCs that
> integrate Synopsys DesignWare peripherals.
> 
> LECARC platforms use the following ACPI HIDs:
> 
> GPIO: LECA0001 (V1 register offsets)
> 
> [...]

Applied, thanks!

[1/2] gpio: dwapb: Add ACPI ID LECA0001 for LECARC SoCs
      https://git.kernel.org/brgl/c/d01bf517cbbd5a4b0c16ba2d5107bda0e361b00c

Best regards,
-- 
Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: (subset) [PATCH 0/2] Subject: [PATCH v5 0/2] arm64: Add LECARC ACPI IDs for DesignWare GPIO, SPI
  2026-05-21  2:34 [PATCH 0/2] Subject: [PATCH v5 0/2] arm64: Add LECARC ACPI IDs for DesignWare GPIO, SPI Thomas Lin
                   ` (2 preceding siblings ...)
  2026-05-21  8:49 ` (subset) [PATCH 0/2] Subject: [PATCH v5 0/2] arm64: Add LECARC ACPI IDs for DesignWare GPIO, SPI Bartosz Golaszewski
@ 2026-05-21 10:08 ` Mark Brown
  3 siblings, 0 replies; 5+ messages in thread
From: Mark Brown @ 2026-05-21 10:08 UTC (permalink / raw)
  To: Hoan Tran, Linus Walleij, Bartosz Golaszewski, Rafael J. Wysocki,
	Len Brown, Thomas Lin
  Cc: linux-gpio, linux-kernel, linux-acpi, linux-spi, braden_zhang,
	Andy Shevchenko

On Thu, 21 May 2026 10:34:48 +0800, Thomas Lin wrote:
> Subject: [PATCH v5 0/2] arm64: Add LECARC ACPI IDs for DesignWare GPIO, SPI
> 
> This patch series adds ACPI identification for LECARC SoCs that
> integrate Synopsys DesignWare peripherals.
> 
> LECARC platforms use the following ACPI HIDs:
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-7.2

Thanks!

[2/2] spi: dw-mmio: Add ACPI ID LECA0002 for LECARC SoCs
      https://git.kernel.org/broonie/spi/c/019947c49585

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2026-05-22 10:23 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-05-21  2:34 [PATCH 0/2] Subject: [PATCH v5 0/2] arm64: Add LECARC ACPI IDs for DesignWare GPIO, SPI Thomas Lin
2026-05-21  2:34 ` [PATCH 1/2] gpio: dwapb: Add ACPI ID LECA0001 for LECARC SoCs Thomas Lin
2026-05-21  2:34 ` [PATCH 2/2] spi: dw-mmio: Add ACPI ID LECA0002 " Thomas Lin
2026-05-21  8:49 ` (subset) [PATCH 0/2] Subject: [PATCH v5 0/2] arm64: Add LECARC ACPI IDs for DesignWare GPIO, SPI Bartosz Golaszewski
2026-05-21 10:08 ` Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®