From: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
To: Srinivas Kandagatla <srini@kernel.org>,
Bartosz Golaszewski <brgl@kernel.org>,
Johan Hovold <johan@kernel.org>,
Loic Poulain <loic.poulain@oss.qualcomm.com>
Cc: linux-kernel@vger.kernel.org, brgl@kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
Subject: [PATCH v4 04/10] nvmem: check the return value of gpiod_set_value_cansleep()
Date: Thu, 21 May 2026 16:25:37 +0200 [thread overview]
Message-ID: <20260521-nvmem-unbind-v4-4-7fa136759491@oss.qualcomm.com> (raw)
In-Reply-To: <20260521-nvmem-unbind-v4-0-7fa136759491@oss.qualcomm.com>
GPIO setters now return integer values and can indicate failures in
lower abstraction layers. Check the return values of
gpiod_set_value_cansleep() calls in nvmem core.
Reviewed-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
---
drivers/nvmem/core.c | 16 +++++++++++-----
1 file changed, 11 insertions(+), 5 deletions(-)
diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c
index 06d7f3d819084579434370cd12c6b263abff196e..bf5dde6288cfa75cab4040c6b93e3376e87fc691 100644
--- a/drivers/nvmem/core.c
+++ b/drivers/nvmem/core.c
@@ -64,16 +64,22 @@ static int __nvmem_reg_read(struct nvmem_device *nvmem, unsigned int offset,
static int __nvmem_reg_write(struct nvmem_device *nvmem, unsigned int offset,
void *val, size_t bytes)
{
- int ret;
+ int ret, wr_ok;
if (!nvmem->reg_write)
return -EOPNOTSUPP;
- gpiod_set_value_cansleep(nvmem->wp_gpio, 0);
- ret = nvmem->reg_write(nvmem->priv, offset, val, bytes);
- gpiod_set_value_cansleep(nvmem->wp_gpio, 1);
+ ret = gpiod_set_value_cansleep(nvmem->wp_gpio, 0);
+ if (ret)
+ return ret;
- return ret;
+ wr_ok = nvmem->reg_write(nvmem->priv, offset, val, bytes);
+
+ ret = gpiod_set_value_cansleep(nvmem->wp_gpio, 1);
+ if (ret)
+ return ret;
+
+ return wr_ok;
}
static int nvmem_access_with_keepouts(struct nvmem_device *nvmem,
--
2.47.3
next prev parent reply other threads:[~2026-05-21 14:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-21 14:25 [PATCH v4 00/10] nvmem: rework nvmem core and allow unbinding with active consumers Bartosz Golaszewski
2026-05-21 14:25 ` [PATCH v4 01/10] nvmem: core: fix use-after-free bugs in error paths Bartosz Golaszewski
2026-05-21 14:25 ` [PATCH v4 02/10] nvmem: remove unused field from struct nvmem_device Bartosz Golaszewski
2026-05-21 14:25 ` [PATCH v4 03/10] nvmem: return -EOPNOTSUPP to in-kernel users on missing callbacks Bartosz Golaszewski
2026-05-21 14:25 ` Bartosz Golaszewski [this message]
2026-05-21 14:25 ` [PATCH v4 05/10] nvmem: simplify locking with guard() Bartosz Golaszewski
2026-05-21 14:25 ` [PATCH v4 06/10] nvmem: remove unneeded __nvmem_device_put() Bartosz Golaszewski
2026-05-21 14:25 ` [PATCH v4 07/10] nvmem: split out the reg_read/write() callbacks out of struct nvmem_device Bartosz Golaszewski
2026-05-21 14:25 ` [PATCH v4 08/10] nvmem: simplify nvmem_sysfs_remove_compat() Bartosz Golaszewski
2026-05-21 14:25 ` [PATCH v4 09/10] nvmem: remove duplicated reference counting Bartosz Golaszewski
2026-05-21 14:25 ` [PATCH v4 10/10] nvmem: protect nvmem_device::ops with SRCU Bartosz Golaszewski
2026-05-30 20:40 ` (subset) [PATCH v4 00/10] nvmem: rework nvmem core and allow unbinding with active consumers Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260521-nvmem-unbind-v4-4-7fa136759491@oss.qualcomm.com \
--to=bartosz.golaszewski@oss.qualcomm.com \
--cc=brgl@kernel.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loic.poulain@oss.qualcomm.com \
--cc=srini@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®