* [PATCH] soc: qcom: ice: Support IP version beyond v3
@ 2026-05-21 13:12 Manivannan Sadhasivam
2026-05-22 9:43 ` Konrad Dybcio
2026-07-07 3:21 ` Bjorn Andersson
0 siblings, 2 replies; 3+ messages in thread
From: Manivannan Sadhasivam @ 2026-05-21 13:12 UTC (permalink / raw)
To: andersson, konradybcio
Cc: linux-arm-msm, linux-kernel, mani, Manivannan Sadhasivam
From: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
This driver currently supports Inline Crypto Engine (ICE) IP version 3 and
4. But this driver fully supports v5 and should support upcoming versions
as well. So extend the version check to support versions 3 and beyond.
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
---
drivers/soc/qcom/ice.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/soc/qcom/ice.c b/drivers/soc/qcom/ice.c
index b203bc685cad..d3348b1fe85f 100644
--- a/drivers/soc/qcom/ice.c
+++ b/drivers/soc/qcom/ice.c
@@ -121,8 +121,8 @@ static bool qcom_ice_check_supported(struct qcom_ice *ice)
int minor = FIELD_GET(GENMASK(23, 16), regval);
int step = FIELD_GET(GENMASK(15, 0), regval);
- /* For now this driver only supports ICE version 3 and 4. */
- if (major != 3 && major != 4) {
+ /* Support ICE version 3 and above. */
+ if (major < 3) {
dev_warn(dev, "Unsupported ICE version: v%d.%d.%d\n",
major, minor, step);
return false;
--
2.43.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] soc: qcom: ice: Support IP version beyond v3
2026-05-21 13:12 [PATCH] soc: qcom: ice: Support IP version beyond v3 Manivannan Sadhasivam
@ 2026-05-22 9:43 ` Konrad Dybcio
2026-07-07 3:21 ` Bjorn Andersson
1 sibling, 0 replies; 3+ messages in thread
From: Konrad Dybcio @ 2026-05-22 9:43 UTC (permalink / raw)
To: Manivannan Sadhasivam, andersson, konradybcio
Cc: linux-arm-msm, linux-kernel, mani
On 5/21/26 3:12 PM, Manivannan Sadhasivam wrote:
> From: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
>
> This driver currently supports Inline Crypto Engine (ICE) IP version 3 and
> 4. But this driver fully supports v5 and should support upcoming versions
> as well. So extend the version check to support versions 3 and beyond.
>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] soc: qcom: ice: Support IP version beyond v3
2026-05-21 13:12 [PATCH] soc: qcom: ice: Support IP version beyond v3 Manivannan Sadhasivam
2026-05-22 9:43 ` Konrad Dybcio
@ 2026-07-07 3:21 ` Bjorn Andersson
1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Andersson @ 2026-07-07 3:21 UTC (permalink / raw)
To: konradybcio, Manivannan Sadhasivam; +Cc: linux-arm-msm, linux-kernel, mani
On Thu, 21 May 2026 13:12:29 +0000, Manivannan Sadhasivam wrote:
> This driver currently supports Inline Crypto Engine (ICE) IP version 3 and
> 4. But this driver fully supports v5 and should support upcoming versions
> as well. So extend the version check to support versions 3 and beyond.
>
>
Applied, thanks!
[1/1] soc: qcom: ice: Support IP version beyond v3
commit: c709c76f4cf1d8646362f5a00ce8da1bd8ed58d7
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-07-07 3:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-05-21 13:12 [PATCH] soc: qcom: ice: Support IP version beyond v3 Manivannan Sadhasivam
2026-05-22 9:43 ` Konrad Dybcio
2026-07-07 3:21 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox