[PATCH] fs: retire stale comment in fget_task_next()

[PATCH] fs: retire stale comment in fget_task_next()

[Mateusz Guzik]

The routine originally showed up in e9a53aeb5e0a838f ("file: Implement
task_lookup_next_fd_rcu"), afterwards it got renamed and started
entering RCU on its own in 8fd3395ec9051a52 ("get rid of
...lookup...fdget_rcu() family").

Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
---
 fs/file.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/fs/file.c b/fs/file.c
index e5c75b22e0c7..628ca07dc4b1 100644
--- a/fs/file.c
+++ b/fs/file.c
@@ -1133,7 +1133,6 @@ struct file *fget_task(struct task_struct *task, unsigned int fd)
 
 struct file *fget_task_next(struct task_struct *task, unsigned int *ret_fd)
 {
-	/* Must be called with rcu_read_lock held */
 	struct files_struct *files;
 	unsigned int fd = *ret_fd;
 	struct file *file = NULL;
-- 
2.48.1

Re: [PATCH] fs: retire stale comment in fget_task_next()

[Jan Kara]

On Fri 22-05-26 16:21:52, Mateusz Guzik wrote:
> The routine originally showed up in e9a53aeb5e0a838f ("file: Implement
> task_lookup_next_fd_rcu"), afterwards it got renamed and started
> entering RCU on its own in 8fd3395ec9051a52 ("get rid of
> ...lookup...fdget_rcu() family").
> 
> Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>

Right. Thanks for the fixup. Feel free to add:

Reviewed-by: Jan Kara <jack@suse.cz>

								Honza

> ---
>  fs/file.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/fs/file.c b/fs/file.c
> index e5c75b22e0c7..628ca07dc4b1 100644
> --- a/fs/file.c
> +++ b/fs/file.c
> @@ -1133,7 +1133,6 @@ struct file *fget_task(struct task_struct *task, unsigned int fd)
>  
>  struct file *fget_task_next(struct task_struct *task, unsigned int *ret_fd)
>  {
> -	/* Must be called with rcu_read_lock held */
>  	struct files_struct *files;
>  	unsigned int fd = *ret_fd;
>  	struct file *file = NULL;
> -- 
> 2.48.1
> 
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR

Re: [PATCH] fs: retire stale comment in fget_task_next()

[Christian Brauner]

On Fri, 22 May 2026 16:21:52 +0200, Mateusz Guzik wrote:
> The routine originally showed up in e9a53aeb5e0a838f ("file: Implement
> task_lookup_next_fd_rcu"), afterwards it got renamed and started
> entering RCU on its own in 8fd3395ec9051a52 ("get rid of
> ...lookup...fdget_rcu() family").

Applied to the vfs-7.2.misc branch of the vfs/vfs.git tree.
Patches in the vfs-7.2.misc branch should appear in linux-next soon.

Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.

It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.

Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs-7.2.misc

[1/1] fs: retire stale comment in fget_task_next()
      https://git.kernel.org/vfs/vfs/c/d24576fddf64