mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Michael Byczkowski <by@by-online.de>
Cc: Rodolfo Giometti <giometti@enneenne.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 2/3] pps: convert pps_device lock to raw_spinlock for PREEMPT_RT
Date: Fri, 22 May 2026 16:33:09 +0200	[thread overview]
Message-ID: <20260522143309.A6EIJ57S@linutronix.de> (raw)
In-Reply-To: <9A49DA13-F000-48C8-9856-12E6EACE0B0E@by-online.de>

On 2026-04-25 19:20:08 [+0200], Michael Byczkowski wrote:
> --- a/drivers/pps/kapi.c
> +++ b/drivers/pps/kapi.c
> @@ -167,7 +167,7 @@ void pps_event(struct pps_device *pps, struct pps_event_time *ts, int event,
> 
> timespec_to_pps_ktime(&ts_real, ts->ts_real);
> 
> - spin_lock_irqsave(&pps->lock, flags);
> + raw_spin_lock_irqsave(&pps->lock, flags);
> 
> /* Must call the echo function? */
> if ((pps->params.mode & (PPS_ECHOASSERT | PPS_ECHOCLEAR)))
> @@ -206,14 +206,18 @@ void pps_event(struct pps_device *pps, struct pps_event_time *ts, int event,
> 
> pps_kc_event(pps, ts, event);

This acquires a pps_kc_hardpps_lock which is spinlock_t in my tree.
There is also pps_gpio_echo() but this should be all non-blocking.

> 
> - /* Wake up if captured something */
> - if (captured) {
> + if (captured)
> pps->last_ev++;
> - wake_up_interruptible_all(&pps->queue);

Sebastian

  parent reply	other threads:[~2026-05-22 14:33 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-25 17:18 [PATCH v5 0/3] pps: improve PREEMPT_RT performance Michael Byczkowski
2026-04-25 17:19 ` [PATCH v5 1/3] pps: pps-gpio: split IRQ handler into hardirq and threaded parts Michael Byczkowski
2026-05-22 14:25   ` Sebastian Andrzej Siewior
2026-04-25 17:20 ` [PATCH v5 2/3] pps: convert pps_device lock to raw_spinlock for PREEMPT_RT Michael Byczkowski
2026-04-25 17:21   ` [PATCH v5 3/3] pps: convert pps_kc_hardpps_lock " Michael Byczkowski
2026-05-22 14:37     ` Sebastian Andrzej Siewior
2026-05-22 14:33   ` Sebastian Andrzej Siewior [this message]
2026-05-16 11:32 ` [PATCH v5 0/3] pps: improve PREEMPT_RT performance Michael Byczkowski
2026-05-19 16:19   ` Calvin Owens
2026-05-22 15:56     ` Michael Byczkowski
2026-05-23 17:57       ` Michael Byczkowski
2026-05-22 14:13   ` Sebastian Andrzej Siewior
2026-05-23 17:58     ` Michael Byczkowski
2026-05-26 18:34       ` Michael Byczkowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260522143309.A6EIJ57S@linutronix.de \
    --to=bigeasy@linutronix.de \
    --cc=akpm@linux-foundation.org \
    --cc=by@by-online.de \
    --cc=giometti@enneenne.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®