* [PATCH] vfio/pci: Fix sparse warning in vfio_pci_core_get_iomap()
@ 2026-05-22 12:42 Matt Evans
2026-05-22 22:39 ` Alex Williamson
0 siblings, 1 reply; 2+ messages in thread
From: Matt Evans @ 2026-05-22 12:42 UTC (permalink / raw)
To: Alex Williamson; +Cc: kvm, linux-kernel, kernel test robot
Use IOMEM_ERR_PTR() when returning a void __iomem * rather than
ERR_PTR(). This fixes a sparse warning, "different address spaces".
Fixes: 859dc0f6253b ("vfio/pci: Replace vfio_pci_core_setup_barmap() with vfio_pci_core_get_iomap()")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202605211601.U1OvmuqY-lkp@intel.com/
Signed-off-by: Matt Evans <mattev@meta.com>
---
include/linux/vfio_pci_core.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/vfio_pci_core.h b/include/linux/vfio_pci_core.h
index 7accd0eac457..4fa129fc5c64 100644
--- a/include/linux/vfio_pci_core.h
+++ b/include/linux/vfio_pci_core.h
@@ -244,10 +244,10 @@ static inline void __iomem __must_check *
vfio_pci_core_get_iomap(struct vfio_pci_core_device *vdev, unsigned int bar)
{
if (WARN_ON_ONCE(bar >= PCI_STD_NUM_BARS))
- return ERR_PTR(-EINVAL);
+ return IOMEM_ERR_PTR(-EINVAL);
if (WARN_ON_ONCE(!vdev->barmap[bar]))
- return ERR_PTR(-ENODEV);
+ return IOMEM_ERR_PTR(-ENODEV);
return vdev->barmap[bar];
}
--
2.47.3
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] vfio/pci: Fix sparse warning in vfio_pci_core_get_iomap()
2026-05-22 12:42 [PATCH] vfio/pci: Fix sparse warning in vfio_pci_core_get_iomap() Matt Evans
@ 2026-05-22 22:39 ` Alex Williamson
0 siblings, 0 replies; 2+ messages in thread
From: Alex Williamson @ 2026-05-22 22:39 UTC (permalink / raw)
To: Matt Evans; +Cc: kvm, linux-kernel, kernel test robot, alex
On Fri, 22 May 2026 05:42:11 -0700
Matt Evans <mattev@meta.com> wrote:
> Use IOMEM_ERR_PTR() when returning a void __iomem * rather than
> ERR_PTR(). This fixes a sparse warning, "different address spaces".
>
> Fixes: 859dc0f6253b ("vfio/pci: Replace vfio_pci_core_setup_barmap() with vfio_pci_core_get_iomap()")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202605211601.U1OvmuqY-lkp@intel.com/
> Signed-off-by: Matt Evans <mattev@meta.com>
> ---
> include/linux/vfio_pci_core.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/vfio_pci_core.h b/include/linux/vfio_pci_core.h
> index 7accd0eac457..4fa129fc5c64 100644
> --- a/include/linux/vfio_pci_core.h
> +++ b/include/linux/vfio_pci_core.h
> @@ -244,10 +244,10 @@ static inline void __iomem __must_check *
> vfio_pci_core_get_iomap(struct vfio_pci_core_device *vdev, unsigned int bar)
> {
> if (WARN_ON_ONCE(bar >= PCI_STD_NUM_BARS))
> - return ERR_PTR(-EINVAL);
> + return IOMEM_ERR_PTR(-EINVAL);
>
> if (WARN_ON_ONCE(!vdev->barmap[bar]))
> - return ERR_PTR(-ENODEV);
> + return IOMEM_ERR_PTR(-ENODEV);
>
> return vdev->barmap[bar];
> }
Applied to vfio next branch for v7.2. Thanks,
Alex
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-05-22 22:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-05-22 12:42 [PATCH] vfio/pci: Fix sparse warning in vfio_pci_core_get_iomap() Matt Evans
2026-05-22 22:39 ` Alex Williamson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome