From: Jun Yan <jerrysteve1101@gmail.com>
To: linusw@kernel.org, dmitry.baryshkov@oss.qualcomm.com,
Lee Jones <lee@kernel.org>, Pavel Machek <pavel@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Andrew Lunn <andrew@lunn.ch>,
Gregory Clement <gregory.clement@bootlin.com>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Bartosz Golaszewski <brgl@kernel.org>,
Vincent Knecht <vincent.knecht@mailoo.org>,
Grant Feng <von81@163.com>,
Andre Przywara <andre.przywara@arm.com>,
Viresh Kumar <viresh.kumar@linaro.org>,
Heiko Stuebner <heiko@sntech.de>,
Sudeep Holla <sudeep.holla@kernel.org>,
Florian Fainelli <f.fainelli@gmail.com>,
Robert Marko <robert.marko@sartura.hr>
Cc: Jun Yan <jerrysteve1101@gmail.com>,
Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
Pavel Machek <pavel@ucw.cz>,
Krzysztof Kozlowski <krzk@kernel.org>,
Wei Xu <xuwei5@hisilicon.com>,
Romain Perier <romain.perier@gmail.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org
Subject: [PATCH v2 4/6] arm64: dts: qcom: msm8916-alcatel-idol347: Fix sn3190 shutdown GPIO polarity
Date: Mon, 25 May 2026 22:46:10 +0800 [thread overview]
Message-ID: <20260525144629.498630-5-jerrysteve1101@gmail.com> (raw)
In-Reply-To: <20260525144629.498630-1-jerrysteve1101@gmail.com>
The sn3190 shutdown pin is active-low [1]. Correct the GPIO flags
from GPIO_ACTIVE_HIGH to GPIO_ACTIVE_LOW to match the hardware.
[1] https://lumissil.com/assets/pdf/core/IS31FL3190_DS.pdf
Fixes: 1c8cc183d070 ("arm64: dts: qcom: msm8916-alcatel-idol347: add LED indicator")
Signed-off-by: Jun Yan <jerrysteve1101@gmail.com>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/msm8916-alcatel-idol347.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/msm8916-alcatel-idol347.dts b/arch/arm64/boot/dts/qcom/msm8916-alcatel-idol347.dts
index 2de8b6f9531b..6d51d6efcbac 100644
--- a/arch/arm64/boot/dts/qcom/msm8916-alcatel-idol347.dts
+++ b/arch/arm64/boot/dts/qcom/msm8916-alcatel-idol347.dts
@@ -197,7 +197,7 @@ &blsp_i2c6 {
led-controller@68 {
compatible = "si-en,sn3190";
reg = <0x68>;
- shutdown-gpios = <&tlmm 89 GPIO_ACTIVE_HIGH>;
+ shutdown-gpios = <&tlmm 89 GPIO_ACTIVE_LOW>;
pinctrl-names = "default";
pinctrl-0 = <&led_enable_default &led_shutdown_default>;
#address-cells = <1>;
--
2.54.0
next prev parent reply other threads:[~2026-05-25 14:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-25 14:46 [PATCH v2 0/6] leds: is31fl319x: Fix shutdown GPIO and update DT bindings Jun Yan
2026-05-25 14:46 ` [PATCH v2 1/6] dt-bindings: leds: issi,is31fl319x: Update description for the shutdown-gpios property Jun Yan
2026-05-25 14:46 ` [PATCH v2 2/6] leds: is31fl319x: Fix shutdown GPIO initial state and remove redundant startup pulse Jun Yan
2026-06-01 8:20 ` Krzysztof Kozlowski
2026-06-08 22:03 ` Linus Walleij
2026-05-25 14:46 ` [PATCH v2 3/6] gpiolib: of: add quirk for IS31FL319X shutdown line Jun Yan
2026-05-26 8:40 ` Bartosz Golaszewski
2026-05-29 20:10 ` Linus Walleij
2026-05-25 14:46 ` Jun Yan [this message]
2026-05-25 14:46 ` [PATCH v2 5/6] ARM: dts: qcom: msm8974-oneplus-bacon: Fix sn3193 shutdown GPIO polarity Jun Yan
2026-05-25 14:46 ` [PATCH v2 6/6] arm64: dts: marvell: armada-7040-mochabin: Fix is31fl3199 " Jun Yan
2026-06-01 6:58 ` Gregory CLEMENT
2026-06-01 8:21 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260525144629.498630-5-jerrysteve1101@gmail.com \
--to=jerrysteve1101@gmail.com \
--cc=andersson@kernel.org \
--cc=andre.przywara@arm.com \
--cc=andrew@lunn.ch \
--cc=brgl@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=f.fainelli@gmail.com \
--cc=geert+renesas@glider.be \
--cc=gregory.clement@bootlin.com \
--cc=heiko@sntech.de \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=lee@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@kernel.org \
--cc=pavel@ucw.cz \
--cc=robert.marko@sartura.hr \
--cc=robh@kernel.org \
--cc=romain.perier@gmail.com \
--cc=sebastian.hesselbarth@gmail.com \
--cc=sudeep.holla@kernel.org \
--cc=vincent.knecht@mailoo.org \
--cc=viresh.kumar@linaro.org \
--cc=von81@163.com \
--cc=xuwei5@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®