From: Krzysztof Kozlowski <krzk@kernel.org>
To: Gregory CLEMENT <gregory.clement@bootlin.com>,
Jun Yan <jerrysteve1101@gmail.com>,
linusw@kernel.org, dmitry.baryshkov@oss.qualcomm.com,
Lee Jones <lee@kernel.org>, Pavel Machek <pavel@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Andrew Lunn <andrew@lunn.ch>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Bartosz Golaszewski <brgl@kernel.org>,
Vincent Knecht <vincent.knecht@mailoo.org>,
Grant Feng <von81@163.com>,
Andre Przywara <andre.przywara@arm.com>,
Baruch Siach <baruch@tkos.co.il>, Shawn Guo <shawnguo@kernel.org>,
Paul Barker <paul.barker@sancloud.com>,
Robert Marko <robert.marko@sartura.hr>
Cc: Pavel Machek <pavel@ucw.cz>, Wei Xu <xuwei5@hisilicon.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Patrice Chotard <patrice.chotard@foss.st.com>,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org
Subject: Re: [PATCH v2 6/6] arm64: dts: marvell: armada-7040-mochabin: Fix is31fl3199 shutdown GPIO polarity
Date: Mon, 1 Jun 2026 10:21:23 +0200 [thread overview]
Message-ID: <fb9f6959-f9d8-4e3c-a952-5338a375fe4b@kernel.org> (raw)
In-Reply-To: <8733z621cs.fsf@BLaptop.bootlin.com>
On 01/06/2026 08:58, Gregory CLEMENT wrote:
> Hello,
>
>> The is31fl3199 shutdown pin is active-low [1]. Correct the GPIO flags
>> from GPIO_ACTIVE_HIGH to GPIO_ACTIVE_LOW to match the hardware.
>>
>> [1] https://lumissil.com/assets/pdf/core/IS31FL3199_DS.pdf
>>
>> Fixes: 737929191283 ("arm64: dts: marvell: add Globalscale MOCHAbin")
>> Signed-off-by: Jun Yan <jerrysteve1101@gmail.com>
>
> What happens if this patch is merged before the driver LED patch? Will
> it break something?
>
What if this patch is merged by a different maintainer, not LED? What if
this patch is merged by the same LED maintainer (not allowed, but let's
discuss) but is not squashed into LED driver?
IOW, entire set like breaking users.
Best regards,
Krzysztof
prev parent reply other threads:[~2026-06-01 8:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-25 14:46 [PATCH v2 0/6] leds: is31fl319x: Fix shutdown GPIO and update DT bindings Jun Yan
2026-05-25 14:46 ` [PATCH v2 1/6] dt-bindings: leds: issi,is31fl319x: Update description for the shutdown-gpios property Jun Yan
2026-05-25 14:46 ` [PATCH v2 2/6] leds: is31fl319x: Fix shutdown GPIO initial state and remove redundant startup pulse Jun Yan
2026-06-01 8:20 ` Krzysztof Kozlowski
2026-06-08 22:03 ` Linus Walleij
2026-05-25 14:46 ` [PATCH v2 3/6] gpiolib: of: add quirk for IS31FL319X shutdown line Jun Yan
2026-05-26 8:40 ` Bartosz Golaszewski
2026-05-29 20:10 ` Linus Walleij
2026-05-25 14:46 ` [PATCH v2 4/6] arm64: dts: qcom: msm8916-alcatel-idol347: Fix sn3190 shutdown GPIO polarity Jun Yan
2026-05-25 14:46 ` [PATCH v2 5/6] ARM: dts: qcom: msm8974-oneplus-bacon: Fix sn3193 " Jun Yan
2026-05-25 14:46 ` [PATCH v2 6/6] arm64: dts: marvell: armada-7040-mochabin: Fix is31fl3199 " Jun Yan
2026-06-01 6:58 ` Gregory CLEMENT
2026-06-01 8:21 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb9f6959-f9d8-4e3c-a952-5338a375fe4b@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=andre.przywara@arm.com \
--cc=andrew@lunn.ch \
--cc=baruch@tkos.co.il \
--cc=brgl@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=geert+renesas@glider.be \
--cc=gregory.clement@bootlin.com \
--cc=jerrysteve1101@gmail.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=patrice.chotard@foss.st.com \
--cc=paul.barker@sancloud.com \
--cc=pavel@kernel.org \
--cc=pavel@ucw.cz \
--cc=robert.marko@sartura.hr \
--cc=robh@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=shawnguo@kernel.org \
--cc=vincent.knecht@mailoo.org \
--cc=von81@163.com \
--cc=xuwei5@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®