From: Balakrishnan Sambath <balakrishnan.s@microchip.com>
To: "Jacopo Mondi" <jacopo+renesas@jmondi.org>,
"Kieran Bingham" <kieran.bingham+renesas@ideasonboard.com>,
"Laurent Pinchart" <laurent.pinchart+renesas@ideasonboard.com>,
"Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Tim Harvey" <tharvey@gateworks.com>,
"Hans Verkuil" <hverkuil@kernel.org>
Cc: <linux-media@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Balakrishnan Sambath <balakrishnan.s@microchip.com>
Subject: [PATCH 08/12] media: adv7511: use string_choices helpers
Date: Wed, 27 May 2026 20:10:57 +0530 [thread overview]
Message-ID: <20260527-cleanup-string-choices-media-i2c-v1-8-e8f7d2284288@microchip.com> (raw)
In-Reply-To: <20260527-cleanup-string-choices-media-i2c-v1-0-e8f7d2284288@microchip.com>
Replace open-coded boolean-to-string ternaries with the standard
helpers from <linux/string_choices.h>.
No functional change.
Signed-off-by: Balakrishnan Sambath <balakrishnan.s@microchip.com>
---
drivers/media/i2c/adv7511-v4l2.c | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/media/i2c/adv7511-v4l2.c b/drivers/media/i2c/adv7511-v4l2.c
index 860cff50c..062ef8844 100644
--- a/drivers/media/i2c/adv7511-v4l2.c
+++ b/drivers/media/i2c/adv7511-v4l2.c
@@ -16,6 +16,7 @@
#include <linux/slab.h>
#include <linux/i2c.h>
#include <linux/delay.h>
+#include <linux/string_choices.h>
#include <linux/videodev2.h>
#include <linux/workqueue.h>
#include <linux/hdmi.h>
@@ -583,7 +584,7 @@ static int adv7511_log_status(struct v4l2_subdev *sd)
"9", "A", "B", "C", "D", "E", "F"
};
- v4l2_info(sd, "power %s\n", state->power_on ? "on" : "off");
+ v4l2_info(sd, "power %s\n", str_on_off(state->power_on));
v4l2_info(sd, "%s hotplug, %s Rx Sense, %s EDID (%d block(s))\n",
(adv7511_rd(sd, 0x42) & MASK_ADV7511_HPD_DETECT) ? "detected" : "no",
(adv7511_rd(sd, 0x42) & MASK_ADV7511_MSEN_DETECT) ? "detected" : "no",
@@ -592,8 +593,7 @@ static int adv7511_log_status(struct v4l2_subdev *sd)
v4l2_info(sd, "%s output %s\n",
(adv7511_rd(sd, 0xaf) & 0x02) ?
"HDMI" : "DVI-D",
- (adv7511_rd(sd, 0xa1) & 0x3c) ?
- "disabled" : "enabled");
+ str_disabled_enabled(adv7511_rd(sd, 0xa1) & 0x3c));
v4l2_info(sd, "state: %s, error: %s, detect count: %u, msk/irq: %02x/%02x\n",
states[adv7511_rd(sd, 0xc8) & 0xf],
errors[adv7511_rd(sd, 0xc8) >> 4], state->edid_detect_counter,
@@ -635,8 +635,7 @@ static int adv7511_log_status(struct v4l2_subdev *sd)
v4l2_info(sd, "i2c cec addr: 0x%x\n", state->i2c_cec_addr);
- v4l2_info(sd, "CEC: %s\n", state->cec_enabled_adap ?
- "enabled" : "disabled");
+ v4l2_info(sd, "CEC: %s\n", str_enabled_disabled(state->cec_enabled_adap));
if (state->cec_enabled_adap) {
for (i = 0; i < ADV7511_MAX_ADDRS; i++) {
bool is_valid = state->cec_valid_addrs & (1 << i);
@@ -657,7 +656,7 @@ static int adv7511_s_power(struct v4l2_subdev *sd, int on)
const int retries = 20;
int i;
- v4l2_dbg(1, debug, sd, "%s: power %s\n", __func__, on ? "on" : "off");
+ v4l2_dbg(1, debug, sd, "%s: power %s\n", __func__, str_on_off(on));
state->power_on = on;
--
2.34.1
next prev parent reply other threads:[~2026-05-27 14:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-27 14:40 [PATCH 00/12] media: i2c: convert ternaries to " Balakrishnan Sambath
2026-05-27 14:40 ` [PATCH 01/12] media: max9286: use string_choices helper Balakrishnan Sambath
2026-05-27 14:40 ` [PATCH 02/12] media: saa7110: " Balakrishnan Sambath
2026-05-27 14:40 ` [PATCH 03/12] media: tvp7002: " Balakrishnan Sambath
2026-05-27 14:40 ` [PATCH 04/12] media: vpx3220: " Balakrishnan Sambath
2026-05-27 14:40 ` [PATCH 05/12] media: msp3400: use string_choices helpers Balakrishnan Sambath
2026-05-27 14:40 ` [PATCH 06/12] media: tda1997x: use string_choices helper Balakrishnan Sambath
2026-05-27 14:40 ` [PATCH 07/12] media: ths8200: use string_choices helpers Balakrishnan Sambath
2026-05-27 14:40 ` Balakrishnan Sambath [this message]
2026-05-27 14:40 ` [PATCH 09/12] media: saa7127: " Balakrishnan Sambath
2026-05-27 14:40 ` [PATCH 10/12] media: adv7604: " Balakrishnan Sambath
2026-05-27 14:41 ` [PATCH 11/12] media: tc358743: " Balakrishnan Sambath
2026-05-27 14:41 ` [PATCH 12/12] media: adv7842: " Balakrishnan Sambath
2026-05-27 20:54 ` [PATCH 00/12] media: i2c: convert ternaries to " Laurent Pinchart
2026-06-04 6:07 ` Balakrishnan.S
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260527-cleanup-string-choices-media-i2c-v1-8-e8f7d2284288@microchip.com \
--to=balakrishnan.s@microchip.com \
--cc=hverkuil@kernel.org \
--cc=jacopo+renesas@jmondi.org \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=niklas.soderlund+renesas@ragnatech.se \
--cc=tharvey@gateworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®