From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Balakrishnan Sambath <balakrishnan.s@microchip.com>
Cc: "Jacopo Mondi" <jacopo+renesas@jmondi.org>,
"Kieran Bingham" <kieran.bingham+renesas@ideasonboard.com>,
"Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Tim Harvey" <tharvey@gateworks.com>,
"Hans Verkuil" <hverkuil@kernel.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 00/12] media: i2c: convert ternaries to string_choices helpers
Date: Wed, 27 May 2026 22:54:36 +0200 [thread overview]
Message-ID: <20260527205436.GB479227@killaraus.ideasonboard.com> (raw)
In-Reply-To: <20260527-cleanup-string-choices-media-i2c-v1-0-e8f7d2284288@microchip.com>
On Wed, May 27, 2026 at 08:10:49PM +0530, Balakrishnan Sambath wrote:
> Replace boolean-to-string ternaries with helpers from
> <linux/string_choices.h> across drivers/media/i2c/.
I don't think this is an improvement.
> Strings in uppercase or mixed case ("Yes"/"No", "ON"/"OFF", "On"/"Off")
> in adv7604.c, isl7998x.c, and ths7303.c are left as-is since the
> helpers return lowercase only.
>
> Build-tested with x86_64 allmodconfig. No functional change.
>
> Signed-off-by: Balakrishnan Sambath <balakrishnan.s@microchip.com>
> ---
> Balakrishnan Sambath (12):
> media: max9286: use string_choices helper
> media: saa7110: use string_choices helper
> media: tvp7002: use string_choices helper
> media: vpx3220: use string_choices helper
> media: msp3400: use string_choices helpers
> media: tda1997x: use string_choices helper
> media: ths8200: use string_choices helpers
> media: adv7511: use string_choices helpers
> media: saa7127: use string_choices helpers
> media: adv7604: use string_choices helpers
> media: tc358743: use string_choices helpers
> media: adv7842: use string_choices helpers
>
> drivers/media/i2c/adv7511-v4l2.c | 11 +++++-----
> drivers/media/i2c/adv7604.c | 26 +++++++++++-----------
> drivers/media/i2c/adv7842.c | 44 ++++++++++++++++++--------------------
> drivers/media/i2c/max9286.c | 3 ++-
> drivers/media/i2c/msp3400-driver.c | 5 +++--
> drivers/media/i2c/saa7110.c | 3 ++-
> drivers/media/i2c/saa7127.c | 13 +++++------
> drivers/media/i2c/tc358743.c | 40 +++++++++++++++-------------------
> drivers/media/i2c/tda1997x.c | 7 +++---
> drivers/media/i2c/ths8200.c | 9 ++++----
> drivers/media/i2c/tvp7002.c | 3 ++-
> drivers/media/i2c/vpx3220.c | 3 ++-
> 12 files changed, 83 insertions(+), 84 deletions(-)
> ---
> base-commit: a3d78e74dd3ed04797ea351edb7f0a19b961c063
> change-id: 20260527-cleanup-string-choices-media-i2c-5abff65802ea
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2026-05-27 20:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-27 14:40 Balakrishnan Sambath
2026-05-27 14:40 ` [PATCH 01/12] media: max9286: use string_choices helper Balakrishnan Sambath
2026-05-27 14:40 ` [PATCH 02/12] media: saa7110: " Balakrishnan Sambath
2026-05-27 14:40 ` [PATCH 03/12] media: tvp7002: " Balakrishnan Sambath
2026-05-27 14:40 ` [PATCH 04/12] media: vpx3220: " Balakrishnan Sambath
2026-05-27 14:40 ` [PATCH 05/12] media: msp3400: use string_choices helpers Balakrishnan Sambath
2026-05-27 14:40 ` [PATCH 06/12] media: tda1997x: use string_choices helper Balakrishnan Sambath
2026-05-27 14:40 ` [PATCH 07/12] media: ths8200: use string_choices helpers Balakrishnan Sambath
2026-05-27 14:40 ` [PATCH 08/12] media: adv7511: " Balakrishnan Sambath
2026-05-27 14:40 ` [PATCH 09/12] media: saa7127: " Balakrishnan Sambath
2026-05-27 14:40 ` [PATCH 10/12] media: adv7604: " Balakrishnan Sambath
2026-05-27 14:41 ` [PATCH 11/12] media: tc358743: " Balakrishnan Sambath
2026-05-27 14:41 ` [PATCH 12/12] media: adv7842: " Balakrishnan Sambath
2026-05-27 20:54 ` Laurent Pinchart [this message]
2026-06-04 6:07 ` [PATCH 00/12] media: i2c: convert ternaries to " Balakrishnan.S
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260527205436.GB479227@killaraus.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=balakrishnan.s@microchip.com \
--cc=hverkuil@kernel.org \
--cc=jacopo+renesas@jmondi.org \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=niklas.soderlund+renesas@ragnatech.se \
--cc=tharvey@gateworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®