From: Askar Safin <safinaskar@gmail.com>
To: jkoolstra@xs4all.nl
Cc: brauner@kernel.org, cmirabil@redhat.com, cyphar@cyphar.com,
jack@suse.cz, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, viro@zeniv.linux.org.uk
Subject: Re: [RFC PATCH v5 1/2] vfs: add O_CREAT|O_DIRECTORY to open*(2)
Date: Wed, 27 May 2026 21:31:15 +0300 [thread overview]
Message-ID: <20260527183115.2251894-1-safinaskar@gmail.com> (raw)
In-Reply-To: <20260525202937.466497-2-jkoolstra@xs4all.nl>
Jori Koolstra <jkoolstra@xs4all.nl>:
> +static inline umode_t o_create_mode(struct mnt_idmap *idmap,
> + const struct inode *dir, umode_t mode, bool create_dir)
> +{
> + return create_dir ? vfs_prepare_mode(idmap, dir, mode, S_IRWXUGO | S_ISVTX, 0)
> + : vfs_prepare_mode(idmap, dir, mode, S_IALLUGO, S_IFREG);
checkpatch says here:
WARNING: Symbolic permissions 'S_IRWXUGO' are not preferred. Consider using octal permissions '0777'.
#4361: FILE: fs/namei.c:4361:
+ return create_dir ? vfs_prepare_mode(idmap, dir, mode, S_IRWXUGO | S_ISVTX, 0)
--
Askar Safin
next prev parent reply other threads:[~2026-05-27 18:31 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-25 20:29 [RFC PATCH v5 0/2] " Jori Koolstra
2026-05-25 20:29 ` [RFC PATCH v5 1/2] " Jori Koolstra
2026-05-27 7:27 ` NeilBrown
2026-05-27 11:43 ` Christian Brauner
2026-05-27 22:17 ` NeilBrown
2026-05-28 11:33 ` Christian Brauner
2026-05-28 23:58 ` NeilBrown
2026-05-29 7:43 ` Christian Brauner
2026-05-29 9:37 ` NeilBrown
2026-06-01 20:52 ` Jori Koolstra
2026-06-02 13:37 ` Christian Brauner
2026-06-01 21:25 ` Jori Koolstra
2026-06-01 22:58 ` NeilBrown
2026-06-02 15:44 ` Christian Brauner
2026-06-03 13:16 ` Jori Koolstra
2026-06-03 22:56 ` NeilBrown
2026-05-27 18:31 ` Askar Safin [this message]
2026-05-25 20:29 ` [RFC PATCH v5 2/2] selftest: add tests for open*(O_CREAT|O_DIRECTORY) Jori Koolstra
2026-05-27 17:29 ` [RFC PATCH v5 0/2] vfs: add O_CREAT|O_DIRECTORY to open*(2) Askar Safin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260527183115.2251894-1-safinaskar@gmail.com \
--to=safinaskar@gmail.com \
--cc=brauner@kernel.org \
--cc=cmirabil@redhat.com \
--cc=cyphar@cyphar.com \
--cc=jack@suse.cz \
--cc=jkoolstra@xs4all.nl \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®