* [PATCH] powerpc/boot: drop redundant assignment in serial_edit_cmdline
@ 2026-05-28 8:23 Thorsten Blum
2026-08-03 6:57 ` Madhavan Srinivasan
0 siblings, 1 reply; 2+ messages in thread
From: Thorsten Blum @ 2026-05-28 8:23 UTC (permalink / raw)
To: Madhavan Srinivasan, Michael Ellerman, Nicholas Piggin,
Christophe Leroy (CS GROUP)
Cc: Thorsten Blum, linuxppc-dev, linux-kernel
Drop the redundant buffer assignment in serial_edit_cmdline() since the
cp pointer is immediately overwritten.
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
arch/powerpc/boot/serial.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/powerpc/boot/serial.c b/arch/powerpc/boot/serial.c
index c6d32a8c3612..1d221ff420fd 100644
--- a/arch/powerpc/boot/serial.c
+++ b/arch/powerpc/boot/serial.c
@@ -37,7 +37,6 @@ static void serial_edit_cmdline(char *buf, int len, unsigned int timeout)
char ch, *cp;
struct serial_console_data *scdp = console_ops.data;
- cp = buf;
count = strlen(buf);
cp = &buf[count];
count++;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] powerpc/boot: drop redundant assignment in serial_edit_cmdline
2026-05-28 8:23 [PATCH] powerpc/boot: drop redundant assignment in serial_edit_cmdline Thorsten Blum
@ 2026-08-03 6:57 ` Madhavan Srinivasan
0 siblings, 0 replies; 2+ messages in thread
From: Madhavan Srinivasan @ 2026-08-03 6:57 UTC (permalink / raw)
To: Michael Ellerman, Nicholas Piggin, Christophe Leroy (CS GROUP),
Thorsten Blum
Cc: linuxppc-dev, linux-kernel
On Thu, 28 May 2026 10:23:58 +0200, Thorsten Blum wrote:
> Drop the redundant buffer assignment in serial_edit_cmdline() since the
> cp pointer is immediately overwritten.
>
>
Applied to powerpc/next.
[1/1] powerpc/boot: drop redundant assignment in serial_edit_cmdline
https://git.kernel.org/powerpc/c/73dca15a3b813048b01e9c06c260c6508088c2ff
cheers
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-08-03 6:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-05-28 8:23 [PATCH] powerpc/boot: drop redundant assignment in serial_edit_cmdline Thorsten Blum
2026-08-03 6:57 ` Madhavan Srinivasan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®