[PATCH] Documentation: Fix syntax of kmalloc_objs example in coding style doc

[PATCH] Documentation: Fix syntax of kmalloc_objs example in coding style doc

[Uwe Kleine-König]

The first parameter should match the variable that the allocated memory
is assigned to. Fix the example accordingly, the one for kmalloc_obj got
it right already.

Fixes: 7c6d969d5349 ("Documentation: adopt new coding style of type-aware kmalloc-family")
Signed-off-by: Uwe Kleine-König <ukleinek@kernel.org>
---
 Documentation/process/coding-style.rst | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/process/coding-style.rst b/Documentation/process/coding-style.rst
index a3bf75dc7c88..a8336582f60b 100644
--- a/Documentation/process/coding-style.rst
+++ b/Documentation/process/coding-style.rst
@@ -959,13 +959,13 @@ The preferred form for allocating an array is the following:
 
 .. code-block:: c
 
-	p = kmalloc_objs(*ptr, n, ...);
+	p = kmalloc_objs(*p, n, ...);
 
 The preferred form for allocating a zeroed array is the following:
 
 .. code-block:: c
 
-	p = kzalloc_objs(*ptr, n, ...);
+	p = kzalloc_objs(*p, n, ...);
 
 Both forms check for overflow on the allocation size n * sizeof(...),
 and return NULL if that occurred.

base-commit: f7af91adc230aa99e23330ecf85bc9badd9780ad
-- 
2.47.3

Re: [PATCH] Documentation: Fix syntax of kmalloc_objs example in coding style doc

[Geert Uytterhoeven]

On Fri, 29 May 2026 at 10:13, Uwe Kleine-König <ukleinek@kernel.org> wrote:
> The first parameter should match the variable that the allocated memory
> is assigned to. Fix the example accordingly, the one for kmalloc_obj got
> it right already.
>
> Fixes: 7c6d969d5349 ("Documentation: adopt new coding style of type-aware kmalloc-family")
> Signed-off-by: Uwe Kleine-König <ukleinek@kernel.org>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH] Documentation: Fix syntax of kmalloc_objs example in coding style doc

[Jonathan Corbet]

Uwe Kleine-König <ukleinek@kernel.org> writes:

> The first parameter should match the variable that the allocated memory
> is assigned to. Fix the example accordingly, the one for kmalloc_obj got
> it right already.
>
> Fixes: 7c6d969d5349 ("Documentation: adopt new coding style of type-aware kmalloc-family")
> Signed-off-by: Uwe Kleine-König <ukleinek@kernel.org>
> ---
>  Documentation/process/coding-style.rst | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/process/coding-style.rst b/Documentation/process/coding-style.rst
> index a3bf75dc7c88..a8336582f60b 100644
> --- a/Documentation/process/coding-style.rst
> +++ b/Documentation/process/coding-style.rst
> @@ -959,13 +959,13 @@ The preferred form for allocating an array is the following:
>  
>  .. code-block:: c
>  
> -	p = kmalloc_objs(*ptr, n, ...);
> +	p = kmalloc_objs(*p, n, ...);
>  
>  The preferred form for allocating a zeroed array is the following:
>  
>  .. code-block:: c
>  
> -	p = kzalloc_objs(*ptr, n, ...);
> +	p = kzalloc_objs(*p, n, ...);
>  
>  Both forms check for overflow on the allocation size n * sizeof(...),
>  and return NULL if that occurred.

Applied, thanks.

jon

Re: [PATCH] Documentation: Fix syntax of kmalloc_objs example in coding style doc

[Kees Cook]

On Fri, May 29, 2026 at 10:10:05AM +0200, Uwe Kleine-König wrote:
> The first parameter should match the variable that the allocated memory
> is assigned to. Fix the example accordingly, the one for kmalloc_obj got
> it right already.
> 
> Fixes: 7c6d969d5349 ("Documentation: adopt new coding style of type-aware kmalloc-family")
> Signed-off-by: Uwe Kleine-König <ukleinek@kernel.org>

oops, thank you!

Reviewed-by: Kees Cook <kees@kernel.org>

-- 
Kees Cook

Re: [PATCH] Documentation: Fix syntax of kmalloc_objs example in coding style doc

[Manuel Ebner]

Thanks, I realized just now that I introduced this.
 Manuel

On Fri, 2026-05-29 at 10:10 +0200, Uwe Kleine-König wrote:
> The first parameter should match the variable that the allocated memory
> is assigned to. Fix the example accordingly, the one for kmalloc_obj got
> it right already.
> 
> Fixes: 7c6d969d5349 ("Documentation: adopt new coding style of type-aware kmalloc-
> family")
> Signed-off-by: Uwe Kleine-König <ukleinek@kernel.org>
> ---
>  Documentation/process/coding-style.rst | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/process/coding-style.rst b/Documentation/process/coding-
> style.rst
> index a3bf75dc7c88..a8336582f60b 100644
> --- a/Documentation/process/coding-style.rst
> +++ b/Documentation/process/coding-style.rst
> @@ -959,13 +959,13 @@ The preferred form for allocating an array is the following:
>  
>  .. code-block:: c
>  
> -	p = kmalloc_objs(*ptr, n, ...);
> +	p = kmalloc_objs(*p, n, ...);
>  
>  The preferred form for allocating a zeroed array is the following:
>  
>  .. code-block:: c
>  
> -	p = kzalloc_objs(*ptr, n, ...);
> +	p = kzalloc_objs(*p, n, ...);
>  
>  Both forms check for overflow on the allocation size n * sizeof(...),
>  and return NULL if that occurred.
> 
> base-commit: f7af91adc230aa99e23330ecf85bc9badd9780ad