mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Charles Pellegrini <c4ffein.work@gmail.com>
Cc: egorenar-dev@posteo.net, robert.jarzmik@free.fr,
	t-pratham@ti.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] lib: scatterlist: fix sg_split() partial-coverage geometry + add KUnit tests
Date: Mon, 1 Jun 2026 17:55:49 -0700	[thread overview]
Message-ID: <20260601175549.b4a10c07dd9e3b867f66da0c@linux-foundation.org> (raw)
In-Reply-To: <178027099087.72481.1976843064458686851@gmail.com>

On Sun, 31 May 2026 16:42:20 -0700 (PDT) Charles Pellegrini <c4ffein.work@gmail.com> wrote:

> sg_calculate_split() can decrement its nb_splits counter once too often
> and miss the loop-termination check, corrupting the last output split's
> geometry. This series fixes that and adds a KUnit suite.

Thanks.  Has this been observed in real life, or was the patch motivated by
code review?

AI review
(https://sashiko.dev/#/patchset/178027099087.72481.1976843064458686851@gmail.com)
might have found a pre-existing issue, which you may choose to reject,
fix, add to todo list or ignore.  Also a possible issue in the kunit
test changes.

Please take a look, let us know?


  parent reply	other threads:[~2026-06-02  0:55 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-31 23:42 Charles Pellegrini
2026-05-31 23:42 ` [PATCH 1/2] lib: scatterlist: fix sg_calculate_split() nb_splits overshoot on partial coverage Charles Pellegrini
2026-05-31 23:42 ` [PATCH 2/2] lib: scatterlist: add KUnit tests for sg_split() Charles Pellegrini
2026-06-02  0:55 ` Andrew Morton [this message]
2026-06-10 22:35   ` [PATCH 0/2] lib: scatterlist: fix sg_split() partial-coverage geometry + add KUnit tests c4ffein.work
2026-06-10 22:39 ` [PATCH v2 0/5] lib: scatterlist: fix sg_split() partial-coverage geometry, two latent corruption bugs, and " Charles Pellegrini
2026-06-10 22:39   ` [PATCH v2 2/5] lib: scatterlist: fix sg_split_phys() ->length clobber on !NEED_SG_DMA_LENGTH Charles Pellegrini
2026-06-10 22:39   ` [PATCH v2 1/5] lib: scatterlist: fix sg_calculate_split() nb_splits overshoot on partial coverage Charles Pellegrini
2026-06-10 22:39   ` [PATCH v2 3/5] lib: scatterlist: add KUnit tests for sg_split() Charles Pellegrini
2026-06-10 22:39   ` [PATCH v2 5/5] lib: scatterlist: add zero-nents regression test " Charles Pellegrini
2026-06-10 22:39   ` [PATCH v2 4/5] lib: scatterlist: guard sg_split_phys()/sg_split_mapped() against zero-nents splits Charles Pellegrini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260601175549.b4a10c07dd9e3b867f66da0c@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=c4ffein.work@gmail.com \
    --cc=egorenar-dev@posteo.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robert.jarzmik@free.fr \
    --cc=t-pratham@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®