* [PATCH v2] mm: mm_init: use div64_ul() instead of do_div()
@ 2026-06-02 11:32 Giorgi Tchankvetadze via B4 Relay
2026-06-02 13:11 ` Mike Rapoport
0 siblings, 1 reply; 2+ messages in thread
From: Giorgi Tchankvetadze via B4 Relay @ 2026-06-02 11:32 UTC (permalink / raw)
To: Mike Rapoport, Andrew Morton; +Cc: linux-mm, linux-kernel, Giorgi Tchankvetadze
From: Giorgi Tchankvetadze <giorgitchankvetadze1997@gmail.com>
Fixes Coccinelle/coccicheck warning reported by do_div.cocci.
Compared to do_div(), div64_ul() does not implicitly cast the divisor and
does not unnecessarily calculate the remainder.
There are no functional changes. The benefit is purely a semantic cleanup
that better communicates the intent of the division and resolves the
static analysis warning.
Signed-off-by: Giorgi Tchankvetadze <giorgitchankvetadze1997@gmail.com>
---
v2:
- Add changelog text explaining that the change is a semantic cleanup
with no functional impact, as requested by Mike Rapoport.
---
mm/mm_init.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/mm_init.c b/mm/mm_init.c
index f9f8e1af921cda91d812cffdad2f1a0698cfd6ac..4e0909a721d227b097653ed6aaa019960a7c3383 100644
--- a/mm/mm_init.c
+++ b/mm/mm_init.c
@@ -2412,7 +2412,7 @@ void *__init alloc_large_system_hash(const char *tablename,
/* limit allocation size to 1/16 total memory by default */
if (max == 0) {
max = ((unsigned long long)nr_all_pages << PAGE_SHIFT) >> 4;
- do_div(max, bucketsize);
+ max = div64_ul(max, bucketsize);
}
max = min(max, 0x80000000ULL);
---
base-commit: 6f3ed7fec72fc8979b2a8c7219c0a9fcfc8d07b5
change-id: 20260602-mm-div64-cleanup-50ad2020f2da
Best regards,
--
Giorgi Tchankvetadze <giorgitchankvetadze1997@gmail.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v2] mm: mm_init: use div64_ul() instead of do_div()
2026-06-02 11:32 [PATCH v2] mm: mm_init: use div64_ul() instead of do_div() Giorgi Tchankvetadze via B4 Relay
@ 2026-06-02 13:11 ` Mike Rapoport
0 siblings, 0 replies; 2+ messages in thread
From: Mike Rapoport @ 2026-06-02 13:11 UTC (permalink / raw)
To: Andrew Morton, Giorgi Tchankvetadze; +Cc: linux-mm, linux-kernel
On Tue, 02 Jun 2026 15:32:45 +0400, Giorgi Tchankvetadze wrote:
> mm: mm_init: use div64_ul() instead of do_div()
Applied to for-next branch of memblock.git tree, thanks!
[1/1] mm: mm_init: use div64_ul() instead of do_div()
commit: 00e06cb773fd81d4f2806a6ee69d1aef8f6dd5ca
tree: https://git.kernel.org/pub/scm/linux/kernel/git/rppt/memblock
branch: for-next
--
Sincerely yours,
Mike.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-06-02 13:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-06-02 11:32 [PATCH v2] mm: mm_init: use div64_ul() instead of do_div() Giorgi Tchankvetadze via B4 Relay
2026-06-02 13:11 ` Mike Rapoport
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®