* [PATCH] crypto: marvell/octeontx - fix DMA cleanup using wrong loop index
@ 2026-06-02 14:38 Felix Gu
2026-06-02 19:35 ` Markus Elfring
2026-06-11 8:53 ` Herbert Xu
0 siblings, 2 replies; 3+ messages in thread
From: Felix Gu @ 2026-06-02 14:38 UTC (permalink / raw)
To: Srujana Challa, Bharat Bhushan, Herbert Xu, David S. Miller,
Lukasz Bartosik
Cc: linux-crypto, linux-kernel, Felix Gu
The sg_cleanup path used list[i] instead of list[j] when unmapping DMA
buffers, leaking successfully mapped entries and repeatedly unmapping
the failed one.
Fixes: 10b4f09491bf ("crypto: marvell - add the Virtual Function driver for CPT")
Signed-off-by: Felix Gu <ustc.gu@gmail.com>
---
drivers/crypto/marvell/octeontx/otx_cptvf_reqmgr.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/crypto/marvell/octeontx/otx_cptvf_reqmgr.c b/drivers/crypto/marvell/octeontx/otx_cptvf_reqmgr.c
index c80baf1ad90b..89030e2711ce 100644
--- a/drivers/crypto/marvell/octeontx/otx_cptvf_reqmgr.c
+++ b/drivers/crypto/marvell/octeontx/otx_cptvf_reqmgr.c
@@ -157,8 +157,8 @@ static inline int setup_sgio_components(struct pci_dev *pdev,
sg_cleanup:
for (j = 0; j < i; j++) {
if (list[j].dma_addr) {
- dma_unmap_single(&pdev->dev, list[i].dma_addr,
- list[i].size, DMA_BIDIRECTIONAL);
+ dma_unmap_single(&pdev->dev, list[j].dma_addr,
+ list[j].size, DMA_BIDIRECTIONAL);
}
list[j].dma_addr = 0;
---
base-commit: 08484c504b55a98bd100527fbe10a3caf55ff3ff
change-id: 20260602-otx-7bca4557205f
Best regards,
--
Felix Gu <ustc.gu@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] crypto: marvell/octeontx - fix DMA cleanup using wrong loop index
2026-06-02 14:38 [PATCH] crypto: marvell/octeontx - fix DMA cleanup using wrong loop index Felix Gu
@ 2026-06-02 19:35 ` Markus Elfring
2026-06-11 8:53 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: Markus Elfring @ 2026-06-02 19:35 UTC (permalink / raw)
To: Felix Gu, linux-crypto, Bharat Bhushan, David S. Miller,
Herbert Xu, Lukasz Bartosik, Srujana Challa
Cc: LKML
> The sg_cleanup path used list[i] instead of list[j] when unmapping DMA
> buffers, leaking successfully mapped entries and repeatedly unmapping
> the failed one.
See also once more:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v7.1-rc6#n94
Regards,
Markus
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] crypto: marvell/octeontx - fix DMA cleanup using wrong loop index
2026-06-02 14:38 [PATCH] crypto: marvell/octeontx - fix DMA cleanup using wrong loop index Felix Gu
2026-06-02 19:35 ` Markus Elfring
@ 2026-06-11 8:53 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: Herbert Xu @ 2026-06-11 8:53 UTC (permalink / raw)
To: Felix Gu
Cc: Srujana Challa, Bharat Bhushan, David S. Miller, Lukasz Bartosik,
linux-crypto, linux-kernel
On Tue, Jun 02, 2026 at 10:38:26PM +0800, Felix Gu wrote:
> The sg_cleanup path used list[i] instead of list[j] when unmapping DMA
> buffers, leaking successfully mapped entries and repeatedly unmapping
> the failed one.
>
> Fixes: 10b4f09491bf ("crypto: marvell - add the Virtual Function driver for CPT")
> Signed-off-by: Felix Gu <ustc.gu@gmail.com>
> ---
> drivers/crypto/marvell/octeontx/otx_cptvf_reqmgr.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-06-11 8:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-06-02 14:38 [PATCH] crypto: marvell/octeontx - fix DMA cleanup using wrong loop index Felix Gu
2026-06-02 19:35 ` Markus Elfring
2026-06-11 8:53 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®