* [PATCH net v3] dt-bindings: ethernet: eswin: fix hsp-sp-csr backward compatibility
@ 2026-06-02 1:45 lizhi2
2026-06-04 15:40 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: lizhi2 @ 2026-06-02 1:45 UTC (permalink / raw)
To: andrew+netdev, davem, edumazet, kuba, pabeni, robh, krzk+dt,
conor+dt, netdev, devicetree, linux-kernel
Cc: ningyu, linmin, pinkesh.vaghela, pritesh.patel, weishangjuan,
sashiko-bot, Zhi Li, Krzysztof Kozlowski
From: Zhi Li <lizhi2@eswincomputing.com>
Commit c36069c6f46c ("dt-bindings: ethernet: eswin: add optional TXD and
RXD delay register offsets") added two optional cells to eswin,hsp-sp-csr
but omitted minItems: 4.
As a result, dt-schema implicitly required all 6 cells, which broke
backward compatibility with existing 4-cell device trees.
Add minItems: 4 to preserve backward compatibility.
Fixes: c36069c6f46c ("dt-bindings: ethernet: eswin: add optional TXD and RXD delay register offsets")
Reported-by: Sashiko AI <sashiko-bot@kernel.org>
Closes: https://lore.kernel.org/all/20260519022334.35742C2BCB7@smtp.kernel.org/
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Signed-off-by: Zhi Li <lizhi2@eswincomputing.com>
---
Changes in v3:
- Fix commit reference format reported by checkpatch.pl.
- No functional change.
- Link to v2:
https://lore.kernel.org/lkml/20260601032852.961-1-lizhi2@eswincomputing.com/
---
Documentation/devicetree/bindings/net/eswin,eic7700-eth.yaml | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/net/eswin,eic7700-eth.yaml b/Documentation/devicetree/bindings/net/eswin,eic7700-eth.yaml
index b66ae6300faf..65882ff79d8d 100644
--- a/Documentation/devicetree/bindings/net/eswin,eic7700-eth.yaml
+++ b/Documentation/devicetree/bindings/net/eswin,eic7700-eth.yaml
@@ -84,7 +84,8 @@ properties:
This reference is provided for background information only.
$ref: /schemas/types.yaml#/definitions/phandle-array
items:
- - items:
+ - minItems: 4
+ items:
- description: Phandle to HSP(High-Speed Peripheral) device
- description: Offset of phy control register for internal
or external clock selection
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH net v3] dt-bindings: ethernet: eswin: fix hsp-sp-csr backward compatibility
2026-06-02 1:45 [PATCH net v3] dt-bindings: ethernet: eswin: fix hsp-sp-csr backward compatibility lizhi2
@ 2026-06-04 15:40 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2026-06-04 15:40 UTC (permalink / raw)
To: =?utf-8?b?5p2O5b+XIDxsaXpoaTJAZXN3aW5jb21wdXRpbmcuY29tPg==?=
Cc: andrew+netdev, davem, edumazet, kuba, pabeni, robh, krzk+dt,
conor+dt, netdev, devicetree, linux-kernel, ningyu, linmin,
pinkesh.vaghela, pritesh.patel, weishangjuan, sashiko-bot,
krzysztof.kozlowski
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Tue, 2 Jun 2026 09:45:28 +0800 you wrote:
> From: Zhi Li <lizhi2@eswincomputing.com>
>
> Commit c36069c6f46c ("dt-bindings: ethernet: eswin: add optional TXD and
> RXD delay register offsets") added two optional cells to eswin,hsp-sp-csr
> but omitted minItems: 4.
>
> As a result, dt-schema implicitly required all 6 cells, which broke
> backward compatibility with existing 4-cell device trees.
>
> [...]
Here is the summary with links:
- [net,v3] dt-bindings: ethernet: eswin: fix hsp-sp-csr backward compatibility
https://git.kernel.org/netdev/net/c/1232b3104b4b
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-06-04 15:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-06-02 1:45 [PATCH net v3] dt-bindings: ethernet: eswin: fix hsp-sp-csr backward compatibility lizhi2
2026-06-04 15:40 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome