From: Petr Mladek <pmladek@suse.com>
To: John Ogness <john.ogness@linutronix.de>
Cc: Sergey Senozhatsky <senozhatsky@chromium.org>,
Steven Rostedt <rostedt@goodmis.org>,
Marcos Paulo de Souza <mpdesouza@suse.com>,
Chris Down <chris@chrisdown.name>,
linux-kernel@vger.kernel.org, Petr Mladek <pmladek@suse.com>,
Sashiko <sashiko-bot@kernel.org>
Subject: [PATCH v3 05/11] console/braille: Lock console->setup() call during the registration
Date: Tue, 2 Jun 2026 10:53:06 +0200 [thread overview]
Message-ID: <20260602085312.228251-6-pmladek@suse.com> (raw)
In-Reply-To: <20260602085312.228251-1-pmladek@suse.com>
In braille_register_console(), the console->setup() callback must be
called while holding the console_lock. This prevents a race condition
with a possible active boot console that might be using the same hardware
registers.
This applies the same protection to the braille console registration
that was introduced for regular console registration in commit 801410b26a0e
("serial: Lock console when calling into driver before registration").
Reported-by: Sashiko <sashiko-bot@kernel.org>
Closes: https://sashiko.dev/#/patchset/20260423130015.85175-1-pmladek%40suse.com
Assisted-by: Gemini:gemini-3
Signed-off-by: Petr Mladek <pmladek@suse.com>
---
drivers/accessibility/braille/braille_console.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/accessibility/braille/braille_console.c b/drivers/accessibility/braille/braille_console.c
index 7b324329882f..9ed3abffb687 100644
--- a/drivers/accessibility/braille/braille_console.c
+++ b/drivers/accessibility/braille/braille_console.c
@@ -356,7 +356,9 @@ int braille_register_console(struct console *console, int index,
if (braille_co)
return -ENODEV;
if (console->setup) {
+ console_lock();
ret = console->setup(console, console_options);
+ console_unlock();
if (ret != 0)
return ret;
}
--
2.54.0
next prev parent reply other threads:[~2026-06-02 8:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-02 8:53 [PATCH v3 00/11] printk: Clean up preferred console handling Petr Mladek
2026-06-02 8:53 ` [PATCH v3 01/11] printk: Rename struct console_cmdline to preferred_console Petr Mladek
2026-06-02 8:53 ` [PATCH v3 02/11] printk: Rename preferred_console to preferred_dev_console Petr Mladek
2026-06-02 8:53 ` [PATCH v3 03/11] printk: Separate code for adding/updating preferred console metadata Petr Mladek
2026-06-02 8:53 ` [PATCH v3 04/11] printk: Cleanup _braille_(un)register_console() wrappers Petr Mladek
2026-06-02 8:53 ` Petr Mladek [this message]
2026-06-02 8:53 ` [PATCH v3 06/11] printk: Separate code for enabling console Petr Mladek
2026-06-02 8:53 ` [PATCH v3 07/11] printk: Try to register each console as Braille first Petr Mladek
2026-06-02 8:53 ` [PATCH v3 08/11] printk: Do not set Braille console as preferred_console Petr Mladek
2026-06-02 8:53 ` [PATCH v3 09/11] printk: Handle pre-enabled consoles in the top-level try_enable_console() Petr Mladek
2026-06-02 8:53 ` [PATCH v3 10/11] printk: Try enable preferred consoles only when there are any Petr Mladek
2026-06-03 15:29 ` Petr Mladek
2026-06-02 8:53 ` [PATCH v3 11/11] printk: Modify try_enable_default_console() to return error/success Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260602085312.228251-6-pmladek@suse.com \
--to=pmladek@suse.com \
--cc=chris@chrisdown.name \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mpdesouza@suse.com \
--cc=rostedt@goodmis.org \
--cc=sashiko-bot@kernel.org \
--cc=senozhatsky@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®