* [PATCH RESEND] drm/bridge: sii902x: inline i2c_check_functionality check
@ 2026-06-02 22:31 Thorsten Blum
2026-06-03 14:19 ` Luca Ceresoli
0 siblings, 1 reply; 5+ messages in thread
From: Thorsten Blum @ 2026-06-02 22:31 UTC (permalink / raw)
To: Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec, Luca Ceresoli, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter
Cc: Thorsten Blum, Dmitry Baryshkov, dri-devel, linux-kernel
Inline the i2c_check_functionality() check, since the function returns a
boolean status rather than an error code.
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
drivers/gpu/drm/bridge/sii902x.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/bridge/sii902x.c b/drivers/gpu/drm/bridge/sii902x.c
index 12497f5ce4ff..0cc738e2dd63 100644
--- a/drivers/gpu/drm/bridge/sii902x.c
+++ b/drivers/gpu/drm/bridge/sii902x.c
@@ -1158,9 +1158,7 @@ static int sii902x_probe(struct i2c_client *client)
static const char * const supplies[] = {"iovcc", "cvcc12"};
int ret;
- ret = i2c_check_functionality(client->adapter,
- I2C_FUNC_SMBUS_BYTE_DATA);
- if (!ret) {
+ if (!i2c_check_functionality(client->adapter, I2C_FUNC_SMBUS_BYTE_DATA)) {
dev_err(dev, "I2C adapter not suitable\n");
return -EIO;
}
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH RESEND] drm/bridge: sii902x: inline i2c_check_functionality check
2026-06-02 22:31 [PATCH RESEND] drm/bridge: sii902x: inline i2c_check_functionality check Thorsten Blum
@ 2026-06-03 14:19 ` Luca Ceresoli
0 siblings, 0 replies; 5+ messages in thread
From: Luca Ceresoli @ 2026-06-03 14:19 UTC (permalink / raw)
To: Thorsten Blum, Andrzej Hajda, Neil Armstrong, Robert Foss,
Laurent Pinchart, Jonas Karlman, Jernej Skrabec, Luca Ceresoli,
Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
David Airlie, Simona Vetter
Cc: Dmitry Baryshkov, dri-devel, linux-kernel
On Wed Jun 3, 2026 at 12:31 AM CEST, Thorsten Blum wrote:
> Inline the i2c_check_functionality() check, since the function returns a
> boolean status rather than an error code.
>
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH RESEND] drm/bridge: sii902x: inline i2c_check_functionality check
2026-05-17 17:21 Thorsten Blum
2026-05-17 20:59 ` Dmitry Baryshkov
@ 2026-06-16 20:35 ` Luca Ceresoli
1 sibling, 0 replies; 5+ messages in thread
From: Luca Ceresoli @ 2026-06-16 20:35 UTC (permalink / raw)
To: Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Thorsten Blum
Cc: dri-devel, linux-kernel
On Sun, 17 May 2026 19:21:37 +0200, Thorsten Blum wrote:
> Inline the i2c_check_functionality() check, since the function returns a
> boolean status rather than an error code.
Applied, thanks!
[1/1] drm/bridge: sii902x: inline i2c_check_functionality check
commit: ef1d1506976f9bd35864344d2a78a67bf6091bdb
Best regards,
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH RESEND] drm/bridge: sii902x: inline i2c_check_functionality check
2026-05-17 17:21 Thorsten Blum
@ 2026-05-17 20:59 ` Dmitry Baryshkov
2026-06-16 20:35 ` Luca Ceresoli
1 sibling, 0 replies; 5+ messages in thread
From: Dmitry Baryshkov @ 2026-05-17 20:59 UTC (permalink / raw)
To: Thorsten Blum
Cc: Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec, Luca Ceresoli, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
dri-devel, linux-kernel
On Sun, May 17, 2026 at 07:21:37PM +0200, Thorsten Blum wrote:
> Inline the i2c_check_functionality() check, since the function returns a
> boolean status rather than an error code.
>
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> ---
> drivers/gpu/drm/bridge/sii902x.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH RESEND] drm/bridge: sii902x: inline i2c_check_functionality check
@ 2026-05-17 17:21 Thorsten Blum
2026-05-17 20:59 ` Dmitry Baryshkov
2026-06-16 20:35 ` Luca Ceresoli
0 siblings, 2 replies; 5+ messages in thread
From: Thorsten Blum @ 2026-05-17 17:21 UTC (permalink / raw)
To: Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec, Luca Ceresoli, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter
Cc: Thorsten Blum, dri-devel, linux-kernel
Inline the i2c_check_functionality() check, since the function returns a
boolean status rather than an error code.
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
drivers/gpu/drm/bridge/sii902x.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/bridge/sii902x.c b/drivers/gpu/drm/bridge/sii902x.c
index ea543be4ae3e..38d176d4eef2 100644
--- a/drivers/gpu/drm/bridge/sii902x.c
+++ b/drivers/gpu/drm/bridge/sii902x.c
@@ -1158,9 +1158,7 @@ static int sii902x_probe(struct i2c_client *client)
static const char * const supplies[] = {"iovcc", "cvcc12"};
int ret;
- ret = i2c_check_functionality(client->adapter,
- I2C_FUNC_SMBUS_BYTE_DATA);
- if (!ret) {
+ if (!i2c_check_functionality(client->adapter, I2C_FUNC_SMBUS_BYTE_DATA)) {
dev_err(dev, "I2C adapter not suitable\n");
return -EIO;
}
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-06-16 20:36 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-06-02 22:31 [PATCH RESEND] drm/bridge: sii902x: inline i2c_check_functionality check Thorsten Blum
2026-06-03 14:19 ` Luca Ceresoli
-- strict thread matches above, loose matches on Subject: below --
2026-05-17 17:21 Thorsten Blum
2026-05-17 20:59 ` Dmitry Baryshkov
2026-06-16 20:35 ` Luca Ceresoli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome