[PATCH 1/2] dt-bindings: hwmon: isl68137: Add RAA228234 compatible

[PATCH 1/2] dt-bindings: hwmon: isl68137: Add RAA228234 compatible

[Naresh Solanki]

From: Patrick Rudolph <patrick.rudolph@9elements.com>

Add the compatible string for the Renesas RAA228234 8-phase PWM
controller, which shares the same PMBus interface as the RAA228228.

Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
Signed-off-by: Naresh Solanki <naresh.solanki@9elements.com>
---
 Documentation/devicetree/bindings/hwmon/pmbus/isil,isl68137.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/isil,isl68137.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/isil,isl68137.yaml
index 8216cdf758d8..2988bc6300ae 100644
--- a/Documentation/devicetree/bindings/hwmon/pmbus/isil,isl68137.yaml
+++ b/Documentation/devicetree/bindings/hwmon/pmbus/isil,isl68137.yaml
@@ -55,6 +55,7 @@ properties:
           - renesas,raa228004
           - renesas,raa228006
           - renesas,raa228228
+          - renesas,raa228234
           - renesas,raa228244
           - renesas,raa228246
           - renesas,raa229001
-- 
2.43.0

[PATCH 2/2] hwmon: pmbus: isl68137: Add support for RAA228234

[Naresh Solanki]

From: Patrick Rudolph <patrick.rudolph@9elements.com>

The RAA228234 is an 8-phase PWM controller from Renesas. It uses the
same DMPVR2 PMBus interface as the RAA228228 (a dual-output 20-phase
controller), so it can share the raa_dmpvr2_2rail_nontc configuration.

Add the device to the I2C and OF device ID tables.

Tested on RAA228234 hardware; confirmed all sensor readings are correct.

Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
Signed-off-by: Naresh Solanki <naresh.solanki@9elements.com>
---
 drivers/hwmon/pmbus/isl68137.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/hwmon/pmbus/isl68137.c b/drivers/hwmon/pmbus/isl68137.c
index 21d047b577a4..bef1459cec48 100644
--- a/drivers/hwmon/pmbus/isl68137.c
+++ b/drivers/hwmon/pmbus/isl68137.c
@@ -448,6 +448,7 @@ static const struct i2c_device_id raa_dmpvr_id[] = {
 	{"raa228004", raa_dmpvr2_hv},
 	{"raa228006", raa_dmpvr2_hv},
 	{"raa228228", raa_dmpvr2_2rail_nontc},
+	{"raa228234", raa_dmpvr2_2rail_nontc},
 	{"raa228244", raa_dmpvr2_2rail_nontc},
 	{"raa228246", raa_dmpvr2_2rail_nontc},
 	{"raa228942", raa_dmpvr2_2rail_nontc},
@@ -501,6 +502,7 @@ static const struct of_device_id isl68137_of_match[] = {
 	{ .compatible = "renesas,raa228004", .data = (void *)raa_dmpvr2_hv },
 	{ .compatible = "renesas,raa228006", .data = (void *)raa_dmpvr2_hv },
 	{ .compatible = "renesas,raa228228", .data = (void *)raa_dmpvr2_2rail_nontc },
+	{ .compatible = "renesas,raa228234", .data = (void *)raa_dmpvr2_2rail_nontc },
 	{ .compatible = "renesas,raa228244", .data = (void *)raa_dmpvr2_2rail_nontc },
 	{ .compatible = "renesas,raa228246", .data = (void *)raa_dmpvr2_2rail_nontc },
 	{ .compatible = "renesas,raa229001", .data = (void *)raa_dmpvr2_2rail },
-- 
2.43.0

Re: [PATCH 1/2] dt-bindings: hwmon: isl68137: Add RAA228234 compatible

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 1246 bytes --]

On Wed, Jun 03, 2026 at 11:01:26AM +0000, Naresh Solanki wrote:
> From: Patrick Rudolph <patrick.rudolph@9elements.com>
> 
> Add the compatible string for the Renesas RAA228234 8-phase PWM
> controller, which shares the same PMBus interface as the RAA228228.

Given this, and what the driver change looks like, why is a fallback
compatible not used?

> 
> Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
> Signed-off-by: Naresh Solanki <naresh.solanki@9elements.com>
> ---
>  Documentation/devicetree/bindings/hwmon/pmbus/isil,isl68137.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/isil,isl68137.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/isil,isl68137.yaml
> index 8216cdf758d8..2988bc6300ae 100644
> --- a/Documentation/devicetree/bindings/hwmon/pmbus/isil,isl68137.yaml
> +++ b/Documentation/devicetree/bindings/hwmon/pmbus/isil,isl68137.yaml
> @@ -55,6 +55,7 @@ properties:
>            - renesas,raa228004
>            - renesas,raa228006
>            - renesas,raa228228
> +          - renesas,raa228234
>            - renesas,raa228244
>            - renesas,raa228246
>            - renesas,raa229001
> -- 
> 2.43.0
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH 1/2] dt-bindings: hwmon: isl68137: Add RAA228234 compatible

[Naresh Solanki]

Hi


On Wed, 3 Jun 2026 at 21:39, Conor Dooley <conor@kernel.org> wrote:
>
> On Wed, Jun 03, 2026 at 11:01:26AM +0000, Naresh Solanki wrote:
> > From: Patrick Rudolph <patrick.rudolph@9elements.com>
> >
> > Add the compatible string for the Renesas RAA228234 8-phase PWM
> > controller, which shares the same PMBus interface as the RAA228228.
>
> Given this, and what the driver change looks like, why is a fallback
> compatible not used?
Are you suggesting that the binding should use renesas,raa228228 as a
fallback compatible, similar to how renesas,raa228942 and
renesas,raa228943 fall back to renesas,raa228244? Or is there a
specific reason you'd expect it not to be used here?

Regards,
Naresh

>
> >
> > Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
> > Signed-off-by: Naresh Solanki <naresh.solanki@9elements.com>
> > ---
> >  Documentation/devicetree/bindings/hwmon/pmbus/isil,isl68137.yaml | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/isil,isl68137.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/isil,isl68137.yaml
> > index 8216cdf758d8..2988bc6300ae 100644
> > --- a/Documentation/devicetree/bindings/hwmon/pmbus/isil,isl68137.yaml
> > +++ b/Documentation/devicetree/bindings/hwmon/pmbus/isil,isl68137.yaml
> > @@ -55,6 +55,7 @@ properties:
> >            - renesas,raa228004
> >            - renesas,raa228006
> >            - renesas,raa228228
> > +          - renesas,raa228234
> >            - renesas,raa228244
> >            - renesas,raa228246
> >            - renesas,raa229001
> > --
> > 2.43.0
> >

Re: [PATCH 1/2] dt-bindings: hwmon: isl68137: Add RAA228234 compatible

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 2391 bytes --]

On Wed, Jun 03, 2026 at 10:10:14PM +0530, Naresh Solanki wrote:
> Hi
> 
> 
> On Wed, 3 Jun 2026 at 21:39, Conor Dooley <conor@kernel.org> wrote:
> >
> > On Wed, Jun 03, 2026 at 11:01:26AM +0000, Naresh Solanki wrote:
> > > From: Patrick Rudolph <patrick.rudolph@9elements.com>
> > >
> > > Add the compatible string for the Renesas RAA228234 8-phase PWM
> > > controller, which shares the same PMBus interface as the RAA228228.
> >
> > Given this, and what the driver change looks like, why is a fallback
> > compatible not used?
> Are you suggesting that the binding should use renesas,raa228228 as a
> fallback compatible, similar to how renesas,raa228942 and
> renesas,raa228943 fall back to renesas,raa228244?

I didn't see that at the time (I commented on this diff alone), but yes.
 	{ .compatible = "renesas,raa228228", .data = (void *)raa_dmpvr2_2rail_nontc },
+	{ .compatible = "renesas,raa228234", .data = (void *)raa_dmpvr2_2rail_nontc },
 	{ .compatible = "renesas,raa228244", .data = (void *)raa_dmpvr2_2rail_nontc },
 	{ .compatible = "renesas,raa228246", .data = (void *)raa_dmpvr2_2rail_nontc },
driver change suggests you're compatible with the ..44 device.

I expect that you'll use a fallback in the next iteration then?
pw-bot: changes-requested

Cheers,
Conor.

> Or is there a
> specific reason you'd expect it not to be used here?
> 
> Regards,
> Naresh
> 
> >
> > >
> > > Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
> > > Signed-off-by: Naresh Solanki <naresh.solanki@9elements.com>
> > > ---
> > >  Documentation/devicetree/bindings/hwmon/pmbus/isil,isl68137.yaml | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/isil,isl68137.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/isil,isl68137.yaml
> > > index 8216cdf758d8..2988bc6300ae 100644
> > > --- a/Documentation/devicetree/bindings/hwmon/pmbus/isil,isl68137.yaml
> > > +++ b/Documentation/devicetree/bindings/hwmon/pmbus/isil,isl68137.yaml
> > > @@ -55,6 +55,7 @@ properties:
> > >            - renesas,raa228004
> > >            - renesas,raa228006
> > >            - renesas,raa228228
> > > +          - renesas,raa228234
> > >            - renesas,raa228244
> > >            - renesas,raa228246
> > >            - renesas,raa229001
> > > --
> > > 2.43.0
> > >

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]