From: Jonathan Cameron <jic23@kernel.org>
To: Waqar Hameed <waqar.hameed@axis.com>
Cc: Andy Shevchenko <andriy.shevchenko@intel.com>,
Miao Li <limiao870622@163.com>, <dlechner@baylibre.com>,
<nuno.sa@analog.com>, <andy@kernel.org>, <bigeasy@linutronix.de>,
<marcus.folkesson@gmail.com>, <dixitparmar19@gmail.com>,
<linux-iio@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<limiao@kylinos.cn>
Subject: Re: [PATCH] iio: accel: stk8ba50: Update includes to match IWYU
Date: Wed, 3 Jun 2026 11:45:09 +0100 [thread overview]
Message-ID: <20260603114509.1623e3d4@jic23-huawei> (raw)
In-Reply-To: <pnda4tc12x1.a.out@axis.com>
On Wed, 3 Jun 2026 09:47:06 +0200
Waqar Hameed <waqar.hameed@axis.com> wrote:
> On Wed, Jun 03, 2026 at 08:52 +0300 Andy Shevchenko <andriy.shevchenko@intel.com> wrote:
>
> [...]
>
> >> +#include <linux/iio/types.h>
> >
> > Not sure if we need this one to be explicitly added when iio.h is included.
>
> I would vote for removing this, to be consistent with most other drivers.
I've merged changes recently where some included this and some didn't.
I agree that we can assume iio.h will always include it so probably better
to drop it from these sorts of change. I don't want to see lots of patches dropping
from existing drivers though as that's just too much churn.
Jonathan
prev parent reply other threads:[~2026-06-03 10:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-03 1:50 Miao Li
2026-06-03 5:52 ` Andy Shevchenko
2026-06-03 7:47 ` Waqar Hameed
2026-06-03 10:45 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260603114509.1623e3d4@jic23-huawei \
--to=jic23@kernel.org \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=bigeasy@linutronix.de \
--cc=dixitparmar19@gmail.com \
--cc=dlechner@baylibre.com \
--cc=limiao870622@163.com \
--cc=limiao@kylinos.cn \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcus.folkesson@gmail.com \
--cc=nuno.sa@analog.com \
--cc=waqar.hameed@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®