From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Miao Li <limiao870622@163.com>
Cc: jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com,
andy@kernel.org, bigeasy@linutronix.de, waqar.hameed@axis.com,
marcus.folkesson@gmail.com, dixitparmar19@gmail.com,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
limiao@kylinos.cn
Subject: Re: [PATCH] iio: accel: stk8ba50: Update includes to match IWYU
Date: Wed, 3 Jun 2026 08:52:47 +0300 [thread overview]
Message-ID: <ah_BL85vs88ynvQ2@ashevche-desk.local> (raw)
In-Reply-To: <20260603015033.187735-1-limiao870622@163.com>
On Wed, Jun 03, 2026 at 09:50:33AM +0800, Miao Li wrote:
> Update the list of included headers in stk8ba50.c using
> Include-What-You-Use (IWYU) tool, mainly to remove kernel.h
> and add missing headers such as array_size.h, bits.h,
> dev_printk.h, etc.
...
> +#include <linux/array_size.h>
> +#include <linux/bits.h>
> +#include <linux/dev_printk.h>
> +#include <linux/errno.h>
> #include <linux/i2c.h>
> #include <linux/interrupt.h>
> -#include <linux/kernel.h>
> #include <linux/module.h>
> #include <linux/mod_devicetable.h>
> +#include <linux/mutex.h>
> +#include <linux/pm.h>
> +#include <linux/sysfs.h>
> #include <linux/types.h>
While at it, add a blank line here.
> #include <linux/iio/buffer.h>
> #include <linux/iio/iio.h>
...
> +#include <linux/iio/types.h>
Not sure if we need this one to be explicitly added when iio.h is included.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-06-03 5:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-03 1:50 Miao Li
2026-06-03 5:52 ` Andy Shevchenko [this message]
2026-06-03 7:47 ` Waqar Hameed
2026-06-03 10:45 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ah_BL85vs88ynvQ2@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=bigeasy@linutronix.de \
--cc=dixitparmar19@gmail.com \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=limiao870622@163.com \
--cc=limiao@kylinos.cn \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcus.folkesson@gmail.com \
--cc=nuno.sa@analog.com \
--cc=waqar.hameed@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome