* [PATCH] media: qcom: camss: Rename unused macro parameter
@ 2026-06-03 23:12 Hungyu Lin
2026-06-03 23:16 ` Bryan O'Donoghue
2026-06-04 0:09 ` Vladimir Zapolskiy
0 siblings, 2 replies; 3+ messages in thread
From: Hungyu Lin @ 2026-06-03 23:12 UTC (permalink / raw)
To: rfoss, todor.too, bryan.odonoghue, mchehab
Cc: vladimir.zapolskiy, linux-media, linux-arm-msm, linux-kernel, Hungyu Lin
The ISPIF_VFE_m_RDI_INTF_n_PACK_CFG_0_CID_c_PLAIN() macro
declares a parameter named 'c' but uses 'cid' in the macro
body instead.
Rename the parameter to match the identifier used in the
macro body and silence the checkpatch warning:
WARNING: Argument 'c' is not used in function-like macro
No functional change intended.
Signed-off-by: Hungyu Lin <dennylin0707@gmail.com>
---
drivers/media/platform/qcom/camss/camss-ispif.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/qcom/camss/camss-ispif.c b/drivers/media/platform/qcom/camss/camss-ispif.c
index aaf3caa42d33..8b0753e606c1 100644
--- a/drivers/media/platform/qcom/camss/camss-ispif.c
+++ b/drivers/media/platform/qcom/camss/camss-ispif.c
@@ -83,7 +83,7 @@
(0x270 + 0x200 * (m) + 0x4 * (n))
#define ISPIF_VFE_m_RDI_INTF_n_PACK_CFG_1(m, n) \
(0x27c + 0x200 * (m) + 0x4 * (n))
-#define ISPIF_VFE_m_RDI_INTF_n_PACK_CFG_0_CID_c_PLAIN(c) \
+#define ISPIF_VFE_m_RDI_INTF_n_PACK_CFG_0_CID_c_PLAIN(cid) \
(1 << ((cid % 8) * 4))
#define ISPIF_VFE_m_PIX_INTF_n_STATUS(m, n) \
(0x2c0 + 0x200 * (m) + 0x4 * (n))
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] media: qcom: camss: Rename unused macro parameter
2026-06-03 23:12 [PATCH] media: qcom: camss: Rename unused macro parameter Hungyu Lin
@ 2026-06-03 23:16 ` Bryan O'Donoghue
2026-06-04 0:09 ` Vladimir Zapolskiy
1 sibling, 0 replies; 3+ messages in thread
From: Bryan O'Donoghue @ 2026-06-03 23:16 UTC (permalink / raw)
To: Hungyu Lin, rfoss, todor.too, mchehab
Cc: vladimir.zapolskiy, linux-media, linux-arm-msm, linux-kernel
On 04/06/2026 00:12, Hungyu Lin wrote:
> The ISPIF_VFE_m_RDI_INTF_n_PACK_CFG_0_CID_c_PLAIN() macro
> declares a parameter named 'c' but uses 'cid' in the macro
> body instead.
>
> Rename the parameter to match the identifier used in the
> macro body and silence the checkpatch warning:
>
> WARNING: Argument 'c' is not used in function-like macro
>
> No functional change intended.
>
> Signed-off-by: Hungyu Lin <dennylin0707@gmail.com>
> ---
> drivers/media/platform/qcom/camss/camss-ispif.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/qcom/camss/camss-ispif.c b/drivers/media/platform/qcom/camss/camss-ispif.c
> index aaf3caa42d33..8b0753e606c1 100644
> --- a/drivers/media/platform/qcom/camss/camss-ispif.c
> +++ b/drivers/media/platform/qcom/camss/camss-ispif.c
> @@ -83,7 +83,7 @@
> (0x270 + 0x200 * (m) + 0x4 * (n))
> #define ISPIF_VFE_m_RDI_INTF_n_PACK_CFG_1(m, n) \
> (0x27c + 0x200 * (m) + 0x4 * (n))
> -#define ISPIF_VFE_m_RDI_INTF_n_PACK_CFG_0_CID_c_PLAIN(c) \
> +#define ISPIF_VFE_m_RDI_INTF_n_PACK_CFG_0_CID_c_PLAIN(cid) \
> (1 << ((cid % 8) * 4))
> #define ISPIF_VFE_m_PIX_INTF_n_STATUS(m, n) \
> (0x2c0 + 0x200 * (m) + 0x4 * (n))
Nasty
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
---
bod
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] media: qcom: camss: Rename unused macro parameter
2026-06-03 23:12 [PATCH] media: qcom: camss: Rename unused macro parameter Hungyu Lin
2026-06-03 23:16 ` Bryan O'Donoghue
@ 2026-06-04 0:09 ` Vladimir Zapolskiy
1 sibling, 0 replies; 3+ messages in thread
From: Vladimir Zapolskiy @ 2026-06-04 0:09 UTC (permalink / raw)
To: Hungyu Lin, rfoss, todor.too, bryan.odonoghue, mchehab
Cc: linux-media, linux-arm-msm, linux-kernel
On 6/4/26 02:12, Hungyu Lin wrote:
> The ISPIF_VFE_m_RDI_INTF_n_PACK_CFG_0_CID_c_PLAIN() macro
> declares a parameter named 'c' but uses 'cid' in the macro
> body instead.
>
> Rename the parameter to match the identifier used in the
> macro body and silence the checkpatch warning:
>
> WARNING: Argument 'c' is not used in function-like macro
>
> No functional change intended.
>
> Signed-off-by: Hungyu Lin <dennylin0707@gmail.com>
Reviewed-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
--
Best wishes,
Vladimir
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-06-04 0:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-06-03 23:12 [PATCH] media: qcom: camss: Rename unused macro parameter Hungyu Lin
2026-06-03 23:16 ` Bryan O'Donoghue
2026-06-04 0:09 ` Vladimir Zapolskiy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®