mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sneh Mankad <sneh.mankad@oss.qualcomm.com>
To: Thomas Gleixner <tglx@kernel.org>,
	Daniel Lezcano <daniel.lezcano@oss.qualcomm.com>,
	Peter Zijlstra <peterz@infradead.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Pavel Machek <pavel@kernel.org>, Len Brown <lenb@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-pm@vger.kernel.org,
	Sneh Mankad <sneh.mankad@oss.qualcomm.com>
Subject: [PATCH] kernel/cpu: Disallow offlining boot CPU based on config
Date: Fri, 05 Jun 2026 16:00:46 +0530	[thread overview]
Message-ID: <20260605-disable_boot_cpu_offline-v1-1-4c68fe1a6cf8@oss.qualcomm.com> (raw)

The Qualcomm SoCs like LeMans, Monaco support suspend to ram which leads
the SoC to ACPI S3 similar state where SoC is turned off and DDR is
retained.
The hardware design on these SoCs forces a constraint to suspend and
resume the system on boot CPU / CPU0.

If CPU0 is already offline before starting suspend to ram the
freeze_secondary_cpus() picks alternate CPU as primary / last CPU and
proceed further to invoke PSCI SYSTEM_SUSPEND.
This leads to a system crash.

In order to prevent such an issue introduce PM_SLEEP_SMP_CPU_ZERO_STRICT
config and when enabled prohibit the CPU0 to be offline.

Signed-off-by: Sneh Mankad <sneh.mankad@oss.qualcomm.com>
---
 kernel/cpu.c         | 4 ++++
 kernel/power/Kconfig | 8 ++++++++
 2 files changed, 12 insertions(+)

diff --git a/kernel/cpu.c b/kernel/cpu.c
index bc4f7a9ba64e62d76fbb2b362f243c918defe5bc..1c878db1d9cb6df0e31cb55343851aab4e38a3a0 100644
--- a/kernel/cpu.c
+++ b/kernel/cpu.c
@@ -1478,6 +1478,10 @@ static int cpu_down_maps_locked(unsigned int cpu, enum cpuhp_state target)
 	 */
 	if (cpu_hotplug_offline_disabled)
 		return -EOPNOTSUPP;
+#ifdef CONFIG_PM_SLEEP_SMP_CPU_ZERO_STRICT
+	if (cpu == get_boot_cpu_id())
+		return -EPERM;
+#endif
 	if (cpu_hotplug_disabled)
 		return -EBUSY;
 	return _cpu_down(cpu, 0, target);
diff --git a/kernel/power/Kconfig b/kernel/power/Kconfig
index 05337f437cca29da57864583166d7f9abd526507..0b342b3a4a5650a1927dc4805d1515e1d9e067c6 100644
--- a/kernel/power/Kconfig
+++ b/kernel/power/Kconfig
@@ -401,3 +401,11 @@ config ENERGY_MODEL
 	  The exact usage of the energy model is subsystem-dependent.
 
 	  If in doubt, say N.
+
+config PM_SLEEP_SMP_CPU_ZERO_STRICT
+	bool "Disallow boot CPU (CPU0) offline"
+	depends on HOTPLUG_CPU
+	depends on SUSPEND
+	help
+	  Disallow boot CPU (CPU0) offline when the suspend_ops->enter()
+	  has to be executed by boot CPU.

---
base-commit: ba3e43a9e601636f5edb54e259a74f96ca3b8fd8
change-id: 20260603-disable_boot_cpu_offline-eb4f55ac96f2

Best regards,
-- 
Sneh Mankad <sneh.mankad@oss.qualcomm.com>


             reply	other threads:[~2026-06-05 10:31 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-05 10:30 Sneh Mankad [this message]
2026-06-05 10:43 ` Peter Zijlstra
2026-06-05 12:20   ` Thomas Gleixner
2026-06-15 12:13     ` Daniel Lezcano
2026-06-05 13:07 ` Pankaj Patil
2026-06-23 11:40 ` Daniel Lezcano
2026-07-03 11:23   ` Sneh Mankad

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260605-disable_boot_cpu_offline-v1-1-4c68fe1a6cf8@oss.qualcomm.com \
    --to=sneh.mankad@oss.qualcomm.com \
    --cc=daniel.lezcano@oss.qualcomm.com \
    --cc=lenb@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=pavel@kernel.org \
    --cc=peterz@infradead.org \
    --cc=rafael@kernel.org \
    --cc=tglx@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®