mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] dt-bindings: media: Add macros for video interface devices
@ 2026-06-05 15:03 Kieran Bingham
  2026-06-05 15:13 ` Laurent Pinchart
  2026-06-05 15:59 ` Conor Dooley
  0 siblings, 2 replies; 5+ messages in thread
From: Kieran Bingham @ 2026-06-05 15:03 UTC (permalink / raw)
  To: Mauro Carvalho Chehab, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, open list,
	open list:MEDIA INPUT INFRASTRUCTURE (V4L/DVB),
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
  Cc: laurent.pinchart, Kieran Bingham

Add a new dt-bindings/media/video-interface-devices.h header that
defines macros corresponding to the orientation enumeration types from
media/video-interface-devices.yaml.

This allows avoiding hardcoded constants in device tree sources.

Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
---
 include/dt-bindings/media/video-interface-devices.h | 13 +++++++++++++
 1 file changed, 13 insertions(+)
 create mode 100644 include/dt-bindings/media/video-interface-devices.h

diff --git a/include/dt-bindings/media/video-interface-devices.h b/include/dt-bindings/media/video-interface-devices.h
new file mode 100644
index 000000000000..d2340b457292
--- /dev/null
+++ b/include/dt-bindings/media/video-interface-devices.h
@@ -0,0 +1,13 @@
+/* SPDX-License-Identifier: (GPL-2.0-only OR MIT) */
+/*
+ * Copyright (C) 2026 Kieran Bingham <kieran.bingham@ideasonboard.com>
+ */
+
+#ifndef __DT_BINDINGS_MEDIA_VIDEO_INTERFACE_DEVICES_H__
+#define __DT_BINDINGS_MEDIA_VIDEO_INTERFACE_DEVICES_H__
+
+#define MEDIA_ORIENTATION_FRONT		0
+#define MEDIA_ORIENTATION_BACK		1
+#define MEDIA_ORIENTATION_EXTERNAL	2
+
+#endif /* __DT_BINDINGS_MEDIA_VIDEO_INTERFACE_DEVICES_H__ */
-- 
2.52.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] dt-bindings: media: Add macros for video interface devices
  2026-06-05 15:03 [PATCH] dt-bindings: media: Add macros for video interface devices Kieran Bingham
@ 2026-06-05 15:13 ` Laurent Pinchart
  2026-06-05 21:36   ` Sakari Ailus
  2026-06-05 15:59 ` Conor Dooley
  1 sibling, 1 reply; 5+ messages in thread
From: Laurent Pinchart @ 2026-06-05 15:13 UTC (permalink / raw)
  To: Kieran Bingham
  Cc: Mauro Carvalho Chehab, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, open list,
	open list:MEDIA INPUT INFRASTRUCTURE (V4L/DVB),
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	Sakari Ailus

CC'ing Sakari.

On Fri, Jun 05, 2026 at 04:03:08PM +0100, Kieran Bingham wrote:
> Add a new dt-bindings/media/video-interface-devices.h header that
> defines macros corresponding to the orientation enumeration types from
> media/video-interface-devices.yaml.
> 
> This allows avoiding hardcoded constants in device tree sources.
> 
> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
> ---
>  include/dt-bindings/media/video-interface-devices.h | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
>  create mode 100644 include/dt-bindings/media/video-interface-devices.h
> 
> diff --git a/include/dt-bindings/media/video-interface-devices.h b/include/dt-bindings/media/video-interface-devices.h
> new file mode 100644
> index 000000000000..d2340b457292
> --- /dev/null
> +++ b/include/dt-bindings/media/video-interface-devices.h
> @@ -0,0 +1,13 @@
> +/* SPDX-License-Identifier: (GPL-2.0-only OR MIT) */
> +/*
> + * Copyright (C) 2026 Kieran Bingham <kieran.bingham@ideasonboard.com>
> + */
> +
> +#ifndef __DT_BINDINGS_MEDIA_VIDEO_INTERFACE_DEVICES_H__
> +#define __DT_BINDINGS_MEDIA_VIDEO_INTERFACE_DEVICES_H__
> +
> +#define MEDIA_ORIENTATION_FRONT		0
> +#define MEDIA_ORIENTATION_BACK		1
> +#define MEDIA_ORIENTATION_EXTERNAL	2
> +
> +#endif /* __DT_BINDINGS_MEDIA_VIDEO_INTERFACE_DEVICES_H__ */

-- 
Regards,

Laurent Pinchart

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] dt-bindings: media: Add macros for video interface devices
  2026-06-05 15:03 [PATCH] dt-bindings: media: Add macros for video interface devices Kieran Bingham
  2026-06-05 15:13 ` Laurent Pinchart
@ 2026-06-05 15:59 ` Conor Dooley
  1 sibling, 0 replies; 5+ messages in thread
From: Conor Dooley @ 2026-06-05 15:59 UTC (permalink / raw)
  To: Kieran Bingham
  Cc: Mauro Carvalho Chehab, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, open list,
	open list:MEDIA INPUT INFRASTRUCTURE (V4L/DVB),
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	laurent.pinchart

[-- Attachment #1: Type: text/plain, Size: 75 bytes --]

Acked-by: Conor Dooley <conor.dooley@microchip.com>
pw-bot: not-applicable

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] dt-bindings: media: Add macros for video interface devices
  2026-06-05 15:13 ` Laurent Pinchart
@ 2026-06-05 21:36   ` Sakari Ailus
  2026-06-05 21:59     ` Laurent Pinchart
  0 siblings, 1 reply; 5+ messages in thread
From: Sakari Ailus @ 2026-06-05 21:36 UTC (permalink / raw)
  To: Laurent Pinchart
  Cc: Kieran Bingham, Mauro Carvalho Chehab, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, open list,
	open list:MEDIA INPUT INFRASTRUCTURE (V4L/DVB),
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS

Hi Laurent, Kieran,

On Fri, Jun 05, 2026 at 06:13:53PM +0300, Laurent Pinchart wrote:
> CC'ing Sakari.

Thanks for cc'ing me.

> 
> On Fri, Jun 05, 2026 at 04:03:08PM +0100, Kieran Bingham wrote:
> > Add a new dt-bindings/media/video-interface-devices.h header that
> > defines macros corresponding to the orientation enumeration types from
> > media/video-interface-devices.yaml.
> > 
> > This allows avoiding hardcoded constants in device tree sources.
> > 
> > Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
> > ---
> >  include/dt-bindings/media/video-interface-devices.h | 13 +++++++++++++
> >  1 file changed, 13 insertions(+)
> >  create mode 100644 include/dt-bindings/media/video-interface-devices.h
> > 
> > diff --git a/include/dt-bindings/media/video-interface-devices.h b/include/dt-bindings/media/video-interface-devices.h
> > new file mode 100644
> > index 000000000000..d2340b457292
> > --- /dev/null
> > +++ b/include/dt-bindings/media/video-interface-devices.h
> > @@ -0,0 +1,13 @@
> > +/* SPDX-License-Identifier: (GPL-2.0-only OR MIT) */
> > +/*
> > + * Copyright (C) 2026 Kieran Bingham <kieran.bingham@ideasonboard.com>
> > + */
> > +
> > +#ifndef __DT_BINDINGS_MEDIA_VIDEO_INTERFACE_DEVICES_H__
> > +#define __DT_BINDINGS_MEDIA_VIDEO_INTERFACE_DEVICES_H__
> > +
> > +#define MEDIA_ORIENTATION_FRONT		0
> > +#define MEDIA_ORIENTATION_BACK		1
> > +#define MEDIA_ORIENTATION_EXTERNAL	2
> > +
> > +#endif /* __DT_BINDINGS_MEDIA_VIDEO_INTERFACE_DEVICES_H__ */
> 

Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>

-- 
Kind regards,

Sakari Ailus

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] dt-bindings: media: Add macros for video interface devices
  2026-06-05 21:36   ` Sakari Ailus
@ 2026-06-05 21:59     ` Laurent Pinchart
  0 siblings, 0 replies; 5+ messages in thread
From: Laurent Pinchart @ 2026-06-05 21:59 UTC (permalink / raw)
  To: Sakari Ailus
  Cc: Kieran Bingham, Mauro Carvalho Chehab, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, open list,
	open list:MEDIA INPUT INFRASTRUCTURE (V4L/DVB),
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS

On Sat, Jun 06, 2026 at 12:36:31AM +0300, Sakari Ailus wrote:
> Hi Laurent, Kieran,
> 
> On Fri, Jun 05, 2026 at 06:13:53PM +0300, Laurent Pinchart wrote:
> > CC'ing Sakari.
> 
> Thanks for cc'ing me.
> 
> > On Fri, Jun 05, 2026 at 04:03:08PM +0100, Kieran Bingham wrote:
> > > Add a new dt-bindings/media/video-interface-devices.h header that
> > > defines macros corresponding to the orientation enumeration types from
> > > media/video-interface-devices.yaml.
> > > 
> > > This allows avoiding hardcoded constants in device tree sources.
> > > 
> > > Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
> > > ---
> > >  include/dt-bindings/media/video-interface-devices.h | 13 +++++++++++++

A mention of the header in video-interface-devices.yaml would be useful,
the same way we mention video-interfaces.h in video-interfaces.yaml.
Apart from that,

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> > >  1 file changed, 13 insertions(+)
> > >  create mode 100644 include/dt-bindings/media/video-interface-devices.h
> > > 
> > > diff --git a/include/dt-bindings/media/video-interface-devices.h b/include/dt-bindings/media/video-interface-devices.h
> > > new file mode 100644
> > > index 000000000000..d2340b457292
> > > --- /dev/null
> > > +++ b/include/dt-bindings/media/video-interface-devices.h
> > > @@ -0,0 +1,13 @@
> > > +/* SPDX-License-Identifier: (GPL-2.0-only OR MIT) */
> > > +/*
> > > + * Copyright (C) 2026 Kieran Bingham <kieran.bingham@ideasonboard.com>
> > > + */
> > > +
> > > +#ifndef __DT_BINDINGS_MEDIA_VIDEO_INTERFACE_DEVICES_H__
> > > +#define __DT_BINDINGS_MEDIA_VIDEO_INTERFACE_DEVICES_H__
> > > +
> > > +#define MEDIA_ORIENTATION_FRONT		0
> > > +#define MEDIA_ORIENTATION_BACK		1
> > > +#define MEDIA_ORIENTATION_EXTERNAL	2
> > > +
> > > +#endif /* __DT_BINDINGS_MEDIA_VIDEO_INTERFACE_DEVICES_H__ */
> 
> Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>

-- 
Regards,

Laurent Pinchart

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2026-06-05 21:59 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-06-05 15:03 [PATCH] dt-bindings: media: Add macros for video interface devices Kieran Bingham
2026-06-05 15:13 ` Laurent Pinchart
2026-06-05 21:36   ` Sakari Ailus
2026-06-05 21:59     ` Laurent Pinchart
2026-06-05 15:59 ` Conor Dooley

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®