mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ming Qian <ming.qian@oss.nxp.com>
To: Mauro Carvalho Chehab <mchehab@kernel.org>,
	 Hans Verkuil <hverkuil@kernel.org>,
	 Nicolas Dufresne <nicolas.dufresne@collabora.com>
Cc: Zhou Peng <eagle.zhou@nxp.com>, Elliot Chen <elliot.chen@nxp.com>,
	 Frank Li <Frank.Li@nxp.com>,
	linux-imx@nxp.com, imx@lists.linux.dev,
	 linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
	 Ming Qian <ming.qian@oss.nxp.com>
Subject: [PATCH RFC 2/2] media: amphion: Add V4L2_FMT_FLAG_DYN_RESOLUTION for VC1L
Date: Mon, 08 Jun 2026 12:56:59 +0900	[thread overview]
Message-ID: <20260608-flag-dyn-resolution-v1-2-44dc65516148@oss.nxp.com> (raw)
In-Reply-To: <20260608-flag-dyn-resolution-v1-0-44dc65516148@oss.nxp.com>

The amphion VPU decoder always emits an initial V4L2_EVENT_SOURCE_CHANGE
event after parsing the resolution from the stream header for VC1 Annex
L format. Without V4L2_FMT_FLAG_DYN_RESOLUTION, userspace (e.g.
GStreamer) cannot determine that the driver will signal the initial
resolution, causing it to skip waiting for the event and fail to set up
the CAPTURE queue properly.

Add V4L2_FMT_FLAG_DYN_RESOLUTION to the VC1 Annex L format entry to
indicate that the decoder will emit the source change event during
initialization, consistent with other coded formats supported by this
driver.

Fixes: e670f5d672ef ("media: amphion: only insert the first sequence startcode for vc1l format")
Signed-off-by: Ming Qian <ming.qian@oss.nxp.com>
---
 drivers/media/platform/amphion/vdec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/platform/amphion/vdec.c b/drivers/media/platform/amphion/vdec.c
index a9f0521f2e1a..75808482d090 100644
--- a/drivers/media/platform/amphion/vdec.c
+++ b/drivers/media/platform/amphion/vdec.c
@@ -136,7 +136,7 @@ static const struct vpu_format vdec_formats[] = {
 		.mem_planes = 1,
 		.comp_planes = 1,
 		.type = V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE,
-		.flags = V4L2_FMT_FLAG_COMPRESSED
+		.flags = V4L2_FMT_FLAG_DYN_RESOLUTION | V4L2_FMT_FLAG_COMPRESSED
 	},
 	{
 		.pixfmt = V4L2_PIX_FMT_MPEG2,

-- 
2.54.0


  parent reply	other threads:[~2026-06-08  3:57 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-08  3:56 [PATCH RFC 0/2] media: amphion: Clarify and restore " Ming Qian
2026-06-08  3:56 ` [PATCH RFC 1/2] media: docs: Clarify V4L2_FMT_FLAG_DYN_RESOLUTION usage Ming Qian
     [not found]   ` <20260608040616.1A3EE1F00893@smtp.kernel.org>
2026-06-08  6:26     ` Ming Qian (OSS)
2026-06-09 18:00       ` Nicolas Dufresne
2026-06-10  2:49         ` Ming Qian(OSS)
2026-06-10  3:36           ` Ming Qian(OSS)
2026-06-10  6:15             ` Hans Verkuil
2026-06-10 14:00               ` Nicolas Dufresne
2026-06-10 13:20           ` Nicolas Dufresne
2026-06-11  4:32             ` Ming Qian(OSS)
2026-06-08  3:56 ` Ming Qian [this message]
2026-09-28 19:39   ` [PATCH RFC 2/2] media: amphion: Add V4L2_FMT_FLAG_DYN_RESOLUTION for VC1L Nicolas Dufresne
2026-09-29  7:32     ` Ming Qian(OSS)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260608-flag-dyn-resolution-v1-2-44dc65516148@oss.nxp.com \
    --to=ming.qian@oss.nxp.com \
    --cc=Frank.Li@nxp.com \
    --cc=eagle.zhou@nxp.com \
    --cc=elliot.chen@nxp.com \
    --cc=hverkuil@kernel.org \
    --cc=imx@lists.linux.dev \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=nicolas.dufresne@collabora.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®