Re: [PATCH RFC 2/2] media: amphion: Add V4L2_FMT_FLAG_DYN_RESOLUTION for VC1L

["Ming Qian(OSS)" <ming.qian@oss.nxp.com>]

Hi Nicolas,

On 9/29/2026 3:39 AM, Nicolas Dufresne wrote:
> Hi,
> 
> Le lundi 08 juin 2026 à 12:56 +0900, Ming Qian a écrit :
>> The amphion VPU decoder always emits an initial V4L2_EVENT_SOURCE_CHANGE
>> event after parsing the resolution from the stream header for VC1 Annex
>> L format. Without V4L2_FMT_FLAG_DYN_RESOLUTION, userspace (e.g.
>> GStreamer) cannot determine that the driver will signal the initial
>> resolution, causing it to skip waiting for the event and fail to set up
>> the CAPTURE queue properly.
>>
>> Add V4L2_FMT_FLAG_DYN_RESOLUTION to the VC1 Annex L format entry to
>> indicate that the decoder will emit the source change event during
>> initialization, consistent with other coded formats supported by this
>> driver.
>>
>> Fixes: e670f5d672ef ("media: amphion: only insert the first sequence startcode for vc1l format")
>> Signed-off-by: Ming Qian <ming.qian@oss.nxp.com>
> 
> 
> Can you send a non RFC version of this.

Sure, I have posted the v2 and drop the documentation change.

Regards,
Ming

> 
> Reviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>
> 
>> ---
>>   drivers/media/platform/amphion/vdec.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/media/platform/amphion/vdec.c b/drivers/media/platform/amphion/vdec.c
>> index a9f0521f2e1a..75808482d090 100644
>> --- a/drivers/media/platform/amphion/vdec.c
>> +++ b/drivers/media/platform/amphion/vdec.c
>> @@ -136,7 +136,7 @@ static const struct vpu_format vdec_formats[] = {
>>   		.mem_planes = 1,
>>   		.comp_planes = 1,
>>   		.type = V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE,
>> -		.flags = V4L2_FMT_FLAG_COMPRESSED
>> +		.flags = V4L2_FMT_FLAG_DYN_RESOLUTION | V4L2_FMT_FLAG_COMPRESSED
>>   	},
>>   	{
>>   		.pixfmt = V4L2_PIX_FMT_MPEG2,