From: David Howells <dhowells@redhat.com>
To: Christian Brauner <christian@brauner.io>
Cc: David Howells <dhowells@redhat.com>,
Marc Dionne <marc.dionne@auristor.com>,
linux-afs@lists.infradead.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, Zilin Guan <zilin@seu.edu.cn>
Subject: [PATCH 5/7] afs: use kvfree() to free memory allocated by kvcalloc()
Date: Tue, 9 Jun 2026 09:17:35 +0100 [thread overview]
Message-ID: <20260609081738.770127-6-dhowells@redhat.com> (raw)
In-Reply-To: <20260609081738.770127-1-dhowells@redhat.com>
From: Zilin Guan <zilin@seu.edu.cn>
op->more_files is allocated with kvcalloc() but released via
afs_put_operation(), which uses kfree() internally. This mismach prevents
the resource from being released properly and may lead to undefined
behavior.
Fix this by using kvfree() to free op->more_files to match its allocation
method.
Fixes: e49c7b2f6de7 ("afs: Build an abstraction around an "operation" concept")
Signed-off-by: Zilin Guan <zilin@seu.edu.cn>
Signed-off-by: David Howells <dhowells@redhat.com>
cc: Marc Dionne <marc.dionne@auristor.com>
cc: linux-afs@lists.infradead.org
---
fs/afs/fs_operation.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/afs/fs_operation.c b/fs/afs/fs_operation.c
index c0dbbc6d3716..20801b29521d 100644
--- a/fs/afs/fs_operation.c
+++ b/fs/afs/fs_operation.c
@@ -348,7 +348,7 @@ int afs_put_operation(struct afs_operation *op)
for (i = 0; i < op->nr_files - 2; i++)
if (op->more_files[i].put_vnode)
iput(&op->more_files[i].vnode->netfs.inode);
- kfree(op->more_files);
+ kvfree(op->more_files);
}
if (op->estate) {
next prev parent reply other threads:[~2026-06-09 8:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-09 8:17 [PATCH 0/7] afs: Miscellaneous fixes David Howells
2026-06-09 8:17 ` [PATCH 1/7] afs: handle CB.InitCallBackState3 requests without a server record David Howells
2026-06-09 8:17 ` [PATCH 2/7] afs: Fix error code in afs_extract_vl_addrs() David Howells
2026-06-09 8:17 ` [PATCH 3/7] afs: fix NULL pointer dereference in afs_get_tree() David Howells
2026-06-09 8:17 ` [PATCH 4/7] afs: Remove setting of AS_RELEASE_ALWAYS for symlinks and mountpoints David Howells
2026-06-09 8:17 ` David Howells [this message]
2026-06-09 8:17 ` [PATCH 6/7] afs: Remove erroneous seq |= 1 in volume lookup loop David Howells
2026-06-09 9:18 ` Oleg Nesterov
2026-06-09 15:53 ` David Howells
2026-06-09 16:43 ` Jeffrey E Altman
2026-06-09 8:17 ` [PATCH 7/7] afs: check for duplicate servers in VL server list David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260609081738.770127-6-dhowells@redhat.com \
--to=dhowells@redhat.com \
--cc=christian@brauner.io \
--cc=linux-afs@lists.infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.dionne@auristor.com \
--cc=zilin@seu.edu.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome