mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: Christian Brauner <christian@brauner.io>
Cc: David Howells <dhowells@redhat.com>,
	Marc Dionne <marc.dionne@auristor.com>,
	linux-afs@lists.infradead.org, linux-fsdevel@vger.kernel.org,
	linux-kernel@vger.kernel.org, Li RongQing <lirongqing@baidu.com>,
	Oleg Nesterov <oleg@redhat.com>
Subject: [PATCH 6/7] afs: Remove erroneous seq |= 1 in volume lookup loop
Date: Tue,  9 Jun 2026 09:17:36 +0100	[thread overview]
Message-ID: <20260609081738.770127-7-dhowells@redhat.com> (raw)
In-Reply-To: <20260609081738.770127-1-dhowells@redhat.com>

From: Li RongQing <lirongqing@baidu.com>

The `seq |= 1` operation in the volume lookup loop is incorrect because:
seq is already incremented at start, making it odd in next iteration
which triggers lock, but The `|= 1` operation causes seq to be even
and unintended lockless operation

Remove this erroneous operation to maintain proper lock sequencing.

Fixes: 32222f09782f ("afs: Apply server breaks to mmap'd files in the call processor")
Signed-off-by: Li RongQing <lirongqing@baidu.com>
Signed-off-by: David Howells <dhowells@redhat.com>
Reviewed-by: Oleg Nesterov <oleg@redhat.com>
cc: Marc Dionne <marc.dionne@auristor.com>
cc: linux-afs@lists.infradead.org
---
 fs/afs/callback.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/fs/afs/callback.c b/fs/afs/callback.c
index 894d2bad6b6c..833ac3178ddc 100644
--- a/fs/afs/callback.c
+++ b/fs/afs/callback.c
@@ -140,7 +140,6 @@ static struct afs_volume *afs_lookup_volume_rcu(struct afs_cell *cell,
 			break;
 		if (!need_seqretry(&cell->volume_lock, seq))
 			break;
-		seq |= 1; /* Want a lock next time */
 	}
 
 	done_seqretry(&cell->volume_lock, seq);


  parent reply	other threads:[~2026-06-09  8:19 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-09  8:17 [PATCH 0/7] afs: Miscellaneous fixes David Howells
2026-06-09  8:17 ` [PATCH 1/7] afs: handle CB.InitCallBackState3 requests without a server record David Howells
2026-06-09  8:17 ` [PATCH 2/7] afs: Fix error code in afs_extract_vl_addrs() David Howells
2026-06-09  8:17 ` [PATCH 3/7] afs: fix NULL pointer dereference in afs_get_tree() David Howells
2026-06-09  8:17 ` [PATCH 4/7] afs: Remove setting of AS_RELEASE_ALWAYS for symlinks and mountpoints David Howells
2026-06-09  8:17 ` [PATCH 5/7] afs: use kvfree() to free memory allocated by kvcalloc() David Howells
2026-06-09  8:17 ` David Howells [this message]
2026-06-09  9:18   ` [PATCH 6/7] afs: Remove erroneous seq |= 1 in volume lookup loop Oleg Nesterov
2026-06-09 15:53   ` David Howells
2026-06-09 16:43     ` Jeffrey E Altman
2026-06-09  8:17 ` [PATCH 7/7] afs: check for duplicate servers in VL server list David Howells

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260609081738.770127-7-dhowells@redhat.com \
    --to=dhowells@redhat.com \
    --cc=christian@brauner.io \
    --cc=linux-afs@lists.infradead.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lirongqing@baidu.com \
    --cc=marc.dionne@auristor.com \
    --cc=oleg@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome