From: "Chuyi Zhou" <zhouchuyi@bytedance.com>
To: <tglx@kernel.org>, <mingo@redhat.com>, <luto@kernel.org>,
<peterz@infradead.org>, <paulmck@kernel.org>,
<muchun.song@linux.dev>, <bp@alien8.de>,
<dave.hansen@linux.intel.com>, <pbonzini@redhat.com>,
<bigeasy@linutronix.de>, <clrkwllms@kernel.org>,
<rostedt@goodmis.org>, <nadav.amit@gmail.com>,
<vkuznets@redhat.com>
Cc: <linux-kernel@vger.kernel.org>, "Chuyi Zhou" <zhouchuyi@bytedance.com>
Subject: [PATCH v7 01/14] smp: Disable preemption explicitly in __csd_lock_wait()
Date: Tue, 9 Jun 2026 17:16:57 +0800 [thread overview]
Message-ID: <20260609091710.404083-2-zhouchuyi@bytedance.com> (raw)
In-Reply-To: <20260609091710.404083-1-zhouchuyi@bytedance.com>
The latter patches will enable preemption before csd_lock_wait(), which
could break csdlock_debug. Because the slice of other tasks on the CPU may
be accounted between ktime_get_mono_fast_ns() calls, disable preemption
explicitly in __csd_lock_wait(). This is a preparation for the next
patches.
Signed-off-by: Chuyi Zhou <zhouchuyi@bytedance.com>
Acked-by: Muchun Song <muchun.song@linux.dev>
Reviewed-by: Steven Rostedt (Google) <rostedt@goodmis.org>
Reviewed-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Tested-by: Paul E. McKenney <paulmck@kernel.org>
---
kernel/smp.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/kernel/smp.c b/kernel/smp.c
index a0bb56bd8dda..b58975480e11 100644
--- a/kernel/smp.c
+++ b/kernel/smp.c
@@ -323,6 +323,8 @@ static void __csd_lock_wait(call_single_data_t *csd)
int bug_id = 0;
u64 ts0, ts1;
+ guard(preempt)();
+
ts1 = ts0 = ktime_get_mono_fast_ns();
for (;;) {
if (csd_lock_wait_toolong(csd, ts0, &ts1, &bug_id, &nmessages))
--
2.20.1
next prev parent reply other threads:[~2026-06-09 9:18 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-09 9:16 [PATCH v7 00/14] smp: Allow preemption while waiting for IPI completion Chuyi Zhou
2026-06-09 9:16 ` Chuyi Zhou [this message]
2026-06-09 9:16 ` [PATCH v7 02/14] smp: Enable preemption early in smp_call_function_single() Chuyi Zhou
2026-06-09 9:16 ` [PATCH v7 03/14] smp: Refactor remote CPU selection in smp_call_function_any() Chuyi Zhou
2026-06-09 9:17 ` [PATCH v7 04/14] smp: Use task-local IPI cpumask in smp_call_function_many_cond() Chuyi Zhou
2026-06-09 9:17 ` [PATCH v7 05/14] smp: Alloc percpu csd data in smpcfd_prepare_cpu() only once Chuyi Zhou
2026-06-09 9:17 ` [PATCH v7 06/14] smp: Enable preemption early in smp_call_function_many_cond() Chuyi Zhou
2026-06-09 9:17 ` [PATCH v7 07/14] smp: Remove preempt_disable() from smp_call_function() Chuyi Zhou
2026-06-09 9:17 ` [PATCH v7 08/14] smp: Remove preempt_disable() from on_each_cpu_cond_mask() Chuyi Zhou
2026-06-09 9:17 ` [PATCH v7 09/14] scftorture: Remove preempt_disable() in scftorture_invoke_one() Chuyi Zhou
2026-06-09 9:17 ` [PATCH v7 10/14] x86/mm: Factor out flush_tlb_info initialization Chuyi Zhou
2026-06-09 9:17 ` [PATCH v7 11/14] x86/mm: Cap flush_tlb_info alignment at 64 bytes Chuyi Zhou
2026-06-11 15:37 ` Nadav Amit
2026-06-11 16:16 ` Chuyi Zhou
2026-06-09 9:17 ` [PATCH v7 12/14] x86/mm: Move flush_tlb_info back to the stack Chuyi Zhou
2026-06-11 16:20 ` Nadav Amit
2026-06-12 2:22 ` Chuyi Zhou
2026-06-09 9:17 ` [PATCH v7 13/14] x86/kvm: Disable preemption in kvm_flush_tlb_multi() Chuyi Zhou
2026-06-09 9:17 ` [PATCH v7 14/14] x86/mm: Re-enable preemption before flush_tlb_multi() Chuyi Zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260609091710.404083-2-zhouchuyi@bytedance.com \
--to=zhouchuyi@bytedance.com \
--cc=bigeasy@linutronix.de \
--cc=bp@alien8.de \
--cc=clrkwllms@kernel.org \
--cc=dave.hansen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=muchun.song@linux.dev \
--cc=nadav.amit@gmail.com \
--cc=paulmck@kernel.org \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@kernel.org \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®