From: Nadav Amit <nadav.amit@gmail.com>
To: Chuyi Zhou <zhouchuyi@bytedance.com>,
tglx@kernel.org, mingo@redhat.com, luto@kernel.org,
peterz@infradead.org, paulmck@kernel.org, muchun.song@linux.dev,
bp@alien8.de, dave.hansen@linux.intel.com, pbonzini@redhat.com,
bigeasy@linutronix.de, clrkwllms@kernel.org, rostedt@goodmis.org,
vkuznets@redhat.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 12/14] x86/mm: Move flush_tlb_info back to the stack
Date: Thu, 11 Jun 2026 19:20:11 +0300 [thread overview]
Message-ID: <63df046e-7dcd-4a0b-a41a-12aa578b69a9@gmail.com> (raw)
In-Reply-To: <20260609091710.404083-13-zhouchuyi@bytedance.com>
On 09/06/2026 12:17, Chuyi Zhou wrote:
> -
> void flush_tlb_mm_range(struct mm_struct *mm, unsigned long start,
> unsigned long end, unsigned int stride_shift,
> bool freed_tables)
> {
> - struct flush_tlb_info *info;
> + struct flush_tlb_info _info;
> + struct flush_tlb_info *info = &_info;
> int cpu = get_cpu();
> u64 new_tlb_gen;
>
> /* This is also a barrier that synchronizes with switch_mm(). */
> new_tlb_gen = inc_mm_tlb_gen(mm);
>
> - info = get_flush_tlb_info(mm, start, end, stride_shift, freed_tables,
> - new_tlb_gen);
> + init_flush_tlb_info(&_info, mm, start, end, stride_shift, freed_tables,
> + new_tlb_gen);
You use here &_info instead of info. At the same time
kernel_tlb_flush_range() and friends use info for the struct itself, not
the pointer, so maybe just get rid of _info and call it info?
next prev parent reply other threads:[~2026-06-11 16:20 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-09 9:16 [PATCH v7 00/14] smp: Allow preemption while waiting for IPI completion Chuyi Zhou
2026-06-09 9:16 ` [PATCH v7 01/14] smp: Disable preemption explicitly in __csd_lock_wait() Chuyi Zhou
2026-06-09 9:16 ` [PATCH v7 02/14] smp: Enable preemption early in smp_call_function_single() Chuyi Zhou
2026-06-09 9:16 ` [PATCH v7 03/14] smp: Refactor remote CPU selection in smp_call_function_any() Chuyi Zhou
2026-06-09 9:17 ` [PATCH v7 04/14] smp: Use task-local IPI cpumask in smp_call_function_many_cond() Chuyi Zhou
2026-06-09 9:17 ` [PATCH v7 05/14] smp: Alloc percpu csd data in smpcfd_prepare_cpu() only once Chuyi Zhou
2026-06-09 9:17 ` [PATCH v7 06/14] smp: Enable preemption early in smp_call_function_many_cond() Chuyi Zhou
2026-06-09 9:17 ` [PATCH v7 07/14] smp: Remove preempt_disable() from smp_call_function() Chuyi Zhou
2026-06-09 9:17 ` [PATCH v7 08/14] smp: Remove preempt_disable() from on_each_cpu_cond_mask() Chuyi Zhou
2026-06-09 9:17 ` [PATCH v7 09/14] scftorture: Remove preempt_disable() in scftorture_invoke_one() Chuyi Zhou
2026-06-09 9:17 ` [PATCH v7 10/14] x86/mm: Factor out flush_tlb_info initialization Chuyi Zhou
2026-06-09 9:17 ` [PATCH v7 11/14] x86/mm: Cap flush_tlb_info alignment at 64 bytes Chuyi Zhou
2026-06-11 15:37 ` Nadav Amit
2026-06-11 16:16 ` Chuyi Zhou
2026-06-09 9:17 ` [PATCH v7 12/14] x86/mm: Move flush_tlb_info back to the stack Chuyi Zhou
2026-06-11 16:20 ` Nadav Amit [this message]
2026-06-12 2:22 ` Chuyi Zhou
2026-06-09 9:17 ` [PATCH v7 13/14] x86/kvm: Disable preemption in kvm_flush_tlb_multi() Chuyi Zhou
2026-06-09 9:17 ` [PATCH v7 14/14] x86/mm: Re-enable preemption before flush_tlb_multi() Chuyi Zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63df046e-7dcd-4a0b-a41a-12aa578b69a9@gmail.com \
--to=nadav.amit@gmail.com \
--cc=bigeasy@linutronix.de \
--cc=bp@alien8.de \
--cc=clrkwllms@kernel.org \
--cc=dave.hansen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=muchun.song@linux.dev \
--cc=paulmck@kernel.org \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@kernel.org \
--cc=vkuznets@redhat.com \
--cc=zhouchuyi@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®