From: Vipin Sharma <vipinsh@google.com>
To: Pratyush Yadav <pratyush@kernel.org>
Cc: pasha.tatashin@soleen.com, rppt@kernel.org, shuah@kernel.org,
dmatlack@google.com, skhawaja@google.com, tarunsahu@google.com,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH 1/2] selftests/liveupdate: Move luo_test_utils.* into a reusable library
Date: Wed, 10 Jun 2026 11:06:54 -0700 [thread overview]
Message-ID: <20260610180329.GA224168.vipinsh@google.com> (raw)
In-Reply-To: <2vxzo6hlt86a.fsf@kernel.org>
On Mon, Jun 08, 2026 at 04:31:57PM +0200, Pratyush Yadav wrote:
> On Mon, May 11 2026, Vipin Sharma wrote:
>
> > Move luo_test_utils.[ch] into a lib/ directory and pull the rules to
> > build them out into a separate make script. This will enable these
> > utilities to be also built by and used within other selftests (such as
> > VFIO).
> >
> > No functional change intended.
> >
> > Signed-off-by: Vipin Sharma <vipinsh@google.com>
> > Co-developed-by: David Matlack <dmatlack@google.com>
> > Signed-off-by: David Matlack <dmatlack@google.com>
> > Signed-off-by: Vipin Sharma <vipinsh@google.com>
> > ---
> > tools/testing/selftests/liveupdate/.gitignore | 1 +
> > tools/testing/selftests/liveupdate/Makefile | 14 ++++---------
> > .../include/libliveupdate.h} | 8 ++++----
>
> Nit: perhaps libluo is a bit less wordy?
>
> No strong opinions on it though, so I am fine with anything.
>
Thought more about it, I think libliveupdate seems more appropriate:
- VFIO is using similar strategy libvfio
- Name matches selftest folder name, so, kind of easy to know where the
library is from.
As you seem fine with anything, I will keep it libliveupdate. Thanks!
next prev parent reply other threads:[~2026-06-10 18:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-11 20:11 [PATCH 0/2] Make liveupdate selftests util as a library Vipin Sharma
2026-05-11 20:11 ` [PATCH 1/2] selftests/liveupdate: Move luo_test_utils.* into a reusable library Vipin Sharma
2026-06-08 14:31 ` Pratyush Yadav
2026-06-10 18:06 ` Vipin Sharma [this message]
2026-05-11 20:11 ` [PATCH 2/2] selftests/liveupdate: Add helpers to preserve/retrieve FDs Vipin Sharma
2026-05-18 11:29 ` tarunsahu
2026-05-18 17:14 ` Vipin Sharma
2026-06-08 14:32 ` Pratyush Yadav
2026-06-08 18:44 ` tarunsahu
2026-06-08 14:38 ` Pratyush Yadav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260610180329.GA224168.vipinsh@google.com \
--to=vipinsh@google.com \
--cc=dmatlack@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=pasha.tatashin@soleen.com \
--cc=pratyush@kernel.org \
--cc=rppt@kernel.org \
--cc=shuah@kernel.org \
--cc=skhawaja@google.com \
--cc=tarunsahu@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome