mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] riscv: smp: use secs_to_jiffies in __cpu_up
@ 2026-06-11 23:25 Thorsten Blum
  2026-06-25 18:25 ` Paul Walmsley
  0 siblings, 1 reply; 2+ messages in thread
From: Thorsten Blum @ 2026-06-11 23:25 UTC (permalink / raw)
  To: Paul Walmsley, Palmer Dabbelt, Albert Ou, Alexandre Ghiti,
	Vivian Wang, Atish Patra, Anup Patel
  Cc: Thorsten Blum, linux-riscv, linux-kernel

Use secs_to_jiffies() to simplify the code. Drop the redundant zero
initialization while at it.

Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
 arch/riscv/kernel/smpboot.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/arch/riscv/kernel/smpboot.c b/arch/riscv/kernel/smpboot.c
index 8b628580fe11..f6ef57930b50 100644
--- a/arch/riscv/kernel/smpboot.c
+++ b/arch/riscv/kernel/smpboot.c
@@ -189,13 +189,12 @@ int arch_cpuhp_kick_ap_alive(unsigned int cpu, struct task_struct *tidle)
 #else
 int __cpu_up(unsigned int cpu, struct task_struct *tidle)
 {
-	int ret = 0;
+	int ret;
 	tidle->thread_info.cpu = cpu;
 
 	ret = start_secondary_cpu(cpu, tidle);
 	if (!ret) {
-		wait_for_completion_timeout(&cpu_running,
-					    msecs_to_jiffies(1000));
+		wait_for_completion_timeout(&cpu_running, secs_to_jiffies(1));
 
 		if (!cpu_online(cpu)) {
 			pr_crit("CPU%u: failed to come online\n", cpu);

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] riscv: smp: use secs_to_jiffies in __cpu_up
  2026-06-11 23:25 [PATCH] riscv: smp: use secs_to_jiffies in __cpu_up Thorsten Blum
@ 2026-06-25 18:25 ` Paul Walmsley
  0 siblings, 0 replies; 2+ messages in thread
From: Paul Walmsley @ 2026-06-25 18:25 UTC (permalink / raw)
  To: Thorsten Blum
  Cc: Paul Walmsley, Palmer Dabbelt, Albert Ou, Alexandre Ghiti,
	Vivian Wang, Atish Patra, Anup Patel, linux-riscv, linux-kernel

On Fri, 12 Jun 2026, Thorsten Blum wrote:

> Use secs_to_jiffies() to simplify the code. Drop the redundant zero
> initialization while at it.
> 
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>

Thanks, queued for v7.2-rc.


- Paul

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-06-25 18:25 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-06-11 23:25 [PATCH] riscv: smp: use secs_to_jiffies in __cpu_up Thorsten Blum
2026-06-25 18:25 ` Paul Walmsley

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome