[PATCH v1 0/2] Add support for Synopsys DesignWare SSI controller version 2.00a

[PATCH v1 0/2] Add support for Synopsys DesignWare SSI controller version 2.00a

[Changhuang Liang]

Add support for Synopsys DesignWare SSI controller version 2.00a,
which is used on the JHB100 SoC.

Changhuang Liang (2):
  dt-bindings: spi: snps,dw-apb-ssi: Add support for snps,dwc-ssi-2.00a
  spi: dw: Add support for snps,dwc-ssi-2.00a

 Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml | 1 +
 drivers/spi/spi-dw-mmio.c                                  | 1 +
 2 files changed, 2 insertions(+)

--
2.25.1

[PATCH v1 1/2] dt-bindings: spi: snps,dw-apb-ssi: Add support for snps,dwc-ssi-2.00a

[Changhuang Liang]

Add a new compatible string "snps,dwc-ssi-2.00a" for the Synopsys
DesignWare SSI controller version 2.00a.

Signed-off-by: Changhuang Liang <changhuang.liang@starfivetech.com>
---
 Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml
index 8ebebcebca16..fb74243d4bdf 100644
--- a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml
+++ b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml
@@ -41,6 +41,7 @@ properties:
         enum:
           - snps,dw-apb-ssi
           - snps,dwc-ssi-1.01a
+          - snps,dwc-ssi-2.00a
       - description: Microchip Sparx5 SoC SPI Controller
         const: microchip,sparx5-spi
       - description: Amazon Alpine SPI Controller
-- 
2.25.1

[PATCH v1 2/2] spi: dw: Add support for snps,dwc-ssi-2.00a

[Changhuang Liang]

Add a new compatible entry "snps,dwc-ssi-2.00a" for the Synopsys
DesignWare SSI controller version 2.00a. This variant uses the same
initialization routine as snps,dwc-ssi-1.01a (dw_spi_hssi_init).

Signed-off-by: Changhuang Liang <changhuang.liang@starfivetech.com>
---
 drivers/spi/spi-dw-mmio.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/spi/spi-dw-mmio.c b/drivers/spi/spi-dw-mmio.c
index 4fc864d38cff..603e81a92c57 100644
--- a/drivers/spi/spi-dw-mmio.c
+++ b/drivers/spi/spi-dw-mmio.c
@@ -438,6 +438,7 @@ static const struct of_device_id dw_spi_mmio_of_match[] = {
 	{ .compatible = "amazon,alpine-dw-apb-ssi", .data = dw_spi_alpine_init},
 	{ .compatible = "renesas,rzn1-spi", .data = dw_spi_pssi_init},
 	{ .compatible = "snps,dwc-ssi-1.01a", .data = dw_spi_hssi_init},
+	{ .compatible = "snps,dwc-ssi-2.00a", .data = dw_spi_hssi_init},
 	{ .compatible = "intel,keembay-ssi", .data = dw_spi_hssi_no_dma_init},
 	{
 		.compatible = "intel,mountevans-imc-ssi",
-- 
2.25.1

Re: [PATCH v1 1/2] dt-bindings: spi: snps,dw-apb-ssi: Add support for snps,dwc-ssi-2.00a

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 509 bytes --]

On Fri, Jun 12, 2026 at 05:58:55AM -0700, Changhuang Liang wrote:

> Add a new compatible string "snps,dwc-ssi-2.00a" for the Synopsys
> DesignWare SSI controller version 2.00a.

Please submit patches using subject lines reflecting the style for the
subsystem, this makes it easier for people to identify relevant patches.
Look at what existing commits in the area you're changing are doing and
make sure your subject lines visually resemble what they're doing.
There's no need to resubmit to fix this alone.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH v1 1/2] dt-bindings: spi: snps,dw-apb-ssi: Add support for snps,dwc-ssi-2.00a

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 1338 bytes --]

On Fri, Jun 12, 2026 at 05:58:55AM -0700, Changhuang Liang wrote:
> Add a new compatible string "snps,dwc-ssi-2.00a" for the Synopsys
> DesignWare SSI controller version 2.00a.

Two things. Firstly, driver patch suggests a fallback to 1.01a is
possible. Why haven't you added one?
Secondly, I am going to expect that when your starfive user for this
appears in my inbox that it has a device-specific compatible, so you may
as well add that now.

pw-bot: changes-requested

Cheers,
Conor.

> 
> Signed-off-by: Changhuang Liang <changhuang.liang@starfivetech.com>
> ---
>  Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml
> index 8ebebcebca16..fb74243d4bdf 100644
> --- a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml
> +++ b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml
> @@ -41,6 +41,7 @@ properties:
>          enum:
>            - snps,dw-apb-ssi
>            - snps,dwc-ssi-1.01a
> +          - snps,dwc-ssi-2.00a
>        - description: Microchip Sparx5 SoC SPI Controller
>          const: microchip,sparx5-spi
>        - description: Amazon Alpine SPI Controller
> -- 
> 2.25.1
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH v1 1/2] dt-bindings: spi: snps,dw-apb-ssi: Add support for snps,dwc-ssi-2.00a

[Changhuang Liang]

Hi, Conor

Thanks for the review.

> On Fri, Jun 12, 2026 at 05:58:55AM -0700, Changhuang Liang wrote:
> > Add a new compatible string "snps,dwc-ssi-2.00a" for the Synopsys
> > DesignWare SSI controller version 2.00a.
> 
> Two things. Firstly, driver patch suggests a fallback to 1.01a is possible. Why
> haven't you added one?

Will support fallback.

> Secondly, I am going to expect that when your starfive user for this appears in
> my inbox that it has a device-specific compatible, so you may as well add that
> now.

Our standard SPI control is completely based on the Synopsys DesignWare SSI controller version 2.00a. 
However, for the controller that accesses the flash, a set of modifications has been made based on the 
Synopsys DesignWare SSI controller version 2.00a, and the driver part also requires specific adaptation.

Therefore, on the JHB100 SoC, the initial device tree source I have planned looks like this:

spi0: spi@17f20000 {
      compatible = "snps,dwc-ssi-2.00a";
      reg = <0x0 0x17f20000 0x0 0x10000>;
};

sfc0: spi@18000000 {
      compatible = "starfive,jhb100-spi";
      reg = <0x0 0x18000000 0x0 0x10000>;
};

Thus, I plan to add a new "starfive,jhb100-spi" compatible string for the controller that accesses the flash.
For now, I intend to keep these as two separate series.

Best Regards
Changhuang

Re: [PATCH v1 1/2] dt-bindings: spi: snps,dw-apb-ssi: Add support for snps,dwc-ssi-2.00a

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 1757 bytes --]

On Sat, Jun 13, 2026 at 03:38:46AM +0000, Changhuang Liang wrote:
> Hi, Conor
> 
> Thanks for the review.
> 
> > On Fri, Jun 12, 2026 at 05:58:55AM -0700, Changhuang Liang wrote:
> > > Add a new compatible string "snps,dwc-ssi-2.00a" for the Synopsys
> > > DesignWare SSI controller version 2.00a.
> > 
> > Two things. Firstly, driver patch suggests a fallback to 1.01a is possible. Why
> > haven't you added one?
> 
> Will support fallback.
> 
> > Secondly, I am going to expect that when your starfive user for this appears in
> > my inbox that it has a device-specific compatible, so you may as well add that
> > now.
> 
> Our standard SPI control is completely based on the Synopsys DesignWare SSI controller version 2.00a. 
> However, for the controller that accesses the flash, a set of modifications has been made based on the 
> Synopsys DesignWare SSI controller version 2.00a, and the driver part also requires specific adaptation.
> 
> Therefore, on the JHB100 SoC, the initial device tree source I have planned looks like this:
> 
> spi0: spi@17f20000 {
>       compatible = "snps,dwc-ssi-2.00a";
>       reg = <0x0 0x17f20000 0x0 0x10000>;
> };
> 
> sfc0: spi@18000000 {
>       compatible = "starfive,jhb100-spi";
>       reg = <0x0 0x18000000 0x0 0x10000>;
> };
> 
> Thus, I plan to add a new "starfive,jhb100-spi" compatible string for the controller that accesses the flash.
> For now, I intend to keep these as two separate series.

No, if you have two integrations of the designware IP with different
programming models on the jhb100 I expect to see two different
soc-specific compatibles used. I don't want to see bare synopsys
compatibles on the platforms I am looking after.

Cheers,
Conor.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH v1 1/2] dt-bindings: spi: snps,dw-apb-ssi: Add support for snps,dwc-ssi-2.00a

[Changhuang Liang]

Hi, Conor

> On Sat, Jun 13, 2026 at 03:38:46AM +0000, Changhuang Liang wrote:
> > Hi, Conor
> >
> > Thanks for the review.
> >
> > > On Fri, Jun 12, 2026 at 05:58:55AM -0700, Changhuang Liang wrote:
> > > > Add a new compatible string "snps,dwc-ssi-2.00a" for the Synopsys
> > > > DesignWare SSI controller version 2.00a.
> > >
> > > Two things. Firstly, driver patch suggests a fallback to 1.01a is
> > > possible. Why haven't you added one?
> >
> > Will support fallback.
> >
> > > Secondly, I am going to expect that when your starfive user for this
> > > appears in my inbox that it has a device-specific compatible, so you
> > > may as well add that now.
> >
> > Our standard SPI control is completely based on the Synopsys DesignWare
> SSI controller version 2.00a.
> > However, for the controller that accesses the flash, a set of
> > modifications has been made based on the Synopsys DesignWare SSI
> controller version 2.00a, and the driver part also requires specific adaptation.
> >
> > Therefore, on the JHB100 SoC, the initial device tree source I have planned
> looks like this:
> >
> > spi0: spi@17f20000 {
> >       compatible = "snps,dwc-ssi-2.00a";
> >       reg = <0x0 0x17f20000 0x0 0x10000>; };
> >
> > sfc0: spi@18000000 {
> >       compatible = "starfive,jhb100-spi";
> >       reg = <0x0 0x18000000 0x0 0x10000>; };
> >
> > Thus, I plan to add a new "starfive,jhb100-spi" compatible string for the
> controller that accesses the flash.
> > For now, I intend to keep these as two separate series.
> 
> No, if you have two integrations of the designware IP with different
> programming models on the jhb100 I expect to see two different soc-specific
> compatibles used. I don't want to see bare synopsys compatibles on the
> platforms I am looking after.

Okay, I will change it to the following:

spi0: spi@17f20000 {
      compatible = " starfive,jhb100-spi";
      reg = <0x0 0x17f20000 0x0 0x10000>; 
};

sfc0: spi@18000000 {
      compatible = "starfive,jhb100-sfc";
      reg = <0x0 0x18000000 0x0 0x10000>; 
};

Best Regards,
Changhuang

Re: [PATCH v1 1/2] dt-bindings: spi: snps,dw-apb-ssi: Add support for snps,dwc-ssi-2.00a

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 2587 bytes --]

On Mon, Jun 15, 2026 at 10:49:07AM +0000, Changhuang Liang wrote:
> Hi, Conor
> 
> > On Sat, Jun 13, 2026 at 03:38:46AM +0000, Changhuang Liang wrote:
> > > Hi, Conor
> > >
> > > Thanks for the review.
> > >
> > > > On Fri, Jun 12, 2026 at 05:58:55AM -0700, Changhuang Liang wrote:
> > > > > Add a new compatible string "snps,dwc-ssi-2.00a" for the Synopsys
> > > > > DesignWare SSI controller version 2.00a.
> > > >
> > > > Two things. Firstly, driver patch suggests a fallback to 1.01a is
> > > > possible. Why haven't you added one?
> > >
> > > Will support fallback.
> > >
> > > > Secondly, I am going to expect that when your starfive user for this
> > > > appears in my inbox that it has a device-specific compatible, so you
> > > > may as well add that now.
> > >
> > > Our standard SPI control is completely based on the Synopsys DesignWare
> > SSI controller version 2.00a.
> > > However, for the controller that accesses the flash, a set of
> > > modifications has been made based on the Synopsys DesignWare SSI
> > controller version 2.00a, and the driver part also requires specific adaptation.
> > >
> > > Therefore, on the JHB100 SoC, the initial device tree source I have planned
> > looks like this:
> > >
> > > spi0: spi@17f20000 {
> > >       compatible = "snps,dwc-ssi-2.00a";
> > >       reg = <0x0 0x17f20000 0x0 0x10000>; };
> > >
> > > sfc0: spi@18000000 {
> > >       compatible = "starfive,jhb100-spi";
> > >       reg = <0x0 0x18000000 0x0 0x10000>; };
> > >
> > > Thus, I plan to add a new "starfive,jhb100-spi" compatible string for the
> > controller that accesses the flash.
> > > For now, I intend to keep these as two separate series.
> > 
> > No, if you have two integrations of the designware IP with different
> > programming models on the jhb100 I expect to see two different soc-specific
> > compatibles used. I don't want to see bare synopsys compatibles on the
> > platforms I am looking after.
> 
> Okay, I will change it to the following:
> 
> spi0: spi@17f20000 {
>       compatible = " starfive,jhb100-spi";

This one is compatible with "snps,dwc-ssi-2.00a" and "snps,dwc-ssi-1.00a",
so it should probably have those as fallbacks. The latter for sure, the
former if you know there's some non-discoverable differences between 2.00a
and 1.00a hardware.

Cheers,
Conor.

>       reg = <0x0 0x17f20000 0x0 0x10000>; 
> };
> 
> sfc0: spi@18000000 {
>       compatible = "starfive,jhb100-sfc";
>       reg = <0x0 0x18000000 0x0 0x10000>; 
> };
> 
> Best Regards,
> Changhuang
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH v1 1/2] dt-bindings: spi: snps,dw-apb-ssi: Add support for snps,dwc-ssi-2.00a

[Changhuang Liang]

Hi, Conor

> On Mon, Jun 15, 2026 at 10:49:07AM +0000, Changhuang Liang wrote:
> > Hi, Conor
> >
> > > On Sat, Jun 13, 2026 at 03:38:46AM +0000, Changhuang Liang wrote:
> > > > Hi, Conor
> > > >
> > > > Thanks for the review.
> > > >
> > > > > On Fri, Jun 12, 2026 at 05:58:55AM -0700, Changhuang Liang wrote:
> > > > > > Add a new compatible string "snps,dwc-ssi-2.00a" for the
> > > > > > Synopsys DesignWare SSI controller version 2.00a.
> > > > >
> > > > > Two things. Firstly, driver patch suggests a fallback to 1.01a
> > > > > is possible. Why haven't you added one?
> > > >
> > > > Will support fallback.
> > > >
> > > > > Secondly, I am going to expect that when your starfive user for
> > > > > this appears in my inbox that it has a device-specific
> > > > > compatible, so you may as well add that now.
> > > >
> > > > Our standard SPI control is completely based on the Synopsys
> > > > DesignWare
> > > SSI controller version 2.00a.
> > > > However, for the controller that accesses the flash, a set of
> > > > modifications has been made based on the Synopsys DesignWare SSI
> > > controller version 2.00a, and the driver part also requires specific
> adaptation.
> > > >
> > > > Therefore, on the JHB100 SoC, the initial device tree source I
> > > > have planned
> > > looks like this:
> > > >
> > > > spi0: spi@17f20000 {
> > > >       compatible = "snps,dwc-ssi-2.00a";
> > > >       reg = <0x0 0x17f20000 0x0 0x10000>; };
> > > >
> > > > sfc0: spi@18000000 {
> > > >       compatible = "starfive,jhb100-spi";
> > > >       reg = <0x0 0x18000000 0x0 0x10000>; };
> > > >
> > > > Thus, I plan to add a new "starfive,jhb100-spi" compatible string
> > > > for the
> > > controller that accesses the flash.
> > > > For now, I intend to keep these as two separate series.
> > >
> > > No, if you have two integrations of the designware IP with different
> > > programming models on the jhb100 I expect to see two different
> > > soc-specific compatibles used. I don't want to see bare synopsys
> > > compatibles on the platforms I am looking after.
> >
> > Okay, I will change it to the following:
> >
> > spi0: spi@17f20000 {
> >       compatible = " starfive,jhb100-spi";
> 
> This one is compatible with "snps,dwc-ssi-2.00a" and "snps,dwc-ssi-1.00a", so
> it should probably have those as fallbacks. The latter for sure, the former if
> you know there's some non-discoverable differences between 2.00a and
> 1.00a hardware.
> 

'm not sure about the hardware differences between 2.00a and 1.00a at the moment either.
I'll use the following method first:

compatible = "starfive,jhb100-spi", "snps,dwc-ssi-2.00a", "snps,dwc-ssi-1.01a"

> Cheers,
> Conor.
> 
> >       reg = <0x0 0x17f20000 0x0 0x10000>; };
> >
> > sfc0: spi@18000000 {
> >       compatible = "starfive,jhb100-sfc";
> >       reg = <0x0 0x18000000 0x0 0x10000>; };
> >
> > Best Regards,
> > Changhuang
> >

Best Regards,
Changhuang