[PATCH] Input: tsc2007 - Read "ti,poll-period" as u32

[PATCH] Input: tsc2007 - Read "ti,poll-period" as u32

[Rob Herring (Arm)]

The "ti,poll-period" property is documented as a normal uint32 cell.
The driver used a u64 helper, which makes the helper type disagree with
the schema even though the stored value is still small.

Read "ti,poll-period" with the u32 helper matching the documented DT
cell size.

Assisted-by: Codex:gpt-5-5
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
 drivers/input/touchscreen/tsc2007_core.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/input/touchscreen/tsc2007_core.c b/drivers/input/touchscreen/tsc2007_core.c
index 524f14eb3da2..db18b712999d 100644
--- a/drivers/input/touchscreen/tsc2007_core.c
+++ b/drivers/input/touchscreen/tsc2007_core.c
@@ -224,7 +224,6 @@ static int tsc2007_get_pendown_state_gpio(struct device *dev)
 static int tsc2007_probe_properties(struct device *dev, struct tsc2007 *ts)
 {
 	u32 val32;
-	u64 val64;
 
 	if (!device_property_read_u32(dev, "ti,max-rt", &val32))
 		ts->max_rt = val32;
@@ -240,8 +239,8 @@ static int tsc2007_probe_properties(struct device *dev, struct tsc2007 *ts)
 	if (!device_property_read_u32(dev, "ti,fuzzz", &val32))
 		ts->fuzzz = val32;
 
-	if (!device_property_read_u64(dev, "ti,poll-period", &val64))
-		ts->poll_period = msecs_to_jiffies(val64);
+	if (!device_property_read_u32(dev, "ti,poll-period", &val32))
+		ts->poll_period = msecs_to_jiffies(val32);
 	else
 		ts->poll_period = msecs_to_jiffies(1);
 
-- 
2.53.0

Re: [PATCH] Input: tsc2007 - Read "ti,poll-period" as u32

[Rob Herring]

On Fri, Jun 12, 2026 at 4:50 PM Rob Herring (Arm) <robh@kernel.org> wrote:
>
> The "ti,poll-period" property is documented as a normal uint32 cell.
> The driver used a u64 helper, which makes the helper type disagree with
> the schema even though the stored value is still small.
>
> Read "ti,poll-period" with the u32 helper matching the documented DT
> cell size.
>
> Assisted-by: Codex:gpt-5-5
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> ---
>  drivers/input/touchscreen/tsc2007_core.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)

Ping

> diff --git a/drivers/input/touchscreen/tsc2007_core.c b/drivers/input/touchscreen/tsc2007_core.c
> index 524f14eb3da2..db18b712999d 100644
> --- a/drivers/input/touchscreen/tsc2007_core.c
> +++ b/drivers/input/touchscreen/tsc2007_core.c
> @@ -224,7 +224,6 @@ static int tsc2007_get_pendown_state_gpio(struct device *dev)
>  static int tsc2007_probe_properties(struct device *dev, struct tsc2007 *ts)
>  {
>         u32 val32;
> -       u64 val64;
>
>         if (!device_property_read_u32(dev, "ti,max-rt", &val32))
>                 ts->max_rt = val32;
> @@ -240,8 +239,8 @@ static int tsc2007_probe_properties(struct device *dev, struct tsc2007 *ts)
>         if (!device_property_read_u32(dev, "ti,fuzzz", &val32))
>                 ts->fuzzz = val32;
>
> -       if (!device_property_read_u64(dev, "ti,poll-period", &val64))
> -               ts->poll_period = msecs_to_jiffies(val64);
> +       if (!device_property_read_u32(dev, "ti,poll-period", &val32))
> +               ts->poll_period = msecs_to_jiffies(val32);
>         else
>                 ts->poll_period = msecs_to_jiffies(1);
>
> --
> 2.53.0
>