mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Biren Pandya <birenpandya@gmail.com>
To: linux-media@vger.kernel.org, mchehab@kernel.org
Cc: Biren Pandya <birenpandya@gmail.com>,
	Nicolas Dufresne <nicolas.dufresne@collabora.com>,
	Benjamin Gaignard <benjamin.gaignard@collabora.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: [PATCH 16/22] media: platform: hantro_drv: Add missing media_entity_cleanup()
Date: Sun, 14 Jun 2026 22:25:53 +0530	[thread overview]
Message-ID: <20260614165630.3896-17-birenpandya@gmail.com> (raw)
In-Reply-To: <20260614165630.3896-1-birenpandya@gmail.com>

Signed-off-by: Biren Pandya <birenpandya@gmail.com>
---
 drivers/media/platform/verisilicon/hantro_drv.c | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/drivers/media/platform/verisilicon/hantro_drv.c b/drivers/media/platform/verisilicon/hantro_drv.c
index 2e81877f640f..ad71c0402ef3 100644
--- a/drivers/media/platform/verisilicon/hantro_drv.c
+++ b/drivers/media/platform/verisilicon/hantro_drv.c
@@ -771,8 +771,10 @@ static int hantro_register_entity(struct media_device *mdev,
 		return ret;
 
 	ret = media_device_register_entity(mdev, entity);
-	if (ret)
+	if (ret) {
+		media_entity_cleanup(entity);
 		return ret;
+	}
 
 	return 0;
 }
@@ -860,12 +862,13 @@ static int hantro_attach_func(struct hantro_dev *vpu,
 
 err_rel_entity2:
 	media_device_unregister_entity(&func->sink);
-
+	media_entity_cleanup(&func->sink);
 err_rel_entity1:
 	media_device_unregister_entity(&func->proc);
-
+	media_entity_cleanup(&func->proc);
 err_rel_entity0:
 	media_device_unregister_entity(&func->vdev.entity);
+	media_entity_cleanup(&func->vdev.entity);
 	return ret;
 }
 
@@ -878,6 +881,9 @@ static void hantro_detach_func(struct hantro_func *func)
 	media_device_unregister_entity(&func->sink);
 	media_device_unregister_entity(&func->proc);
 	media_device_unregister_entity(&func->vdev.entity);
+	media_entity_cleanup(&func->sink);
+	media_entity_cleanup(&func->proc);
+	media_entity_cleanup(&func->vdev.entity);
 }
 
 static int hantro_add_func(struct hantro_dev *vpu, unsigned int funcid)
-- 
2.50.1 (Apple Git-155)


  parent reply	other threads:[~2026-06-14 16:57 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20260614165630.3896-1-birenpandya@gmail.com>
2026-06-14 16:55 ` [PATCH 01/22] media: i2c: cx25840-core: " Biren Pandya
2026-06-14 16:55 ` [PATCH 02/22] media: i2c: max9286: " Biren Pandya
2026-06-14 16:55 ` [PATCH 03/22] media: i2c: msp3400-driver: " Biren Pandya
2026-06-14 16:55 ` [PATCH 04/22] media: i2c: mt9v011: " Biren Pandya
2026-06-14 16:55 ` [PATCH 05/22] media: i2c: saa7115: " Biren Pandya
2026-06-14 16:55 ` [PATCH 06/22] media: platform: stm32-csi: " Biren Pandya
2026-06-14 16:55 ` [PATCH 07/22] media: platform: sun4i_csi: " Biren Pandya
2026-06-14 16:55 ` [PATCH 08/22] media: platform: microchip-isc-scaler: " Biren Pandya
2026-06-14 16:55 ` [PATCH 09/22] media: platform: cdns-csi2tx: " Biren Pandya
2026-06-14 16:55 ` [PATCH 10/22] media: platform: rcar-csi2: " Biren Pandya
2026-06-14 16:55 ` [PATCH 11/22] media: platform: csisp: " Biren Pandya
2026-06-14 16:55 ` [PATCH 12/22] media: platform: rcar-core: " Biren Pandya
2026-06-14 16:55 ` [PATCH 13/22] media: platform: rzg2l-core: " Biren Pandya
2026-06-14 16:55 ` [PATCH 14/22] media: platform: cfe: " Biren Pandya
2026-06-14 16:55 ` [PATCH 15/22] media: platform: j721e-csi2rx: " Biren Pandya
2026-06-14 16:55 ` Biren Pandya [this message]
2026-06-14 16:55 ` [PATCH 17/22] media: pci: saa7134: " Biren Pandya
2026-06-14 16:55 ` [PATCH 18/22] media: usb: cx231xx: " Biren Pandya
2026-06-14 16:55 ` [PATCH 19/22] media: usb: em28xx: " Biren Pandya
2026-06-14 16:55 ` [PATCH 20/22] media: usb: au0828: " Biren Pandya
2026-06-14 16:55 ` [PATCH 21/22] media: usb: dvb-usb-v2: " Biren Pandya
2026-06-14 16:55 ` [PATCH 22/22] media: dvb-frontends: au8522_decoder: " Biren Pandya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260614165630.3896-17-birenpandya@gmail.com \
    --to=birenpandya@gmail.com \
    --cc=benjamin.gaignard@collabora.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=mchehab@kernel.org \
    --cc=nicolas.dufresne@collabora.com \
    --cc=p.zabel@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®