From: Amit Barzilai <amit.barzilai22@gmail.com>
To: Javier Martinez Canillas <javierm@redhat.com>
Cc: Amit Barzilai <amit.barzilai22@gmail.com>,
airlied@gmail.com, conor+dt@kernel.org,
devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org,
krzk+dt@kernel.org, linux-kernel@vger.kernel.org,
maarten.lankhorst@linux.intel.com, mripard@kernel.org,
robh@kernel.org, simona@ffwll.ch, tzimmermann@suse.de
Subject: Re: [PATCH 0/2] drm: Add driver for the Solomon SSD1351 OLED controller
Date: Mon, 15 Jun 2026 21:12:49 +0300 [thread overview]
Message-ID: <20260615181253.97551-1-amit.barzilai22@gmail.com> (raw)
In-Reply-To: <877bo576o1.fsf@ocarina.mail-host-address-is-not-set>
Hi Javier,
Thanks you for the detailed review and for the Reviewed-by on the binding.
I agree with folding the SSD1351 into ssd130x rather than keeping it
standalone. My plan for the v2 driver series follows your two steps:
1. Add RGB565 support to the existing SSD133X family (so the SSD1331 gains
65k color), gating the format on a per-variant flag in device_info so the
existing RGB332 path is untouched.
2. Add a new SSD135X family for the SSD1351 on top of that, reusing the
ssd133x data path (the update_rect window logic is already
format-agnostic) and adding only the SSD1351-specific bits - the 0x5c
write-RAM command and its init sequence.
I'm deferring step 3 (native 256k color) for now since, as you suspected,
there's no matching DRM fourcc, and I'm dropping the 0/180 rotation support
to keep the series focused; it can come back later.
Two things I'd like to confirm before I send the series:
- I have an SSD1331 panel, but it is currently unsoldered and I don't have
the means to solder it myself. I'm trying to arrange testing through
someone else - I can't promise it will work out. If it doesn't, the
SSD1331 RGB565 change would be compile-tested only (I do have SSD1351
hardware to test the new family). Is compile-tested-only acceptable for
the SSD1331 part, or would you prefer I hold that piece until it can be
verified on hardware?
- Could you confirm the RGB565 byte order the SSD1331 expects? The
standalone SSD1351 code used big-endian (drm_fb_xrgb8888_to_rgb565be);
I want the shared conversion helper to match the SSD1331 datasheet.
Separately, I've sent the DT binding as a standalone v2. Since I dropped the
width/height and rotation properties per Krzysztof's review, I did not carry
your Reviewed-by forward - please re-review at your convenience.
Thanks,
Amit
next prev parent reply other threads:[~2026-06-15 18:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-10 16:44 Amit Barzilai
2026-06-10 16:44 ` [PATCH 1/2] dt-bindings: display: Add " Amit Barzilai
2026-06-11 9:45 ` Javier Martinez Canillas
2026-06-11 10:39 ` Krzysztof Kozlowski
2026-06-15 18:10 ` Amit Barzilai
2026-06-10 16:44 ` [PATCH 2/2] drm/solomon: Add SSD1351 OLED display driver Amit Barzilai
2026-06-19 13:52 ` Uwe Kleine-König
2026-06-11 9:44 ` [PATCH 0/2] drm: Add driver for the Solomon SSD1351 OLED controller Javier Martinez Canillas
2026-06-15 18:12 ` Amit Barzilai [this message]
2026-06-16 8:55 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260615181253.97551-1-amit.barzilai22@gmail.com \
--to=amit.barzilai22@gmail.com \
--cc=airlied@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=javierm@redhat.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=robh@kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®