mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] platform/x86: hp-wmi: Add fan control support for OMEN 8C4D
@ 2026-06-16  1:41 Lauri Sarap
  2026-07-01 11:31 ` Ilpo Järvinen
  0 siblings, 1 reply; 2+ messages in thread
From: Lauri Sarap @ 2026-06-16  1:41 UTC (permalink / raw)
  To: Hans de Goede, Ilpo Järvinen
  Cc: platform-driver-x86, linux-kernel, Lauri Sarap

The HP OMEN Transcend 16-u1xxx with board ID 8C4D uses the
Victus S fan control path with OMEN v1 thermal profile parameters.

Manual fan control has been tested through the hwmon pwm interface. The
legacy OMEN profile path exposes controls but does not change fan speed
on this board; the Victus S table with omen_v1_thermal_params provides
working fan RPM changes.

Assisted-by: Codex:GPT-5
Signed-off-by: Lauri Sarap <lauri.aardla@gmail.com>
---
 drivers/platform/x86/hp/hp-wmi.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/platform/x86/hp/hp-wmi.c b/drivers/platform/x86/hp/hp-wmi.c
index d1cc6e7d1..ffe229ec0 100644
--- a/drivers/platform/x86/hp/hp-wmi.c
+++ b/drivers/platform/x86/hp/hp-wmi.c
@@ -221,6 +221,10 @@ static const struct dmi_system_id victus_s_thermal_profile_boards[] __initconst
 		.matches = { DMI_MATCH(DMI_BOARD_NAME, "8BD5") },
 		.driver_data = (void *)&victus_s_thermal_params,
 	},
+	{
+		.matches = { DMI_MATCH(DMI_BOARD_NAME, "8C4D") },
+		.driver_data = (void *)&omen_v1_thermal_params,
+	},
 	{
 		.matches = { DMI_MATCH(DMI_BOARD_NAME, "8C76") },
 		.driver_data = (void *)&omen_v1_thermal_params,

base-commit: 254f49634ee16a731174d2ae34bc50bd5f45e731
-- 
2.54.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] platform/x86: hp-wmi: Add fan control support for OMEN 8C4D
  2026-06-16  1:41 [PATCH] platform/x86: hp-wmi: Add fan control support for OMEN 8C4D Lauri Sarap
@ 2026-07-01 11:31 ` Ilpo Järvinen
  0 siblings, 0 replies; 2+ messages in thread
From: Ilpo Järvinen @ 2026-07-01 11:31 UTC (permalink / raw)
  To: Lauri Sarap; +Cc: Hans de Goede, platform-driver-x86, LKML

On Tue, 16 Jun 2026, Lauri Sarap wrote:

> The HP OMEN Transcend 16-u1xxx with board ID 8C4D uses the
> Victus S fan control path with OMEN v1 thermal profile parameters.
> 
> Manual fan control has been tested through the hwmon pwm interface. The
> legacy OMEN profile path exposes controls but does not change fan speed
> on this board; the Victus S table with omen_v1_thermal_params provides
> working fan RPM changes.
> 
> Assisted-by: Codex:GPT-5
> Signed-off-by: Lauri Sarap <lauri.aardla@gmail.com>
> ---
>  drivers/platform/x86/hp/hp-wmi.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/platform/x86/hp/hp-wmi.c b/drivers/platform/x86/hp/hp-wmi.c
> index d1cc6e7d1..ffe229ec0 100644
> --- a/drivers/platform/x86/hp/hp-wmi.c
> +++ b/drivers/platform/x86/hp/hp-wmi.c
> @@ -221,6 +221,10 @@ static const struct dmi_system_id victus_s_thermal_profile_boards[] __initconst
>  		.matches = { DMI_MATCH(DMI_BOARD_NAME, "8BD5") },
>  		.driver_data = (void *)&victus_s_thermal_params,
>  	},
> +	{
> +		.matches = { DMI_MATCH(DMI_BOARD_NAME, "8C4D") },
> +		.driver_data = (void *)&omen_v1_thermal_params,
> +	},
>  	{
>  		.matches = { DMI_MATCH(DMI_BOARD_NAME, "8C76") },
>  		.driver_data = (void *)&omen_v1_thermal_params,

Thanks for the patch.

hp-wmi driver's .driver_data scope has been expanded. Please check the 
very changes recently added into the review-ilpo-next branch in the 
platform drivers repo and adapt this patch accordingly. Then post v2, 
thank you.

-- 
 i.


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-07-01 11:31 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-06-16  1:41 [PATCH] platform/x86: hp-wmi: Add fan control support for OMEN 8C4D Lauri Sarap
2026-07-01 11:31 ` Ilpo Järvinen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome