mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Haiyue Wang <haiyuewa@163.com>
To: linux-gpio@vger.kernel.org
Cc: Haiyue Wang <haiyuewa@163.com>, Linus Walleij <linusw@kernel.org>,
	Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>,
	linux-kernel@vger.kernel.org (open list)
Subject: [PATCH v1] pinctrl: Kconfig: fix unmet direct dependencies detected for MFD_STMFX
Date: Tue, 16 Jun 2026 14:52:37 +0800	[thread overview]
Message-ID: <20260616065241.7478-1-haiyuewa@163.com> (raw)

The commit e785c990adcc ("pinctrl: Kconfig: drop unneeded dependencies
on OF_GPIO") will cause:

WARNING: unmet direct dependencies detected for MFD_STMFX
  Depends on [n]: HAS_IOMEM [=y] && I2C [=y] && OF [=n]
  Selected by [m]:
  - PINCTRL_STMFX [=m] && PINCTRL [=y] && I2C [=y] && HAS_IOMEM [=y]

PINCTRL_STMFX selects MFD_STMFX, which depends on OF. Previously this
was gated transitively by OF_GPIO, which is dropped. So PINCTRL_STMFX
can be enabled on non-OF systems and select MFD_STMFX in violation of
its OF requirement. Add the missing "depends on OF".

Fixes: e785c990adcc ("pinctrl: Kconfig: drop unneeded dependencies on OF_GPIO")
Signed-off-by: Haiyue Wang <haiyuewa@163.com>
---
 drivers/pinctrl/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
index 03f2e3ee065f..08218ef140e0 100644
--- a/drivers/pinctrl/Kconfig
+++ b/drivers/pinctrl/Kconfig
@@ -549,6 +549,7 @@ config PINCTRL_ST
 config PINCTRL_STMFX
 	tristate "STMicroelectronics STMFX GPIO expander pinctrl driver"
 	depends on I2C
+	depends on OF
 	depends on HAS_IOMEM
 	select GENERIC_PINCONF
 	select GPIOLIB_IRQCHIP
-- 
2.54.0


             reply	other threads:[~2026-06-16  6:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-16  6:52 Haiyue Wang [this message]
2026-06-16  6:59 ` Haiyue Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260616065241.7478-1-haiyuewa@163.com \
    --to=haiyuewa@163.com \
    --cc=bartosz.golaszewski@oss.qualcomm.com \
    --cc=linusw@kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®