Re: [PATCH v1] pinctrl: Kconfig: fix unmet direct dependencies detected for MFD_STMFX

[Haiyue Wang <haiyuewa@163.com>]

Linus,

Sorry, please ignore my patch,I found it has been fixed in next tree.

BR,
Haiyue

On 6/16/2026 2:52 PM, Haiyue Wang wrote:
> The commit e785c990adcc ("pinctrl: Kconfig: drop unneeded dependencies
> on OF_GPIO") will cause:
> 
> WARNING: unmet direct dependencies detected for MFD_STMFX
>    Depends on [n]: HAS_IOMEM [=y] && I2C [=y] && OF [=n]
>    Selected by [m]:
>    - PINCTRL_STMFX [=m] && PINCTRL [=y] && I2C [=y] && HAS_IOMEM [=y]
> 
> PINCTRL_STMFX selects MFD_STMFX, which depends on OF. Previously this
> was gated transitively by OF_GPIO, which is dropped. So PINCTRL_STMFX
> can be enabled on non-OF systems and select MFD_STMFX in violation of
> its OF requirement. Add the missing "depends on OF".
> 
> Fixes: e785c990adcc ("pinctrl: Kconfig: drop unneeded dependencies on OF_GPIO")
> Signed-off-by: Haiyue Wang <haiyuewa@163.com>
> ---
>   drivers/pinctrl/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
> index 03f2e3ee065f..08218ef140e0 100644
> --- a/drivers/pinctrl/Kconfig
> +++ b/drivers/pinctrl/Kconfig
> @@ -549,6 +549,7 @@ config PINCTRL_ST
>   config PINCTRL_STMFX
>   	tristate "STMicroelectronics STMFX GPIO expander pinctrl driver"
>   	depends on I2C
> +	depends on OF
>   	depends on HAS_IOMEM
>   	select GENERIC_PINCONF
>   	select GPIOLIB_IRQCHIP