mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: "Yicong Yang" <yang.yicong@picoheart.com>
Cc: <xueshuai@linux.alibaba.com>, <renyu.zj@linux.alibaba.com>,
	<will@kernel.org>, <mark.rutland@arm.com>,
	<linux-kernel@vger.kernel.org>, <bhelgaas@google.com>,
	<jingoohan1@gmail.com>, <mani@kernel.org>,
	<juwenlong@picoheart.com>, <geshijian@picoheart.com>,
	<douyufan@picoheart.com>
Subject: Re: [PATCH v1 3/3] perf/dwc_pcie: Convert to faux device interface
Date: Tue, 16 Jun 2026 13:53:17 +0100	[thread overview]
Message-ID: <20260616135317.546b784c@jic23-huawei> (raw)
In-Reply-To: <20260615063459.25361-4-yang.yicong@picoheart.com>

On Mon, 15 Jun 2026 14:34:59 +0800
"Yicong Yang" <yang.yicong@picoheart.com> wrote:

> The DWC PCIe PMU makes use of the platform device interface but
> is not the real device, it's actually the RAS DES capability of
> the root port. It's more appropriate to use the lightweight
> faux framework to abstract this, it'll be more simple and no
> need for the complete device and drivers model. So convert to
> the faux device interface.
I'd perhaps add a little here to say that he cpu hp callbacks might
be reordered wrt to the registration.  That looks fine to me but
it's a little more complex than this patch description made me think.

> 
> No functional changes intended.
> 
> Signed-off-by: Yicong Yang <yang.yicong@picoheart.com>
> ---
>  drivers/perf/dwc_pcie_pmu.c | 101 +++++++++++++++++-------------------
>  1 file changed, 48 insertions(+), 53 deletions(-)
> 
> diff --git a/drivers/perf/dwc_pcie_pmu.c b/drivers/perf/dwc_pcie_pmu.c
> index abf50f173202..fee040f8b833 100644
> --- a/drivers/perf/dwc_pcie_pmu.c
> +++ b/drivers/perf/dwc_pcie_pmu.c
> @@ -17,10 +17,10 @@
>  #include <linux/pcie-dwc.h>
>  #include <linux/perf_event.h>
>  #include <linux/pci.h>
> -#include <linux/platform_device.h>
>  #include <linux/smp.h>
>  #include <linux/sysfs.h>
>  #include <linux/types.h>
> +#include <linux/device/faux.h>
>  
Why there?  Seems like they are alphabetical order so should be up
under d.

Other than that looks fine to me.

Reviewed-by: Jonathan Cameron <jic23@kernel.org>

  reply	other threads:[~2026-06-16 12:53 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-15  6:34 [PATCH v1 0/3] New vendor support and optimizations for DWC PCIe PMU Yicong Yang
2026-06-15  6:34 ` [PATCH v1 1/3] perf/dwc_pcie: Add support for Picoheart vendor devices Yicong Yang
2026-06-15  6:34 ` [PATCH v1 2/3] perf/dwc_pcie: Support narrowed time-based counter for long time monitoring Yicong Yang
2026-06-16 11:34   ` Jonathan Cameron
2026-06-16 13:29     ` Yicong Yang
2026-06-15  6:34 ` [PATCH v1 3/3] perf/dwc_pcie: Convert to faux device interface Yicong Yang
2026-06-16 12:53   ` Jonathan Cameron [this message]
2026-06-16 13:38     ` Yicong Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260616135317.546b784c@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=bhelgaas@google.com \
    --cc=douyufan@picoheart.com \
    --cc=geshijian@picoheart.com \
    --cc=jingoohan1@gmail.com \
    --cc=juwenlong@picoheart.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mani@kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=renyu.zj@linux.alibaba.com \
    --cc=will@kernel.org \
    --cc=xueshuai@linux.alibaba.com \
    --cc=yang.yicong@picoheart.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®